Summary

Register type equality checks for Q and F objects.

Review Request #12039 — Created Feb. 4, 2022 and submitted March 6, 2022, 5:37 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

release-2.x

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

TestCase now registers the existing assertQEqual() and a new
assertFEqual() for comparing Q and F objects. This enables
comparison without having to explicitly call those helper methods. This
simplifies unit testing and reduces the chances of issues on different
versions of Django.

Testing Done

Unit tests pass for all supported versions of Python and Django.

Commits

Summary	ID
Register type equality checks for Q and F objects. `TestCase` now registers the existing `assertQEqual()` and a new `assertFEqual()` for comparing `Q` and `F` objects. This enables comparison without having to explicitly call those helper methods. This simplifies unit testing and reduces the chances of issues on different versions of Django.	b5b2d927b50d9fd98f8fb9e9bd2f4aa5fb2c0cba

Issues

Description	From	Last Updated
F821 undefined name 'f1'	reviewbot	Feb. 4, 2022, 6:36 p.m.
F821 undefined name 'f2'	reviewbot	Feb. 4, 2022, 6:36 p.m.
F821 undefined name 'f1'	reviewbot	Feb. 4, 2022, 6:36 p.m.
F821 undefined name 'f2'	reviewbot	Feb. 4, 2022, 6:36 p.m.
F821 undefined name 'f1'	reviewbot	Feb. 4, 2022, 6:36 p.m.
F821 undefined name 'f2'	reviewbot	Feb. 4, 2022, 6:36 p.m.

flake8 failed.

JSHint passed.

flake8

django_evolution/tests/base_test_case.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'f1'
```
django_evolution/tests/base_test_case.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'f2'
```
django_evolution/tests/base_test_case.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'f1'
```
django_evolution/tests/base_test_case.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'f2'
```
django_evolution/tests/base_test_case.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'f1'
```
django_evolution/tests/base_test_case.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F821 undefined name 'f2'
```

Change Summary:

Added a missing parameter fix committed to the wrong branch.

Commits:

	Summary	ID
	Register type equality checks for Q and F objects. `TestCase` now registers the existing `assertQEqual()` and a new `assertFEqual()` for comparing `Q` and `F` objects. This enables comparison without having to explicitly call those helper methods. This simplifies unit testing and reduces the chances of issues on different versions of Django.	ea4f4f8e44aab2b2aa0d3512f3a84fdc59e34dd8
	Register type equality checks for Q and F objects. `TestCase` now registers the existing `assertQEqual()` and a new `assertFEqual()` for comparing `Q` and `F` objects. This enables comparison without having to explicitly call those helper methods. This simplifies unit testing and reduces the chances of issues on different versions of Django.	b5b2d927b50d9fd98f8fb9e9bd2f4aa5fb2c0cba

Diff:

Revision 2 (+132 -18)

Show changes

	django_evolution/tests/base_test_case.py
	django_evolution/tests/test_serialization.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.x (2c54d98)