Summary

Experimantal GraphQL Endpoint

Review Request #12036 — Created Feb. 4, 2022 and updated April 8, 2022, 3:57 p.m.

Information

Owner

dronan

Repository

Review Board

Branch

master

Bugs

Depends On

12228

Reviewers

Groups

reviewboard

People

Description

Add an experimental GraphQL API endpoint. 
This change introduces a new endpoint at /graphql, which handles GraphQL requests. The endpoint accepts POST requests with the body containing a valid GraphQL query. The schema for the API is generated by functions that map existing WebAPIResource's into GraphQL types. This change also includes the query resolvers, which are called by the py-gql function graphql_blocking, that query, filter, and return data from the database. Currently, only the User and ReviewRequest objects have been defined in the schema and have resolvers.
The filtering logic in resolve_review_requests uses essentially the same logic as the filtering in the review_request resource, with some slight changes due to the difference in GrapgQL schema and REST query parameters. Ideally, this code would be refactored and DRY'ed out. Additionally, when building the schema we may eventually want to define the ResourceList and Resource types as a nested type, to take full advantage of the technology. For now, these are typed as objects with href, method, and title as they currently are in the other API resources.

Testing Done

Added unit tests for GraphQLResource and the User, Users, ReviewRequest, and ReviewRequests resolvers.
Ran all reviewboard tests.

Commits

Summary	ID
Experimantal GraphQL Endpoint	40a838e2c8bca9927c3aceeb8b0025031ca0f4e2

Issues

Description	From	Last Updated
E501 line too long (88 > 79 characters)	reviewbot	Feb. 11, 2022, 7:44 p.m.
E501 line too long (134 > 79 characters)	reviewbot	Feb. 11, 2022, 7:44 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Feb. 11, 2022, 7:44 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Feb. 11, 2022, 7:44 p.m.
W291 trailing whitespace	reviewbot	Feb. 11, 2022, 7:44 p.m.
E305 expected 2 blank lines after class or function definition, found 1	reviewbot	Feb. 11, 2022, 7:44 p.m.
E124 closing bracket does not match visual indentation	reviewbot	Feb. 11, 2022, 7:44 p.m.
W291 trailing whitespace	reviewbot	Feb. 11, 2022, 7:44 p.m.
E222 multiple spaces after operator	reviewbot	Feb. 11, 2022, 7:44 p.m.
E222 multiple spaces after operator	reviewbot	Feb. 11, 2022, 7:44 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 11, 2022, 7:44 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 11, 2022, 7:44 p.m.
E501 line too long (100 > 79 characters)	reviewbot	Feb. 11, 2022, 7:44 p.m.
W291 trailing whitespace	reviewbot	Feb. 11, 2022, 7:44 p.m.
E501 line too long (116 > 79 characters)	reviewbot	Feb. 11, 2022, 7:44 p.m.
W291 trailing whitespace	reviewbot	Feb. 11, 2022, 7:44 p.m.
W291 trailing whitespace	reviewbot	Feb. 11, 2022, 7:44 p.m.
W291 trailing whitespace	reviewbot	Feb. 11, 2022, 7:44 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 11, 2022, 7:44 p.m.
E305 expected 2 blank lines after class or function definition, found 1	reviewbot	Feb. 11, 2022, 7:44 p.m.
W292 no newline at end of file	reviewbot	Feb. 11, 2022, 7:44 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Feb. 18, 2022, 4:45 p.m.
E261 at least two spaces before inline comment	reviewbot	Feb. 18, 2022, 4:45 p.m.
E501 line too long (101 > 79 characters)	reviewbot	Feb. 18, 2022, 4:45 p.m.
E221 multiple spaces before operator	reviewbot	Feb. 18, 2022, 4:45 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Feb. 18, 2022, 4:45 p.m.
E225 missing whitespace around operator	reviewbot	Feb. 18, 2022, 4:45 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 18, 2022, 4:45 p.m.
W291 trailing whitespace	reviewbot	Feb. 18, 2022, 4:45 p.m.
E305 expected 2 blank lines after class or function definition, found 1	reviewbot	Feb. 18, 2022, 4:45 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 18, 2022, 4:45 p.m.
E124 closing bracket does not match visual indentation	reviewbot	Feb. 18, 2022, 4:45 p.m.
W291 trailing whitespace	reviewbot	Feb. 18, 2022, 4:45 p.m.
E222 multiple spaces after operator	reviewbot	Feb. 18, 2022, 4:45 p.m.
E222 multiple spaces after operator	reviewbot	Feb. 18, 2022, 4:45 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 18, 2022, 4:45 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 18, 2022, 4:45 p.m.
E501 line too long (100 > 79 characters)	reviewbot	Feb. 18, 2022, 4:45 p.m.
W291 trailing whitespace	reviewbot	Feb. 18, 2022, 4:45 p.m.
E501 line too long (116 > 79 characters)	reviewbot	Feb. 18, 2022, 4:45 p.m.
W291 trailing whitespace	reviewbot	Feb. 18, 2022, 4:45 p.m.
W291 trailing whitespace	reviewbot	Feb. 18, 2022, 4:45 p.m.
W291 trailing whitespace	reviewbot	Feb. 18, 2022, 4:45 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 18, 2022, 4:45 p.m.
E305 expected 2 blank lines after class or function definition, found 1	reviewbot	Feb. 18, 2022, 4:45 p.m.
W292 no newline at end of file	reviewbot	Feb. 18, 2022, 4:45 p.m.
E221 multiple spaces before operator	reviewbot	Feb. 25, 2022, 12:32 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Feb. 25, 2022, 12:32 p.m.
W291 trailing whitespace	reviewbot	Feb. 25, 2022, 12:32 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 25, 2022, 12:32 p.m.
E305 expected 2 blank lines after class or function definition, found 1	reviewbot	Feb. 25, 2022, 12:32 p.m.
W291 trailing whitespace	reviewbot	Feb. 25, 2022, 12:32 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 25, 2022, 12:32 p.m.
E124 closing bracket does not match visual indentation	reviewbot	Feb. 25, 2022, 12:32 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 25, 2022, 12:32 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 25, 2022, 12:32 p.m.
E501 line too long (100 > 79 characters)	reviewbot	Feb. 25, 2022, 12:32 p.m.
E501 line too long (116 > 79 characters)	reviewbot	Feb. 25, 2022, 12:32 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 25, 2022, 12:32 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Feb. 25, 2022, 12:32 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Feb. 25, 2022, 12:32 p.m.
E501 line too long (82 > 79 characters)	reviewbot	Feb. 25, 2022, 12:32 p.m.
E225 missing whitespace around operator	reviewbot	Feb. 25, 2022, 12:32 p.m.
W293 blank line contains whitespace	reviewbot	Feb. 25, 2022, 12:32 p.m.
W291 trailing whitespace	reviewbot	Feb. 25, 2022, 12:32 p.m.
E501 line too long (96 > 79 characters)	reviewbot	Feb. 25, 2022, 12:32 p.m.
E122 continuation line missing indentation or outdented	reviewbot	Feb. 25, 2022, 12:32 p.m.
W292 no newline at end of file	reviewbot	Feb. 25, 2022, 12:32 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Feb. 25, 2022, 12:32 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Feb. 25, 2022, 12:47 p.m.
E305 expected 2 blank lines after class or function definition, found 1	reviewbot	Feb. 25, 2022, 12:47 p.m.
E124 closing bracket does not match visual indentation	reviewbot	Feb. 25, 2022, 12:47 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Feb. 25, 2022, 12:47 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Feb. 25, 2022, 12:47 p.m.
E501 line too long (82 > 79 characters)	reviewbot	Feb. 25, 2022, 12:47 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Feb. 25, 2022, 12:47 p.m.
E201 whitespace after '{'	reviewbot	Feb. 25, 2022, 12:47 p.m.
E202 whitespace before '}'	reviewbot	Feb. 25, 2022, 12:47 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Feb. 25, 2022, 12:47 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Feb. 25, 2022, 12:47 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Feb. 25, 2022, 12:47 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Feb. 25, 2022, 12:47 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Feb. 25, 2022, 12:47 p.m.
E231 missing whitespace after ':'	reviewbot	Feb. 25, 2022, 12:47 p.m.
E501 line too long (120 > 79 characters)	reviewbot	Feb. 25, 2022, 12:47 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Feb. 25, 2022, 12:47 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Feb. 25, 2022, 12:47 p.m.
E201 whitespace after '{'	reviewbot	Feb. 25, 2022, 12:47 p.m.
E202 whitespace before '}'	reviewbot	Feb. 25, 2022, 12:47 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Feb. 25, 2022, 12:47 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Feb. 25, 2022, 12:47 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Feb. 25, 2022, 12:47 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Feb. 25, 2022, 12:47 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Feb. 25, 2022, 12:47 p.m.
E201 whitespace after '{'	reviewbot	Feb. 25, 2022, 12:47 p.m.
E202 whitespace before '}'	reviewbot	Feb. 25, 2022, 12:47 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Feb. 25, 2022, 12:47 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Feb. 25, 2022, 12:47 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Feb. 25, 2022, 12:47 p.m.
We'll need to add a dependency for this to reviewboard/dependencies.py	david	March 4, 2022, 8:31 a.m.
variable names should always start lower-case. Here and elsewhere.	david	March 4, 2022, 8:31 a.m.
For normal strings we prefer single quotes. The only times we use double quotes are docstrings/multiline strings, or if the …	david	March 4, 2022, 8:33 a.m.
type is a builtin. We should use a different name for this. In python, it's also much more efficient to …	david	March 4, 2022, 8:33 a.m.
E999 SyntaxError: invalid syntax	reviewbot	March 4, 2022, 8:33 a.m.
Can be elif type in ('Choice', 'List'):	david	March 4, 2022, 8:33 a.m.
We should build an array and then use '\n'.join(...) instead of concatenations.	david	March 4, 2022, 8:33 a.m.
None of these are actually format strings.	david	March 4, 2022, 8:33 a.m.
Using the f-string syntax here is confusing (it's not entirely clear what is schema syntax and what is format syntax. …	david	March 4, 2022, 8:33 a.m.
This seems very inefficient. Is there some built-in pagination structure to py_gql?	david	April 4, 2022, 9:57 p.m.
E999 SyntaxError: invalid syntax	reviewbot	March 4, 2022, 8:33 a.m.
E999 SyntaxError: invalid syntax	reviewbot	March 11, 2022, 11:09 a.m.
E999 SyntaxError: invalid syntax	reviewbot	March 11, 2022, 11:09 a.m.
E999 SyntaxError: invalid syntax	reviewbot	March 18, 2022, 4:16 p.m.
E999 SyntaxError: invalid syntax	reviewbot	March 18, 2022, 4:16 p.m.
E999 SyntaxError: invalid syntax	reviewbot	March 25, 2022, 4:13 p.m.
E501 line too long (80 > 79 characters)	reviewbot	March 25, 2022, 4:13 p.m.
E501 line too long (129 > 79 characters)	reviewbot	March 25, 2022, 4:13 p.m.
E501 line too long (83 > 79 characters)	reviewbot	March 25, 2022, 4:13 p.m.
E501 line too long (82 > 79 characters)	reviewbot	March 25, 2022, 4:13 p.m.
E999 SyntaxError: invalid syntax	reviewbot	March 25, 2022, 4:13 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 25, 2022, 4:13 p.m.
E202 whitespace before ')'	reviewbot	March 25, 2022, 4:18 p.m.
E999 SyntaxError: invalid syntax	reviewbot	March 25, 2022, 4:18 p.m.
W291 trailing whitespace	reviewbot	March 25, 2022, 4:18 p.m.
E501 line too long (80 > 79 characters)	reviewbot	March 25, 2022, 4:18 p.m.
E501 line too long (83 > 79 characters)	reviewbot	March 25, 2022, 4:18 p.m.
W291 trailing whitespace	reviewbot	March 25, 2022, 4:18 p.m.
W293 blank line contains whitespace	reviewbot	March 25, 2022, 4:18 p.m.
E128 continuation line under-indented for visual indent	reviewbot	March 25, 2022, 4:18 p.m.
W291 trailing whitespace	reviewbot	March 25, 2022, 4:18 p.m.
W291 trailing whitespace	reviewbot	March 25, 2022, 4:18 p.m.
E999 SyntaxError: invalid syntax	reviewbot	March 25, 2022, 4:18 p.m.
E501 line too long (80 > 79 characters)	reviewbot	March 25, 2022, 4:18 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 25, 2022, 4:18 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 25, 2022, 4:18 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 25, 2022, 4:18 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 25, 2022, 4:18 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 25, 2022, 4:18 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 25, 2022, 4:18 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 25, 2022, 4:18 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 25, 2022, 4:18 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 25, 2022, 4:18 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 25, 2022, 4:18 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 25, 2022, 4:18 p.m.
E127 continuation line over-indented for visual indent	reviewbot	March 25, 2022, 4:18 p.m.
E999 SyntaxError: invalid syntax	reviewbot	April 1, 2022, 8:20 p.m.
E999 SyntaxError: invalid syntax	reviewbot	April 1, 2022, 8:20 p.m.
This needs a module docstring.	david	April 4, 2022, 9:57 p.m.
These should be sorted into two groups: All "third party" imports (including djblets) All reviewboard imports. Please sort them alphabetically …	david	April 4, 2022, 9:57 p.m.
This should be in the imperative mood ("Return" instead of "Returns").	david	April 4, 2022, 9:57 p.m.
This needs an explanation.	david	April 4, 2022, 9:57 p.m.
Please change "String" to "str"	david	April 4, 2022, 9:57 p.m.
I believe that blank line is not needed after function docstring.	sheenaNg	April 7, 2022, 1:25 p.m.
Please add a blank line between these two.	david	April 4, 2022, 9:57 p.m.
Please add a blank line between these two.	david	April 4, 2022, 9:57 p.m.
E999 SyntaxError: invalid syntax	reviewbot	April 4, 2022, 9:59 p.m.
Returns -> Return	david	April 4, 2022, 9:57 p.m.
This needs an explanation.	david	April 4, 2022, 9:57 p.m.
String -> str	david	April 4, 2022, 9:57 p.m.
I believe that blank line is not needed after function docstring.	sheenaNg	April 7, 2022, 1:25 p.m.
Blank line between these two.	david	April 4, 2022, 9:57 p.m.
This is a little funky. How about we define a schema_fmt and then do schema = schema_fmt.format(...)?	david	April 4, 2022, 9:57 p.m.
This wrapping is awkward. How about: ```python def resolve_users( _root, ctx, _info, query_params={ 'page': 0, ... }):	david	April 4, 2022, 9:57 p.m.
Blank line in here. We also need entries for _root and _info, which at least explain why they're unused.	david	April 4, 2022, 9:57 p.m.
We can use a list comprehension here: data = [ serializer.serialize_object(user, request) for user in query ]	david	April 4, 2022, 9:57 p.m.
Same comments here as the docstring for resolve_users.	david	April 4, 2022, 9:58 p.m.
Blank line between these two.	david	April 4, 2022, 9:58 p.m.
Blank line between these two.	david	April 4, 2022, 9:58 p.m.
Same comments here as the docstring for resolve_users.	david	April 4, 2022, 9:58 p.m.
I think it would be easier to read if a blank line is added between these two lines.	sheenaNg	April 7, 2022, 1:25 p.m.
I think it would be easier to read if a blank line is added between these two lines.	sheenaNg	April 7, 2022, 1:25 p.m.
I think it would be easier to read if a blank line is added between these two lines.	sheenaNg	April 7, 2022, 1:25 p.m.
I think it would be easier to read if a blank line is added between these two lines.	sheenaNg	April 7, 2022, 1:25 p.m.
Same comments here as the docstring for resolve_users.	david	April 4, 2022, 9:58 p.m.
graphql -> GraphQL	david	April 4, 2022, 9:58 p.m.
Please add a docstring.	david	April 4, 2022, 9:58 p.m.
Can you please add a blank line between them?	sheenaNg	April 7, 2022, 1:25 p.m.
This needs a module docstring, and imports should be broken up into three, alphabetically-sorted groups: Standard library (json) 3rd party …	david	April 4, 2022, 9:58 p.m.
E999 SyntaxError: invalid syntax	reviewbot	April 4, 2022, 9:59 p.m.
graphql -> GraphQL	david	April 4, 2022, 9:58 p.m.
This decorator takes any "<URL>" in the docstring and replaces it with the value of sample_api_url. Since we're not listing …	david	April 4, 2022, 9:58 p.m.
I think a blank line is not needed here.	sheenaNg	April 7, 2022, 1:25 p.m.
Don't need this decorator.	david	April 4, 2022, 9:58 p.m.
Since you're using the @webapi_test_template, perhaps do something like """Testing the <URL> API for a specific user and url serialization"""? …	david	April 4, 2022, 9:58 p.m.
Let's rewrap: self.assertEqual( rsp['user']['links'], { 'self': { 'href': '...', 'method': 'GET', }, })	david	April 4, 2022, 9:58 p.m.
I think it would be easier to read if a blank line is added before calling the API endpoint. This …	sheenaNg	April 7, 2022, 1:25 p.m.
I wonder why you did not assign the returned data to the variable "rsp" and check the "stat" and "error" …	sheenaNg	April 7, 2022, 1:26 p.m.
A bunch of the test cases in here don't have docstrings.	david	April 4, 2022, 9:58 p.m.
A blank line is not needed here.	sheenaNg	April 7, 2022, 1:26 p.m.
Again, I wonder why you did not assign the returned data to the variable "rsp" and add assertions to check …	sheenaNg	April 7, 2022, 1:26 p.m.
A blank line is not needed here.	sheenaNg	April 7, 2022, 1:26 p.m.
Can you please add a blank line between these two just to be consistent with the other unit tests?	sheenaNg	April 7, 2022, 1:26 p.m.
A blank line is not needed here.	sheenaNg	April 7, 2022, 1:26 p.m.
A blank line is not needed here.	sheenaNg	April 7, 2022, 1:26 p.m.
A blank line is not needed here.	sheenaNg	April 7, 2022, 1:26 p.m.
Missing docstring that describes the test?	sheenaNg	April 7, 2022, 1:26 p.m.
W291 trailing whitespace	reviewbot	April 4, 2022, 9:59 p.m.
A blank line is not needed here.	sheenaNg	April 7, 2022, 1:26 p.m.
Missing docstring that describes the test.	sheenaNg	April 7, 2022, 1:26 p.m.
Should be "GraphQL"	david	April 4, 2022, 9:58 p.m.
This stuff shouldn't be part of your change. It looks like you (or one of your tools) did a git …	david	April 4, 2022, 9:58 p.m.
E999 SyntaxError: invalid syntax	reviewbot	April 7, 2022, 1:27 p.m.
E999 SyntaxError: invalid syntax	reviewbot	April 7, 2022, 1:27 p.m.
E999 SyntaxError: invalid syntax	reviewbot	April 8, 2022, 3:56 p.m.
E501 line too long (89 > 79 characters)	reviewbot	April 8, 2022, 3:56 p.m.
E999 SyntaxError: invalid syntax	reviewbot	April 8, 2022, 3:56 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 8, 2022, 3:56 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 8, 2022, 3:56 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 8, 2022, 3:56 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 8, 2022, 3:56 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 8, 2022, 3:56 p.m.
E128 continuation line under-indented for visual indent	reviewbot	April 8, 2022, 3:56 p.m.
E999 SyntaxError: invalid syntax	reviewbot	April 8, 2022, 3:57 p.m.
E999 SyntaxError: invalid syntax	reviewbot	April 8, 2022, 3:57 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
E501 line too long (88 > 79 characters)
```
reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
E501 line too long (134 > 79 characters)
```
reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
E501 line too long (91 > 79 characters)
```
reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```

reviewboard/webapi/resources/graphql.py (Diff revision 1)

Show all issues

E305 expected 2 blank lines after class or function definition, found 1

reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
E124 closing bracket does not match visual indentation
```
reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
E222 multiple spaces after operator
```
reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
E222 multiple spaces after operator
```
reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
E501 line too long (100 > 79 characters)
```
reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
E501 line too long (116 > 79 characters)
```
reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
W293 blank line contains whitespace
```

reviewboard/webapi/resources/graphql.py (Diff revision 1)

Show all issues

E305 expected 2 blank lines after class or function definition, found 1

reviewboard/webapi/resources/graphql.py (Diff revision 1)
Show all issues
```
W292 no newline at end of file
```

Change Summary:


implementing a better way to leverage existing WebAPIResource definitions to create graphql schema

Summary:

-	Experimantal GraphQL Endpoint
+	[WIP] Experimantal GraphQL Endpoint

Commits:

	Summary	ID
	Experimantal GraphQL Endpoint	e9f1bae53b13c5fe1781fcf79ede9d35b49ba969
	Experimantal GraphQL Endpoint	190da7a4bbff2a5d1737843a684c1233a9e63941

Diff:

Revision 2 (+284)

Show changes

	reviewboard/webapi/resources/graphql.py
	reviewboard/webapi/resources/root.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
E501 line too long (101 > 79 characters)
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
E221 multiple spaces before operator
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```

reviewboard/webapi/resources/graphql.py (Diff revision 2)

Show all issues

E305 expected 2 blank lines after class or function definition, found 1

reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
E124 closing bracket does not match visual indentation
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
E222 multiple spaces after operator
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
E222 multiple spaces after operator
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
E501 line too long (100 > 79 characters)
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
E501 line too long (116 > 79 characters)
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```

reviewboard/webapi/resources/graphql.py (Diff revision 2)

Show all issues

E305 expected 2 blank lines after class or function definition, found 1

reviewboard/webapi/resources/graphql.py (Diff revision 2)
Show all issues
```
W292 no newline at end of file
```

Commits:

	Summary	ID
	Experimantal GraphQL Endpoint	190da7a4bbff2a5d1737843a684c1233a9e63941
	Experimantal GraphQL Endpoint	4e40484e77b69ac1ff5391b81111f05eea058b45

Diff:

Revision 3 (+390)

Show changes

	reviewboard/webapi/resources/graphql.py
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/tests/test_graphql.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/graphql.py (Diff revision 3)
Show all issues
```
E221 multiple spaces before operator
```
reviewboard/webapi/resources/graphql.py (Diff revision 3)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/resources/graphql.py (Diff revision 3)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 3)
Show all issues
```
W293 blank line contains whitespace
```

reviewboard/webapi/resources/graphql.py (Diff revision 3)

Show all issues

E305 expected 2 blank lines after class or function definition, found 1

reviewboard/webapi/resources/graphql.py (Diff revision 3)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 3)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 3)
Show all issues
```
E124 closing bracket does not match visual indentation
```
reviewboard/webapi/resources/graphql.py (Diff revision 3)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 3)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 3)
Show all issues
```
E501 line too long (100 > 79 characters)
```
reviewboard/webapi/resources/graphql.py (Diff revision 3)
Show all issues
```
E501 line too long (116 > 79 characters)
```
reviewboard/webapi/resources/graphql.py (Diff revision 3)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 3)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 3)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 3)
Show all issues
```
E501 line too long (82 > 79 characters)
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 3)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 3)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 3)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 3)
Show all issues
```
E501 line too long (96 > 79 characters)
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 3)
Show all issues
```
E122 continuation line missing indentation or outdented
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 3)
Show all issues
```
W292 no newline at end of file
```
reviewboard/webapi/tests/urls.py (Diff revision 3)
Show all issues
```
E302 expected 2 blank lines, found 1
```

Commits:

	Summary	ID
	Experimantal GraphQL Endpoint	4e40484e77b69ac1ff5391b81111f05eea058b45
	Experimantal GraphQL Endpoint	f834e918c4ebe05055b7349c21edecceaf6911d1

Diff:

Revision 4 (+570)

Show changes

	reviewboard/webapi/resources/graphql.py
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_graphql.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 31 failures.
```
reviewboard/webapi/resources/graphql.py (Diff revision 4)
Show all issues
```
E999 SyntaxError: invalid syntax
```

reviewboard/webapi/resources/graphql.py (Diff revision 4)

Show all issues

E305 expected 2 blank lines after class or function definition, found 1

reviewboard/webapi/resources/graphql.py (Diff revision 4)
Show all issues
```
E124 closing bracket does not match visual indentation
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E501 line too long (82 > 79 characters)
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E201 whitespace after '{'
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E202 whitespace before '}'
```

reviewboard/webapi/tests/test_graphql.py (Diff revision 4)

Show all issues

E123 closing bracket does not match indentation of opening bracket's line

reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ':'
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E501 line too long (120 > 79 characters)
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E201 whitespace after '{'
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E202 whitespace before '}'
```

reviewboard/webapi/tests/test_graphql.py (Diff revision 4)

Show all issues

E123 closing bracket does not match indentation of opening bracket's line

reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E201 whitespace after '{'
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E202 whitespace before '}'
```

reviewboard/webapi/tests/test_graphql.py (Diff revision 4)

Show all issues

E123 closing bracket does not match indentation of opening bracket's line

reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 4)
Show all issues
```
E127 continuation line over-indented for visual indent
```

Change Summary:


fix flake8 errors

Commits:

	Summary	ID
	Experimantal GraphQL Endpoint	f834e918c4ebe05055b7349c21edecceaf6911d1
	Experimantal GraphQL Endpoint	e108bff9cf59fb1eb6b3cad9398f5cc9078ad431

Diff:

Revision 5 (+580)

Show changes

	reviewboard/webapi/resources/graphql.py
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_graphql.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/graphql.py (Diff revision 5)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 5)
Show all issues
```
E999 SyntaxError: invalid syntax
```

reviewboard/webapi/resources/graphql.py (Diff revision 5)

Show all issues

We'll need to add a dependency for this to reviewboard/dependencies.py

reviewboard/webapi/resources/graphql.py (Diff revision 5)

Show all issues

variable names should always start lower-case. Here and elsewhere.

reviewboard/webapi/resources/graphql.py (Diff revision 5)

Show all issues

For normal strings we prefer single quotes. The only times we use double quotes are docstrings/multiline strings, or if the string itself has a single quote in it.

reviewboard/webapi/resources/graphql.py (Diff revision 5)

Show all issues

type is a builtin. We should use a different name for this.

In python, it's also much more efficient to build a list of strings and then use something like '\n'.join(schema_parts) than to do a bunch of repeated concatenations.

reviewboard/webapi/resources/graphql.py (Diff revision 5)
Show all issues
```
Can be elif type in ('Choice', 'List'):
```

reviewboard/webapi/resources/graphql.py (Diff revision 5)

Show all issues

We should build an array and then use '\n'.join(...) instead of concatenations.

reviewboard/webapi/resources/graphql.py (Diff revision 5)

Show all issues

None of these are actually format strings.

reviewboard/webapi/resources/graphql.py (Diff revision 5)

Show all issues

Using the f-string syntax here is confusing (it's not entirely clear what is schema syntax and what is format syntax. I think it'd be better to use .format syntax in here.

reviewboard/webapi/resources/graphql.py (Diff revision 5)

Show all issues

This seems very inefficient. Is there some built-in pagination structure to py_gql?

Change Summary:


addressing feedback

Commits:

	Summary	ID
	Experimantal GraphQL Endpoint	e108bff9cf59fb1eb6b3cad9398f5cc9078ad431
	Experimantal GraphQL Endpoint	a168dd304ec1e1b0a62e090e342d6cfab58b6891

Diff:

Revision 6 (+606)

Show changes

	reviewboard/dependencies.py
	reviewboard/webapi/resources/graphql.py
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_graphql.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/graphql.py (Diff revision 6)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 6)
Show all issues
```
E999 SyntaxError: invalid syntax
```

Commits:

	Summary	ID
	Experimantal GraphQL Endpoint	a168dd304ec1e1b0a62e090e342d6cfab58b6891
	Experimantal GraphQL Endpoint	898fc97862dbc9651e1c8018d0d367ac8e81969d

Diff:

Revision 7 (+1034)

Show changes

	reviewboard/dependencies.py
	reviewboard/webapi/resources/graphql.py
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_graphql.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/graphql.py (Diff revision 7)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 7)
Show all issues
```
E999 SyntaxError: invalid syntax
```

Commits:

	Summary	ID
	Experimantal GraphQL Endpoint	898fc97862dbc9651e1c8018d0d367ac8e81969d
	Experimantal GraphQL Endpoint	46378a7521ac685e9a4eb32c1988b8adfd787bb5

Diff:

Revision 8 (+1660)

Show changes

	reviewboard/dependencies.py
	reviewboard/webapi/resources/graphql.py
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_graphql.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/graphql.py (Diff revision 8)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/resources/graphql.py (Diff revision 8)
Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/graphql.py (Diff revision 8)
Show all issues
```
E501 line too long (129 > 79 characters)
```
reviewboard/webapi/resources/graphql.py (Diff revision 8)
Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/webapi/resources/graphql.py (Diff revision 8)
Show all issues
```
E501 line too long (82 > 79 characters)
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 8)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 8)
Show all issues
```
E127 continuation line over-indented for visual indent
```

Commits:

	Summary	ID
	Experimantal GraphQL Endpoint	46378a7521ac685e9a4eb32c1988b8adfd787bb5
	Experimantal GraphQL Endpoint	6b5b73f8edb805f90ed680fe53960a2df323b896

Diff:

Revision 9 (+2380)

Show changes

	reviewboard/dependencies.py
	reviewboard/webapi/resources/graphql.py
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_graphql.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/graphql.py (Diff revision 9)
Show all issues
```
E202 whitespace before ')'
```
reviewboard/webapi/resources/graphql.py (Diff revision 9)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/resources/graphql.py (Diff revision 9)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 9)
Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/webapi/resources/graphql.py (Diff revision 9)
Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/webapi/resources/graphql.py (Diff revision 9)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 9)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 9)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/webapi/resources/graphql.py (Diff revision 9)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/resources/graphql.py (Diff revision 9)
Show all issues
```
W291 trailing whitespace
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 9)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 9)
Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 9)
Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 9)
Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 9)
Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 9)
Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 9)
Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 9)
Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 9)
Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 9)
Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 9)
Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 9)
Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 9)
Show all issues
```
E127 continuation line over-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 9)
Show all issues
```
E127 continuation line over-indented for visual indent
```

Commits:

	Summary	ID
	Experimantal GraphQL Endpoint	6b5b73f8edb805f90ed680fe53960a2df323b896
	Experimantal GraphQL Endpoint	48c25be4c8f3d6ffef54bdc444c1b902fdb5d8b6

Diff:

Revision 10 (+2380)

Show changes

	reviewboard/dependencies.py
	reviewboard/webapi/resources/graphql.py
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_graphql.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/graphql.py (Diff revision 10)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 10)
Show all issues
```
E999 SyntaxError: invalid syntax
```

Commits:

	Summary	ID
	Experimantal GraphQL Endpoint	48c25be4c8f3d6ffef54bdc444c1b902fdb5d8b6
	Experimantal GraphQL Endpoint	ac6505249a885ae5b5de69089074592bc677c926

Diff:

Revision 11 (+2764 -26)

Show changes

	setup.py
	docs/manual/webapi/2.0/resources/graphql.rst
	docs/manual/webapi/2.0/resources/index.rst
	reviewboard/dependencies.py
	reviewboard/manage.py
	reviewboard/webapi/resources/graphql.py
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/tests/mimetypes.py
	2 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/graphql.py (Diff revision 11)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 11)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 11)
Show all issues
```
W291 trailing whitespace
```

We're in the home stretch here. I added a bunch of comments which are primarily style things, but if you have to choose where to spend your time, the most important thing is filling out the "Description" field to explain what this does, how it works, and (especially important) what is left to do.

reviewboard/webapi/resources/graphql.py (Diff revision 11)
Show all issues
```
This needs a module docstring.
```

reviewboard/webapi/resources/graphql.py (Diff revision 11)

Show all issues

These should be sorted into two groups:

All "third party" imports (including djblets)
All reviewboard imports.

Please sort them alphabetically within the groups.

reviewboard/webapi/resources/graphql.py (Diff revision 11)

Show all issues

This should be in the imperative mood ("Return" instead of "Returns").

reviewboard/webapi/resources/graphql.py (Diff revision 11)
Show all issues
```
This needs an explanation.
```
reviewboard/webapi/resources/graphql.py (Diff revision 11)
Show all issues
```
Please change "String" to "str"
```
reviewboard/webapi/resources/graphql.py (Diff revision 11)
Show all issues
```
Please add a blank line between these two.
```
reviewboard/webapi/resources/graphql.py (Diff revision 11)
Show all issues
```
Please add a blank line between these two.
```
reviewboard/webapi/resources/graphql.py (Diff revision 11)
Show all issues
```
Returns -> Return
```
reviewboard/webapi/resources/graphql.py (Diff revision 11)
Show all issues
```
This needs an explanation.
```
reviewboard/webapi/resources/graphql.py (Diff revision 11)
Show all issues
```
String -> str
```
reviewboard/webapi/resources/graphql.py (Diff revision 11)
Show all issues
```
Blank line between these two.
```

reviewboard/webapi/resources/graphql.py (Diff revision 11)

Show all issues

This is a little funky. How about we define a schema_fmt and then do schema = schema_fmt.format(...)?

reviewboard/webapi/resources/graphql.py (Diff revision 11)

Show all issues

This wrapping is awkward. How about:
```python

def resolve_users(

    _root,

    ctx,

    _info,

    query_params={

        'page': 0,

        ...

    }):

reviewboard/webapi/resources/graphql.py (Diff revision 11)

Show all issues

Blank line in here. We also need entries for _root and _info, which at least explain why they're unused.

reviewboard/webapi/resources/graphql.py (Diff revision 11)

Show all issues

We can use a list comprehension here:

data = [
    serializer.serialize_object(user, request)
    for user in query
]

reviewboard/webapi/resources/graphql.py (Diff revision 11)

Show all issues

Same comments here as the docstring for resolve_users.

reviewboard/webapi/resources/graphql.py (Diff revision 11)
Show all issues
```
Blank line between these two.
```
reviewboard/webapi/resources/graphql.py (Diff revision 11)
Show all issues
```
Blank line between these two.
```

reviewboard/webapi/resources/graphql.py (Diff revision 11)

Show all issues

Same comments here as the docstring for resolve_users.

reviewboard/webapi/resources/graphql.py (Diff revision 11)

Show all issues

Same comments here as the docstring for resolve_users.

reviewboard/webapi/resources/graphql.py (Diff revision 11)
Show all issues
```
graphql -> GraphQL
```
reviewboard/webapi/resources/graphql.py (Diff revision 11)
Show all issues
```
Please add a docstring.
```

reviewboard/webapi/tests/test_graphql.py (Diff revision 11)

Show all issues

This needs a module docstring, and imports should be broken up into three, alphabetically-sorted groups:

Standard library (json)
3rd party (django, djblets)
Current module (reviewboard)

reviewboard/webapi/tests/test_graphql.py (Diff revision 11)
Show all issues
```
graphql -> GraphQL
```

reviewboard/webapi/tests/test_graphql.py (Diff revision 11)

Show all issues

This decorator takes any "<URL>" in the docstring and replaces it with the value of sample_api_url. Since we're not listing URLs in these test cases, we don't need the decorator.

reviewboard/webapi/tests/test_graphql.py (Diff revision 11)
Show all issues
```
Don't need this decorator.
```

reviewboard/webapi/tests/test_graphql.py (Diff revision 11)

Show all issues

Since you're using the @webapi_test_template, perhaps do something like """Testing the <URL> API for a specific user and url serialization"""? Please go through all the docstrings and either make it use "<URL>" or remove the template decorator.

reviewboard/webapi/tests/test_graphql.py (Diff revision 11)

Show all issues

Let's rewrap:

self.assertEqual(
    rsp['user']['links'],
    {
        'self': {
            'href': '...',
            'method': 'GET',
        },
    })

reviewboard/webapi/tests/test_graphql.py (Diff revision 11)
Show all issues
```
A bunch of the test cases in here don't have docstrings.
```
reviewboard/webapi/tests/urls.py (Diff revision 11)
Show all issues
```
Should be "GraphQL"
```

setup.py (Diff revision 11)

Show all issues

This stuff shouldn't be part of your change. It looks like you (or one of your tools) did a git fetch. Can you rebase onto the latest master so your diff is clean?

Commits:

	Summary	ID
	Experimantal GraphQL Endpoint	ac6505249a885ae5b5de69089074592bc677c926
	Experimantal GraphQL Endpoint	14f6c2abc3b12ce214ff80e013b57ea4ebbffa7c

Diff:

Revision 12 (+2910)

Show changes

	docs/manual/webapi/2.0/resources/graphql.rst
	docs/manual/webapi/2.0/resources/index.rst
	reviewboard/dependencies.py
	reviewboard/webapi/resources/graphql.py
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_graphql.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/graphql.py (Diff revision 12)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 12)
Show all issues
```
E999 SyntaxError: invalid syntax
```

sheenaNg April 4, 2022, 11:33 p.m.

I think you did a good job in creating the experimental GraphQL endpoint for the project! I learned quite a bit about GraphQL looking at your codes and the unit tests :) I just added some minor suggestions regarding the formatting issues to improve the styling consistency.

DR

dronan April 7, 2022, 1:28 p.m.
```
Thanks for the review, Sheena!
```

reviewboard/webapi/resources/graphql.py (Diff revision 11)

Show all issues

I believe that blank line is not needed after function docstring.

reviewboard/webapi/resources/graphql.py (Diff revision 11)

Show all issues

I believe that blank line is not needed after function docstring.

reviewboard/webapi/resources/graphql.py (Diff revision 11)

Show all issues

I think it would be easier to read if a blank line is added between these two lines.

reviewboard/webapi/resources/graphql.py (Diff revision 11)

Show all issues

I think it would be easier to read if a blank line is added between these two lines.

reviewboard/webapi/resources/graphql.py (Diff revision 11)

Show all issues

I think it would be easier to read if a blank line is added between these two lines.

reviewboard/webapi/resources/graphql.py (Diff revision 11)

Show all issues

I think it would be easier to read if a blank line is added between these two lines.

reviewboard/webapi/resources/graphql.py (Diff revision 11)
Show all issues
```
Can you please add a blank line between them?
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 11)
Show all issues
```
I think a blank line is not needed here.
```

reviewboard/webapi/tests/test_graphql.py (Diff revision 11)

Show all issues

I think it would be easier to read if a blank line is added before calling the API endpoint.

This change could be applied to the rest of the unit tests.

reviewboard/webapi/tests/test_graphql.py (Diff revision 11)

Show all issues

I wonder why you did not assign the returned data to the variable "rsp" and check the "stat" and "error" like you did to the other unit tests that you expected errors?

reviewboard/webapi/tests/test_graphql.py (Diff revision 11)
Show all issues
```
A blank line is not needed here.
```

reviewboard/webapi/tests/test_graphql.py (Diff revision 11)

Show all issues

Again, I wonder why you did not assign the returned data to the variable "rsp" and add assertions to check the expected values for this unit test as well as the following few unit tests?

dronan April 7, 2022, 1:28 p.m.

I think I must've just forgotten to go back and and add the assertions on these ones. Nice catch!

reviewboard/webapi/tests/test_graphql.py (Diff revision 11)
Show all issues
```
A blank line is not needed here.
```

reviewboard/webapi/tests/test_graphql.py (Diff revision 11)

Show all issues

Can you please add a blank line between these two just to be consistent with the other unit tests?

reviewboard/webapi/tests/test_graphql.py (Diff revision 11)
Show all issues
```
A blank line is not needed here.
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 11)
Show all issues
```
A blank line is not needed here.
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 11)
Show all issues
```
A blank line is not needed here.
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 11)
Show all issues
```
Missing docstring that describes the test?
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 11)
Show all issues
```
A blank line is not needed here.
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 11)
Show all issues
```
Missing docstring that describes the test.
```

Change Summary:


addressing Sheena's review feedback

Commits:

	Summary	ID
	Experimantal GraphQL Endpoint	14f6c2abc3b12ce214ff80e013b57ea4ebbffa7c
	Experimantal GraphQL Endpoint	0706eca329e2bdfde38dc66f31240d625d517ae4

Diff:

Revision 13 (+2952)

Show changes

	docs/manual/webapi/2.0/resources/graphql.rst
	docs/manual/webapi/2.0/resources/index.rst
	reviewboard/dependencies.py
	reviewboard/webapi/resources/graphql.py
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_graphql.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/graphql.py (Diff revision 13)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 13)
Show all issues
```
E501 line too long (89 > 79 characters)
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 13)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 13)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 13)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 13)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 13)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 13)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 13)
Show all issues
```
E128 continuation line under-indented for visual indent
```

Summary:

-	[WIP] Experimantal GraphQL Endpoint
+	Experimantal GraphQL Endpoint

Description:

~		[WIP] Experimantal GraphQL Endpoint
	~	Add an experimental GraphQL API endpoint.
	+
	+	This change introduces a new endpoint at `/graphql`, which handles GraphQL requests. The endpoint accepts POST requests with the body containing a valid GraphQL query. The schema for the API is generated by functions that map existing `WebAPIResource`'s into GraphQL types. This change also includes the query resolvers, which are called by the `py-gql` function `graphql_blocking`, that query, filter, and return data from the database. Currently, only the `User` and `ReviewRequest` objects have been defined in the schema and have resolvers.
	+
	+	The filtering logic in `resolve_review_requests` uses essentially the same logic as the filtering in the `review_request` resource, with some slight changes due to the difference in GrapgQL schema and REST query parameters. Ideally, this code would be refactored and DRY'ed out. Additionally, when building the schema we may eventually want to define the `ResourceList` and `Resource` types as a nested type, to take full advantage of the technology. For now, these are typed as objects with `href`, `method`, and `title` as they currently are in the other API resources.

Testing Done:

	+	Added unit tests for `GraphQLResource` and the `User`, `Users`, `ReviewRequest`, and `ReviewRequests` resolvers.
	+	Ran all `reviewboard` tests.

Commits:

	Summary	ID
	Experimantal GraphQL Endpoint	0706eca329e2bdfde38dc66f31240d625d517ae4
	Experimantal GraphQL Endpoint	40a838e2c8bca9927c3aceeb8b0025031ca0f4e2

Depends On:

+	12228 - WebAPIError and APIQueryUtilsMixin for GraphQL API endpoint

Diff:

Revision 14 (+2980)

Show changes

	docs/manual/webapi/2.0/resources/graphql.rst
	docs/manual/webapi/2.0/resources/index.rst
	reviewboard/dependencies.py
	reviewboard/webapi/resources/graphql.py
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/tests/mimetypes.py
	reviewboard/webapi/tests/test_graphql.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/graphql.py (Diff revision 14)
Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_graphql.py (Diff revision 14)
Show all issues
```
E999 SyntaxError: invalid syntax
```