Summary:

Switch a use of inspect.getargspec to func_accepts_kwargs

Review Request #12030 — Created Feb. 3, 2022 and discarded Feb. 8, 2022, 10:20 p.m.

Information
Owner:	david
Repository:	Review Board
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

We had a place that was using the old getargspec method just to
determine if a method accepted **kwargs. Django has a helper for just
this purpose, so we should switch to it.

Testing Done

Ran unit tests.

Commits

Summary
	Switch a use of inspect.getargspec to func_accepts_kwargs

Screenshots

Issues

Description	From	Last Updated
This already exists upstream. Commit 51fd5145363021b35873151bceb67e65911e6f8a.	chipx86	Feb. 8, 2022, 5:08 p.m.

flake8 passed.

JSHint passed.

Expand All
Collapse All

Fix it!

Show all issues

This already exists upstream.

Commit 51fd5145363021b35873151bceb67e65911e6f8a.

david Feb. 8, 2022, 10:20 p.m.

Yep, I discovered that as I was rebasing onto release-5.0.x. Will close this out.

Review Board 6.0 beta 2 (dev)

Switch a use of inspect.getargspec to func_accepts_kwargs

Status: Discarded