Fixed the signature in the email sent when the review request is closed by admin

 






 

 


  Review Request #12029
  —
  Created Feb. 3, 2022 and discarded  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  sheenaNg
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Currently, when users with admin rights close the review request, 

the email template shows the wrong name in the signature at the 

bottom of the e-mail content.


This change involves replacing the review_request.submitter 

with user to display the name of the admin / user that 

closed the review request instead of the owner of the 

review request.

 








  


 
 

  
Added unit test to test_sending_email.py 


I have also included the screenshots that show the changes: 


    

  1. 

    This screenshot shows the TXT e-mail that is created when 
    
I re-opened the review request and published it. My name is 
    
in the signature of the e-email.
    

    2. 

  2. 

    This screenshot shows the TXT e-mail that is created when 
    
a user with admin rights closed the review request (discarded). 
    
The name of the user with admin rights (superUser Admin) is 
    
in the signature of the e-mail.
    

    3. 


 







 









 





  








 




 







   

    
    
Changes between revision 3 and 4



    

 

 

 

 
orig
1
2
3
4
5

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    
Fixed the signature in the email sent when the review request is closed by admin

   
  		
  7ccae188fe806fc26f29885f5edc2f085926f782
  sng06
 


 
  
 
 
  
   
    
Changed the review_request.submitter variable to user

   
  		
  e9691727a6dfeccbde6dcd8e806737f7851ca2c9
  sng06
 


 
  
 
 
  
   
    
Reverted changes in html file and changed the signature variable to user

   
  		
  a3ee42c2d58bc73f0132c6214e48d499965b0f34
  sng06
 


 
  
 
 
  
   
    
Fixed the signature in the email sent when the review request is closed by admin

   
  		
  62e9427cc4bd71357e8aac03bad7aa1e4bd866c9
  sng06
 


 
  
 
 
  
   
    
Changed the review_request.submitter variable to user

   
  		
  87cc93be33759e98125ddd9e17be290f9acf87f3
  sng06
 


 
  
 
 
  
   
    
Reverted changes in html file and changed the signature variable to user

   
  		
  90c8a70195d1536172ff9c6cdd7b5cf34c1e97be
  sng06
 


 
  
 
 
  
   
    
Reverted changes in html template as we want to preserve the author in the By...

   
  		
  d14924e1acb54edafefcb5f579de1f9bb7bc6565
  sng06
 


 
  
 
 
  
   
    
Added unit test to test changes of close email after fixing the signature

   
  		
  0263c2d9973b9306f31200a8c26ce41c865b17fd
  sng06
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/notifications/tests/test_email_sending.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/templates/notifications/review_request_email.html
     
    

   
  

 










     

    

   

  

  

   
   Loading...