Fixed the signature in the email sent when the review request is closed by admin
Review Request #12029 — Created Feb. 3, 2022 and updated
Information | |
---|---|
sheenaNg | |
Review Board | |
release-4.0.x | |
Reviewers | |
reviewboard | |
Currently, when users with admin rights close the review request,
the email template shows the wrong name in the signature at the
bottom of the e-mail content.This change involves replacing the
review_request.submitter
withuser
to display the name of the admin / user that
closed the review request instead of the owner of the
review request.
Added unit test to
test_sending_email.py
I have also included the screenshots that show the changes:
This screenshot shows the
TXT
e-mail that is created when
I re-opened the review request and published it. My name is
in the signature of the e-email.This screenshot shows the
TXT
e-mail that is created when
a user with admin rights closed the review request (discarded).
The name of the user with admin rights (superUser Admin) is
in the signature of the e-mail.
Summary | Author |
---|---|
sng06 | |
sng06 | |
sng06 | |
sng06 | |
sng06 | |
sng06 |
Description | From | Last Updated |
---|---|---|
I know some of the other things in here say "Tests", but all test docstrings should start with "Testing" |
|
|
May be a minor thing, but you can shorten this, by including publish=True inside the self.create_review_request function. |
|
|
These can be self.assertIn('...', message.as_string()), which I think will give us better debug output if they fail. |
|
Change Summary:
Added issues to get further clarification
Description: |
|
||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
||||||||||||||||||||||||
Added Files: |
Commits: |
|
||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+288 -262) |
Checks run (2 succeeded)
Change Summary:
Reverted changes in the html file, disabled VScode auto-formatting, changed the variable and fixed the error
Description: |
|
|||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
|||||||||||||||||||||||||||
Commits: |
|
|||||||||||||||||||||||||||
Diff: |
Revision 3 (+276 -276) |
|||||||||||||||||||||||||||
Removed Files: |
||||||||||||||||||||||||||||
Added Files: |
Checks run (2 succeeded)
Description: |
|
||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
||||||||||||||||||||||||||||||||||||
Commits: |
|
||||||||||||||||||||||||||||||||||||
Diff: |
Revision 4 (+340 -276) |
||||||||||||||||||||||||||||||||||||
Removed Files: |
Checks run (2 succeeded)
-
-
reviewboard/notifications/tests/test_email_sending.py (Diff revision 4) May be a minor thing, but you can shorten this, by including
publish=True
inside theself.create_review_request
function.
-
-
reviewboard/notifications/tests/test_email_sending.py (Diff revision 4) I know some of the other things in here say "Tests", but all test docstrings should start with "Testing"
-
reviewboard/notifications/tests/test_email_sending.py (Diff revision 4) These can be
self.assertIn('...', message.as_string())
, which I think will give us better debug output if they fail.
Change Summary:
Made changes to codes based on code review feedback
Commits: |
|
||||||||||||||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 5 (+345 -283) |