This change has been discarded.

Describe the reason it's discarded (optional):

This work has moved to /r/12297

Summary

Top Level Reviews API Endpoint

*

Review Request #12028 — Created Feb. 3, 2022 and discarded 3 years ago — Latest diff uploaded 3 years, 2 months ago

Information

Owner

TaylorChristie*

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

People

Description*


Added top level reviews endpoint.
Ability to filter by username using ?user=username parameter.
Ability to filter by repository name using ?repository=repoName parameter.
Ability to filter by date range using ?last-updated-from and ?last-updated-to parameters.
Ability to filter by review group using ?review-group=group_name parameter.
Added tests for the new root_reviews resource.
Added documentation for top level reviews endpoint.

Testing Done


Wrote unit tests for all new functionality
Ran unit tests for root_reviews resource and ensure they pass
Tested new API endpoint manually and confirmed results were as expected.

Diff Revision 6

This is not the most recent revision of the diff. The latest diff is revision 11. See what's changed.

orig

1

2

3

4

5

6

7

8

9

10

11

Commits

First	Last	Summary	ID	Author
		attempted adding root_review	4a98ef5189063d4f605a70f87cd78c696ead9e5d	Taylor Christie
		got endpoint working (rudementarily), added some basic tests	206769261bfca454dc42dca506e10bb67bb6f20f	Taylor Christie
		get tests working	62f5caf5437416438fe386d3169a3d2c95de44c7	Taylor Christie
		Added user filtering by username. Added repository filtering by repository na...	64e37475a38cd7180e70065a0b85c0557b7726bd	Taylor Christie
		added date filtering, added review group filtering, added blank unit tests	ef5f0394cfbcf904b9ecffee4c01530494e1db62	Taylor Christie
		removed unneeded imports	d01ead0c5789f6f273dde85ffc40820b514e2f1f	Taylor Christie
		added unit tests for last-updated-from and laste-updated-to parameters and ad...	46ef7bf956bd684356ad088143acc16ca8d53ca7	Taylor Christie
		finished review-group parameter, unit tests, and flake8 formatting	a82f040f7ad92cc37ac053662d0d7380c8d551b7	Taylor Christie
		added documentation	55c5247da821df4fb376238c31ac7a6a8f806f32	Taylor Christie

Files

	reviewboard/accounts/evolutions/profile_settings.py
	reviewboard/accounts/evolutions/profile_should_send_email.py
	reviewboard/accounts/evolutions/profile_should_send_own_updates.py
	reviewboard/accounts/evolutions/reviewrequestvisit_visibility.py
	reviewboard/accounts/evolutions/timezone.py
	reviewboard/accounts/evolutions/timezone_length_30.py
	reviewboard/accounts/forms/auth.py
	reviewboard/accounts/forms/pages.py
	reviewboard/accounts/forms/registration.py
	reviewboard/accounts/templatetags/accounts.py
	reviewboard/accounts/tests/test_account_page.py
	reviewboard/accounts/tests/test_account_settings_form.py
	reviewboard/accounts/tests/test_ad_auth_backend.py
	reviewboard/accounts/tests/test_base_auth_backend.py
	reviewboard/accounts/tests/test_change_password_form.py
	reviewboard/accounts/tests/test_check_login_required_view_mixin.py
	reviewboard/accounts/tests/test_edit_oauth_app_view.py
	reviewboard/accounts/tests/test_ldap_auth_backend.py
	reviewboard/accounts/tests/test_login_required_view_mixin.py
	reviewboard/accounts/tests/test_my_account_view.py

This diff has been split across 40 pages: < 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 >

reviewboard/accounts/evolutions/profile_settings.py

reviewboard/accounts/evolutions/profile_should_send_email.py

reviewboard/accounts/evolutions/profile_should_send_own_updates.py

reviewboard/accounts/evolutions/reviewrequestvisit_visibility.py

reviewboard/accounts/evolutions/timezone.py

reviewboard/accounts/evolutions/timezone_length_30.py

reviewboard/accounts/forms/auth.py

reviewboard/accounts/forms/pages.py

reviewboard/accounts/forms/registration.py

reviewboard/accounts/templatetags/accounts.py

reviewboard/accounts/tests/test_account_page.py

reviewboard/accounts/tests/test_account_settings_form.py

reviewboard/accounts/tests/test_ad_auth_backend.py

reviewboard/accounts/tests/test_base_auth_backend.py

reviewboard/accounts/tests/test_change_password_form.py

reviewboard/accounts/tests/test_check_login_required_view_mixin.py

reviewboard/accounts/tests/test_edit_oauth_app_view.py

reviewboard/accounts/tests/test_ldap_auth_backend.py

reviewboard/accounts/tests/test_login_required_view_mixin.py

reviewboard/accounts/tests/test_my_account_view.py

This diff has been split across 40 pages: < 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 >

Loading...