Summary

Top Level Reviews API Endpoint

Review Request #12028 — Created Feb. 3, 2022 and discarded June 3, 2022, 10:18 a.m.

Information

Owner

TaylorChristie

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description


Added top level reviews endpoint.
Ability to filter by username using ?user=username parameter.
Ability to filter by repository name using ?repository=repoName parameter.
Ability to filter by date range using ?last-updated-from and ?last-updated-to parameters.
Ability to filter by review group using ?review-group=group_name parameter.
Added tests for the new root_reviews resource.
Added documentation for top level reviews endpoint.

Testing Done


Wrote unit tests for all new functionality
Ran unit tests for root_reviews resource and ensure they pass
Tested new API endpoint manually and confirmed results were as expected.

Commits

Summary	ID
attempted adding root_review	ec03d8deeb71d5a57b81acdc543a4e957b9cda98
got endpoint working (rudementarily), added some basic tests	1cc3bc3ff5e466b8a100801946320fc110ba3261
get tests working	3de9b81399c00e0ba216cfeb369ab6a9d508bbf4
Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	9a18d8d58df4645b6ffea30ba1011058bf3d944c
added date filtering, added review group filtering, added blank unit tests	02a7ebed1a9622585df30c63e04d4529bc22873e
removed unneeded imports	1c91b9b3233a47860d390f5edb55e3f3411fed78
added unit tests for last-updated-from and laste-updated-to parameters and addressed some patch feedback	4a167d944a0c5b6d31891ceec2df29d5d9e3936d
finished review-group parameter, unit tests, and flake8 formatting	c628f9f7d225b38d7f977dcf231b5c9cfeb4908c
added documentation	792e6a22a36639861060a11ad0ed484900112071
finished up root review documentation and ensure it generates correctly	7b8db5e8d21439436caf0fc04e506a7196d52d68
feedback from chaoyu	c56e7745cc1782bfbcc4cc5954b87a2e66059444
addressed feedback from David	27fa75dc9644639e7392f8cc1c34cbf82c09c77f
addressed feedback from David and Sheena.	cacca7efd27207c02b718e271275dbe66416c69e

Issues

Description	From	Last Updated
F401 'django.utils.six' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'djblets.util.decorators.augment_method_from' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'djblets.webapi.decorators.webapi_response_errors' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'djblets.webapi.errors.INVALID_FORM_DATA' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'reviewboard.reviews.errors.RevokeShipItError' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'reviewboard.webapi.decorators.webapi_check_local_site' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'reviewboard.webapi.errors.REVOKE_SHIP_IT_ERROR' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'datetime.datetime' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'datetime.timedelta' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'django.core.mail' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'django.utils.timezone' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'djblets.util.dates.get_tz_aware_utcnow' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'djblets.testing.decorators.add_fixtures' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'djblets.webapi.errors.PERMISSION_DENIED' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'djblets.webapi.errors.INVALID_FORM_DATA' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'djblets.webapi.errors.DOES_NOT_EXIST' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'djblets.webapi.testing.decorators.webapi_test_template' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'kgb.SpyAgency' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'kgb.spy_on' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'reviewboard.reviews.models.Review' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'reviewboard.reviews.models.ReviewRequest' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'reviewboard.reviews.signals.review_ship_it_revoking' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'reviewboard.webapi.errors.REVOKE_SHIP_IT_ERROR' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'reviewboard.webapi.tests.mimetypes.review_item_mimetype' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'reviewboard.webapi.tests.mixins.ReviewRequestChildItemMixin' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'reviewboard.webapi.tests.mixins.ReviewRequestChildListMixin' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'reviewboard.webapi.tests.mixins.BasicTestsMetaclass' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'reviewboard.webapi.tests.mixins_review.ReviewItemMixin' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'reviewboard.webapi.tests.mixins_review.ReviewListMixin' imported but unused	reviewbot	Feb. 10, 2022, 4:37 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Feb. 10, 2022, 4:37 p.m.
F401 'django.utils.six' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'djblets.util.decorators.augment_method_from' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'djblets.webapi.decorators.webapi_response_errors' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'djblets.webapi.errors.INVALID_FORM_DATA' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'reviewboard.reviews.errors.RevokeShipItError' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'reviewboard.webapi.decorators.webapi_check_local_site' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'reviewboard.webapi.errors.REVOKE_SHIP_IT_ERROR' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'datetime.datetime' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'datetime.timedelta' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'django.core.mail' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'django.utils.timezone' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'djblets.util.dates.get_tz_aware_utcnow' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'djblets.webapi.errors.PERMISSION_DENIED' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'djblets.webapi.errors.INVALID_FORM_DATA' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'djblets.webapi.errors.DOES_NOT_EXIST' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'djblets.webapi.testing.decorators.webapi_test_template' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'kgb.SpyAgency' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'kgb.spy_on' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'reviewboard.reviews.models.Review' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'reviewboard.reviews.models.ReviewRequest' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'reviewboard.reviews.signals.review_ship_it_revoking' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'reviewboard.webapi.errors.REVOKE_SHIP_IT_ERROR' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'reviewboard.webapi.tests.mimetypes.review_item_mimetype' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'reviewboard.webapi.tests.mixins.ReviewRequestChildItemMixin' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'reviewboard.webapi.tests.mixins.ReviewRequestChildListMixin' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'reviewboard.webapi.tests.mixins.BasicTestsMetaclass' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'reviewboard.webapi.tests.mixins_review.ReviewItemMixin' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
F401 'reviewboard.webapi.tests.mixins_review.ReviewListMixin' imported but unused	reviewbot	Feb. 16, 2022, 8:17 a.m.
E501 line too long (80 > 79 characters)	reviewbot	Feb. 16, 2022, 8:17 a.m.
E501 line too long (95 > 79 characters)	reviewbot	Feb. 16, 2022, 8:17 a.m.
On the master branch, we no longer need the unicode_literals imports.	david	March 4, 2022, 9:13 a.m.
This was just copied from the other review resource, but should probably be clarified since this one is not a …	david	March 4, 2022, 9:13 a.m.
E501 line too long (84 > 79 characters)	reviewbot	March 4, 2022, 9:13 a.m.
E501 line too long (80 > 79 characters)	reviewbot	March 4, 2022, 9:13 a.m.
E501 line too long (95 > 79 characters)	reviewbot	March 4, 2022, 9:13 a.m.
E501 line too long (90 > 79 characters)	reviewbot	March 4, 2022, 9:13 a.m.
E501 line too long (82 > 79 characters)	reviewbot	March 4, 2022, 9:13 a.m.
E501 line too long (83 > 79 characters)	reviewbot	March 4, 2022, 9:13 a.m.
E501 line too long (95 > 79 characters)	reviewbot	March 4, 2022, 9:13 a.m.
E501 line too long (96 > 79 characters)	reviewbot	March 4, 2022, 9:13 a.m.
E501 line too long (94 > 79 characters)	reviewbot	March 4, 2022, 9:13 a.m.
E501 line too long (93 > 79 characters)	reviewbot	March 4, 2022, 9:13 a.m.
E501 line too long (91 > 79 characters)	reviewbot	March 4, 2022, 9:13 a.m.
E501 line too long (82 > 79 characters)	reviewbot	March 4, 2022, 9:13 a.m.
E501 line too long (95 > 79 characters)	reviewbot	March 4, 2022, 9:13 a.m.
E501 line too long (86 > 79 characters)	reviewbot	March 4, 2022, 9:13 a.m.
E501 line too long (89 > 79 characters)	reviewbot	March 7, 2022, 11:28 p.m.
E501 line too long (84 > 79 characters)	reviewbot	March 7, 2022, 11:28 p.m.
E501 line too long (80 > 79 characters)	reviewbot	March 7, 2022, 11:28 p.m.
E501 line too long (95 > 79 characters)	reviewbot	March 7, 2022, 11:28 p.m.
E501 line too long (90 > 79 characters)	reviewbot	March 7, 2022, 11:28 p.m.
E501 line too long (82 > 79 characters)	reviewbot	March 7, 2022, 11:28 p.m.
E501 line too long (83 > 79 characters)	reviewbot	March 7, 2022, 11:28 p.m.
E501 line too long (95 > 79 characters)	reviewbot	March 7, 2022, 11:28 p.m.
E501 line too long (96 > 79 characters)	reviewbot	March 7, 2022, 11:28 p.m.
E501 line too long (94 > 79 characters)	reviewbot	March 7, 2022, 11:28 p.m.
E501 line too long (109 > 79 characters)	reviewbot	March 7, 2022, 11:28 p.m.
E501 line too long (121 > 79 characters)	reviewbot	March 7, 2022, 11:28 p.m.
E501 line too long (117 > 79 characters)	reviewbot	March 7, 2022, 11:28 p.m.
E501 line too long (82 > 79 characters)	reviewbot	March 7, 2022, 11:28 p.m.
E501 line too long (139 > 79 characters)	reviewbot	March 7, 2022, 11:28 p.m.
E501 line too long (84 > 79 characters)	reviewbot	March 7, 2022, 11:28 p.m.
F401 'importlib' imported but unused	reviewbot	March 17, 2022, 7:39 a.m.
F401 'django.utils.six' imported but unused	reviewbot	March 17, 2022, 7:39 a.m.
Please add a module docstring at the top of this file. Something like """Root-level resource for querying reviews."""	david	April 4, 2022, 1:09 p.m.
Imports from reviewboard should be in a separate group after third-party packages. So: from django... from djblets... from reviewboard... Everything …	david	April 4, 2022, 1:10 p.m.
This can be wrapped much later. Line width is 79 columns.	david	April 4, 2022, 1:10 p.m.
I know you probably copied this from our other code, but this should use our new docstring standards: https://www.notion.so/reviewboard/Writing-Python-Docs-845c696271194d85b69503246db1d0e6	david	April 4, 2022, 1:11 p.m.
Looks great! Only one suggestion here, once speficied in webapi_request_fields, we can get parsed parameters in kwargds. Using kwargds['drafts'] here …	Chaoyu	April 1, 2022, 5:54 p.m.
This needs a docstring.	david	April 4, 2022, 1:11 p.m.
Please update for new docstring standards.	david	April 4, 2022, 1:11 p.m.
This file needs a module docstring.	david	April 4, 2022, 1:12 p.m.
Please sort alphabetically - t before u	david	April 4, 2022, 1:12 p.m.
This needs a blank line between these two.	david	April 4, 2022, 1:12 p.m.
Please add a docstring.	david	April 4, 2022, 1:13 p.m.
When we wrap a single-line docstring, please put the final """ on its own line: def test_get_with_counts_only(self): """Testing the GET …	david	April 4, 2022, 1:15 p.m.
""" on its own line.	david	April 4, 2022, 1:15 p.m.
""" on its own line. Please go through the rest of this file and change where appropriate.	david	April 4, 2022, 1:15 p.m.
webapi.decorators before webapi.fields	david	April 5, 2022, 11:33 a.m.
This should be in the imperative mood ("Return" instead of "Returns")	david	April 5, 2022, 11:33 a.m.
This line can dedent 4 spaces.	david	April 5, 2022, 11:33 a.m.
Returns -> Return	david	April 5, 2022, 11:35 a.m.
Returns -> Return	david	April 5, 2022, 11:35 a.m.
Instead of listing "reviews/" in each docstring, let's use "<URL>/" and add on the @webapi_test_template decorator.	david	April 5, 2022, 11:40 a.m.
I think everything looks good overall. I just have a small suggestion to improve the unit tests readability: I think …	sheenaNg	April 5, 2022, 11:42 a.m.
The review_request api endpoint filters by the ID of the repository instead of the name. Should we filter by ID …	maubin	May 23, 2022, 10:22 p.m.
I'm going to specify that this is the "review group name of users" rather than "the group of users"	maubin	May 23, 2022, 10:22 p.m.
It might be worthwhile to add fields for "time-added-to" and "time-added-from" just so that there's more options for date filtering. …	maubin	May 23, 2022, 10:22 p.m.

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 33 failures.
```
reviewboard/webapi/resources/root_review.py (Diff revision 1)
Show all issues
```
F401 'django.utils.six' imported but unused
```

reviewboard/webapi/resources/root_review.py (Diff revision 1)

Show all issues

F401 'djblets.util.decorators.augment_method_from' imported but unused

reviewboard/webapi/resources/root_review.py (Diff revision 1)

Show all issues

F401 'djblets.webapi.decorators.webapi_response_errors' imported but unused

reviewboard/webapi/resources/root_review.py (Diff revision 1)
Show all issues
```
F401 'djblets.webapi.errors.INVALID_FORM_DATA' imported but unused
```

reviewboard/webapi/resources/root_review.py (Diff revision 1)

Show all issues

F401 'reviewboard.reviews.errors.RevokeShipItError' imported but unused

reviewboard/webapi/resources/root_review.py (Diff revision 1)

Show all issues

F401 'reviewboard.webapi.decorators.webapi_check_local_site' imported but unused

reviewboard/webapi/resources/root_review.py (Diff revision 1)

Show all issues

F401 'reviewboard.webapi.errors.REVOKE_SHIP_IT_ERROR' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 1)
Show all issues
```
F401 'datetime.datetime' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 1)
Show all issues
```
F401 'datetime.timedelta' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 1)
Show all issues
```
F401 'django.core.mail' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 1)
Show all issues
```
F401 'django.utils.timezone' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 1)
Show all issues
```
F401 'djblets.util.dates.get_tz_aware_utcnow' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 1)
Show all issues
```
F401 'djblets.testing.decorators.add_fixtures' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 1)
Show all issues
```
F401 'djblets.webapi.errors.PERMISSION_DENIED' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 1)
Show all issues
```
F401 'djblets.webapi.errors.INVALID_FORM_DATA' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 1)
Show all issues
```
F401 'djblets.webapi.errors.DOES_NOT_EXIST' imported but unused
```

reviewboard/webapi/tests/test_root_review.py (Diff revision 1)

Show all issues

F401 'djblets.webapi.testing.decorators.webapi_test_template' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 1)
Show all issues
```
F401 'kgb.SpyAgency' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 1)
Show all issues
```
F401 'kgb.spy_on' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 1)
Show all issues
```
F401 'reviewboard.reviews.models.Review' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 1)
Show all issues
```
F401 'reviewboard.reviews.models.ReviewRequest' imported but unused
```

reviewboard/webapi/tests/test_root_review.py (Diff revision 1)

Show all issues

F401 'reviewboard.reviews.signals.review_ship_it_revoking' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 1)

Show all issues

F401 'reviewboard.webapi.errors.REVOKE_SHIP_IT_ERROR' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 1)

Show all issues

F401 'reviewboard.webapi.tests.mimetypes.review_item_mimetype' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 1)

Show all issues

F401 'reviewboard.webapi.tests.mixins.ReviewRequestChildItemMixin' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 1)

Show all issues

F401 'reviewboard.webapi.tests.mixins.ReviewRequestChildListMixin' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 1)

Show all issues

F401 'reviewboard.webapi.tests.mixins.BasicTestsMetaclass' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 1)

Show all issues

F401 'reviewboard.webapi.tests.mixins_review.ReviewItemMixin' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 1)

Show all issues

F401 'reviewboard.webapi.tests.mixins_review.ReviewListMixin' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 1)
Show all issues
```
E501 line too long (80 > 79 characters)
```

Description:

		Added rudimentary top level reviews endpoint.
~		Added some basic tests for the new `root_reviews` resource.
~		Still missing a lot of basic functionality, documentation, and tests
	~	Ability to filter by username using ?user=username parameter
	~	Ability to filter by repository name using ?repository=repoName parameter
	+	Added some basic tests for the new `root_reviews` resource.
	+	Still missing date range filtering, review group filtering, documentation, some unit tests

Testing Done:

~		Ran unit tests for `root_reviews` resource.
~		Tested API new endpoint and confirmed results were as expected.
	~	Wrote unit tests for all new functionality
	~	Ran unit tests for `root_reviews` resource and ensure they pass
	+	Tested new API endpoint manually and confirmed results were as expected.

Commits:

	Summary	ID
	attempted adding root_review	4a98ef5189063d4f605a70f87cd78c696ead9e5d
	got endpoint working (rudementarily), added some basic tests	206769261bfca454dc42dca506e10bb67bb6f20f
	get tests working	62f5caf5437416438fe386d3169a3d2c95de44c7
	attempted adding root_review	4a98ef5189063d4f605a70f87cd78c696ead9e5d
	got endpoint working (rudementarily), added some basic tests	206769261bfca454dc42dca506e10bb67bb6f20f
	get tests working	62f5caf5437416438fe386d3169a3d2c95de44c7
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	64e37475a38cd7180e70065a0b85c0557b7726bd

Diff:

Revision 2 (+571 -61)

Show changes

	reviewboard/webapi/resources/root.py
	reviewboard/webapi/resources/root_review.py
	reviewboard/webapi/tests/test_root_review.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 37 failures.
```
reviewboard/webapi/resources/root_review.py (Diff revision 2)
Show all issues
```
F401 'django.utils.six' imported but unused
```

reviewboard/webapi/resources/root_review.py (Diff revision 2)

Show all issues

F401 'djblets.util.decorators.augment_method_from' imported but unused

reviewboard/webapi/resources/root_review.py (Diff revision 2)

Show all issues

F401 'djblets.webapi.decorators.webapi_response_errors' imported but unused

reviewboard/webapi/resources/root_review.py (Diff revision 2)
Show all issues
```
F401 'djblets.webapi.errors.INVALID_FORM_DATA' imported but unused
```

reviewboard/webapi/resources/root_review.py (Diff revision 2)

Show all issues

F401 'reviewboard.reviews.errors.RevokeShipItError' imported but unused

reviewboard/webapi/resources/root_review.py (Diff revision 2)

Show all issues

F401 'reviewboard.webapi.decorators.webapi_check_local_site' imported but unused

reviewboard/webapi/resources/root_review.py (Diff revision 2)

Show all issues

F401 'reviewboard.webapi.errors.REVOKE_SHIP_IT_ERROR' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 2)
Show all issues
```
F401 'datetime.datetime' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 2)
Show all issues
```
F401 'datetime.timedelta' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 2)
Show all issues
```
F401 'django.core.mail' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 2)
Show all issues
```
F401 'django.utils.timezone' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 2)
Show all issues
```
F401 'djblets.util.dates.get_tz_aware_utcnow' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 2)
Show all issues
```
F401 'djblets.webapi.errors.PERMISSION_DENIED' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 2)
Show all issues
```
F401 'djblets.webapi.errors.INVALID_FORM_DATA' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 2)
Show all issues
```
F401 'djblets.webapi.errors.DOES_NOT_EXIST' imported but unused
```

reviewboard/webapi/tests/test_root_review.py (Diff revision 2)

Show all issues

F401 'djblets.webapi.testing.decorators.webapi_test_template' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 2)
Show all issues
```
F401 'kgb.SpyAgency' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 2)
Show all issues
```
F401 'kgb.spy_on' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 2)
Show all issues
```
F401 'reviewboard.reviews.models.Review' imported but unused
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 2)
Show all issues
```
F401 'reviewboard.reviews.models.ReviewRequest' imported but unused
```

reviewboard/webapi/tests/test_root_review.py (Diff revision 2)

Show all issues

F401 'reviewboard.reviews.signals.review_ship_it_revoking' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 2)

Show all issues

F401 'reviewboard.webapi.errors.REVOKE_SHIP_IT_ERROR' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 2)

Show all issues

F401 'reviewboard.webapi.tests.mimetypes.review_item_mimetype' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 2)

Show all issues

F401 'reviewboard.webapi.tests.mixins.ReviewRequestChildItemMixin' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 2)

Show all issues

F401 'reviewboard.webapi.tests.mixins.ReviewRequestChildListMixin' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 2)

Show all issues

F401 'reviewboard.webapi.tests.mixins.BasicTestsMetaclass' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 2)

Show all issues

F401 'reviewboard.webapi.tests.mixins_review.ReviewItemMixin' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 2)

Show all issues

F401 'reviewboard.webapi.tests.mixins_review.ReviewListMixin' imported but unused

reviewboard/webapi/tests/test_root_review.py (Diff revision 2)
Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 2)
Show all issues
```
E501 line too long (95 > 79 characters)
```

Description:

		Added rudimentary top level reviews endpoint.
		Ability to filter by username using ?user=username parameter
		Ability to filter by repository name using ?repository=repoName parameter
~		Added some basic tests for the new `root_reviews` resource.
~		Still missing date range filtering, review group filtering, documentation, some unit tests
	~	Ability to filter by date range using ?last-updated-from and ?last-updated-to
	~	Ability to filter by review group using ?review-group=group_name
	+	Added some basic tests for the new `root_reviews` resource.
	+	Still missing documentation, some unit tests

Commits:

	Summary	ID
	attempted adding root_review	4a98ef5189063d4f605a70f87cd78c696ead9e5d
	got endpoint working (rudementarily), added some basic tests	206769261bfca454dc42dca506e10bb67bb6f20f
	get tests working	62f5caf5437416438fe386d3169a3d2c95de44c7
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	64e37475a38cd7180e70065a0b85c0557b7726bd
	attempted adding root_review	4a98ef5189063d4f605a70f87cd78c696ead9e5d
	got endpoint working (rudementarily), added some basic tests	206769261bfca454dc42dca506e10bb67bb6f20f
	get tests working	62f5caf5437416438fe386d3169a3d2c95de44c7
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	64e37475a38cd7180e70065a0b85c0557b7726bd
	added date filtering, added review group filtering, added blank unit tests	ef5f0394cfbcf904b9ecffee4c01530494e1db62
	removed unneeded imports	d01ead0c5789f6f273dde85ffc40820b514e2f1f

Diff:

Revision 3 (+625 -113)

Show changes

	reviewboard/webapi/resources/root.py
	reviewboard/webapi/resources/root_review.py
	reviewboard/webapi/tests/test_root_review.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/root_review.py (Diff revision 3)
Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 3)
Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 3)
Show all issues
```
E501 line too long (95 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 3)
Show all issues
```
E501 line too long (90 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 3)
Show all issues
```
E501 line too long (82 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 3)
Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 3)
Show all issues
```
E501 line too long (95 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 3)
Show all issues
```
E501 line too long (96 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 3)
Show all issues
```
E501 line too long (94 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 3)
Show all issues
```
E501 line too long (93 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 3)
Show all issues
```
E501 line too long (91 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 3)
Show all issues
```
E501 line too long (82 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 3)
Show all issues
```
E501 line too long (95 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 3)
Show all issues
```
E501 line too long (86 > 79 characters)
```

Great start! Looks like you're on the right track, and I'll do a more thorough review once everything is more complete.

reviewboard/webapi/resources/root_review.py (Diff revision 3)

Show all issues

On the master branch, we no longer need the unicode_literals imports.

reviewboard/webapi/resources/root_review.py (Diff revision 3)

Show all issues

This was just copied from the other review resource, but should probably be clarified since this one is not a child of a review request.

Description:

		Added rudimentary top level reviews endpoint.
		Ability to filter by username using ?user=username parameter
		Ability to filter by repository name using ?repository=repoName parameter
		Ability to filter by date range using ?last-updated-from and ?last-updated-to
		Ability to filter by review group using ?review-group=group_name
~		Added some basic tests for the new `root_reviews` resource.
	~	Added tests for the new `root_reviews` resource.
		Still missing documentation, some unit tests

Commits:

	Summary	ID
	attempted adding root_review	4a98ef5189063d4f605a70f87cd78c696ead9e5d
	got endpoint working (rudementarily), added some basic tests	206769261bfca454dc42dca506e10bb67bb6f20f
	get tests working	62f5caf5437416438fe386d3169a3d2c95de44c7
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	64e37475a38cd7180e70065a0b85c0557b7726bd
	added date filtering, added review group filtering, added blank unit tests	ef5f0394cfbcf904b9ecffee4c01530494e1db62
	removed unneeded imports	d01ead0c5789f6f273dde85ffc40820b514e2f1f
	attempted adding root_review	4a98ef5189063d4f605a70f87cd78c696ead9e5d
	got endpoint working (rudementarily), added some basic tests	206769261bfca454dc42dca506e10bb67bb6f20f
	get tests working	62f5caf5437416438fe386d3169a3d2c95de44c7
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	64e37475a38cd7180e70065a0b85c0557b7726bd
	added date filtering, added review group filtering, added blank unit tests	ef5f0394cfbcf904b9ecffee4c01530494e1db62
	removed unneeded imports	d01ead0c5789f6f273dde85ffc40820b514e2f1f
	added unit tests for last-updated-from and laste-updated-to parameters and addressed some patch feedback	46ef7bf956bd684356ad088143acc16ca8d53ca7

Diff:

Revision 4 (+718 -150)

Show changes

	reviewboard/webapi/resources/root.py
	reviewboard/webapi/resources/root_review.py
	reviewboard/webapi/tests/test_root_review.py
	reviewboard/webapi/tests/urls.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/webapi/resources/root_review.py (Diff revision 4)
Show all issues
```
E501 line too long (89 > 79 characters)
```
reviewboard/webapi/resources/root_review.py (Diff revision 4)
Show all issues
```
E501 line too long (84 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 4)
Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 4)
Show all issues
```
E501 line too long (95 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 4)
Show all issues
```
E501 line too long (90 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 4)
Show all issues
```
E501 line too long (82 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 4)
Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 4)
Show all issues
```
E501 line too long (95 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 4)
Show all issues
```
E501 line too long (96 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 4)
Show all issues
```
E501 line too long (94 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 4)
Show all issues
```
E501 line too long (109 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 4)
Show all issues
```
E501 line too long (121 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 4)
Show all issues
```
E501 line too long (117 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 4)
Show all issues
```
E501 line too long (82 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 4)
Show all issues
```
E501 line too long (139 > 79 characters)
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 4)
Show all issues
```
E501 line too long (84 > 79 characters)
```

Commits:

	Summary	ID
	attempted adding root_review	4a98ef5189063d4f605a70f87cd78c696ead9e5d
	got endpoint working (rudementarily), added some basic tests	206769261bfca454dc42dca506e10bb67bb6f20f
	get tests working	62f5caf5437416438fe386d3169a3d2c95de44c7
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	64e37475a38cd7180e70065a0b85c0557b7726bd
	added date filtering, added review group filtering, added blank unit tests	ef5f0394cfbcf904b9ecffee4c01530494e1db62
	removed unneeded imports	d01ead0c5789f6f273dde85ffc40820b514e2f1f
	added unit tests for last-updated-from and laste-updated-to parameters and addressed some patch feedback	46ef7bf956bd684356ad088143acc16ca8d53ca7
	attempted adding root_review	4a98ef5189063d4f605a70f87cd78c696ead9e5d
	got endpoint working (rudementarily), added some basic tests	206769261bfca454dc42dca506e10bb67bb6f20f
	get tests working	62f5caf5437416438fe386d3169a3d2c95de44c7
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	64e37475a38cd7180e70065a0b85c0557b7726bd
	added date filtering, added review group filtering, added blank unit tests	ef5f0394cfbcf904b9ecffee4c01530494e1db62
	removed unneeded imports	d01ead0c5789f6f273dde85ffc40820b514e2f1f
	added unit tests for last-updated-from and laste-updated-to parameters and addressed some patch feedback	46ef7bf956bd684356ad088143acc16ca8d53ca7
	finished review-group parameter, unit tests, and flake8 formatting	a82f040f7ad92cc37ac053662d0d7380c8d551b7

Diff:

Revision 5 (+791 -173)

Show changes

	reviewboard/webapi/resources/root.py
	reviewboard/webapi/resources/root_review.py
	reviewboard/webapi/tests/test_root_review.py
	reviewboard/webapi/tests/urls.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

		Added rudimentary top level reviews endpoint.
		Ability to filter by username using ?user=username parameter
		Ability to filter by repository name using ?repository=repoName parameter
		Ability to filter by date range using ?last-updated-from and ?last-updated-to
		Ability to filter by review group using ?review-group=group_name
		Added tests for the new `root_reviews` resource.
~		Still missing documentation, some unit tests
	~	Still missing documentation

Summary:

-	[WIP] Top Level Reviews API Endpoint
+	Top Level Reviews API Endpoint

Description:

~		Added rudimentary top level reviews endpoint.
~		Ability to filter by username using ?user=username parameter
~		Ability to filter by repository name using ?repository=repoName parameter
~		Ability to filter by date range using ?last-updated-from and ?last-updated-to
~		Ability to filter by review group using ?review-group=group_name
	~	Added top level reviews endpoint.
	~	Ability to filter by username using ?user=username parameter.
	~	Ability to filter by repository name using ?repository=repoName parameter.
	~	Ability to filter by date range using ?last-updated-from and ?last-updated-to parameters.
	~	Ability to filter by review group using ?review-group=group_name parameter.
		Added tests for the new `root_reviews` resource.
~		Still missing documentation
	~	Added documentation for top level reviews endpoint.

Commits:

	Summary	ID
	attempted adding root_review	4a98ef5189063d4f605a70f87cd78c696ead9e5d
	got endpoint working (rudementarily), added some basic tests	206769261bfca454dc42dca506e10bb67bb6f20f
	get tests working	62f5caf5437416438fe386d3169a3d2c95de44c7
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	64e37475a38cd7180e70065a0b85c0557b7726bd
	added date filtering, added review group filtering, added blank unit tests	ef5f0394cfbcf904b9ecffee4c01530494e1db62
	removed unneeded imports	d01ead0c5789f6f273dde85ffc40820b514e2f1f
	added unit tests for last-updated-from and laste-updated-to parameters and addressed some patch feedback	46ef7bf956bd684356ad088143acc16ca8d53ca7
	finished review-group parameter, unit tests, and flake8 formatting	a82f040f7ad92cc37ac053662d0d7380c8d551b7
	attempted adding root_review	4a98ef5189063d4f605a70f87cd78c696ead9e5d
	got endpoint working (rudementarily), added some basic tests	206769261bfca454dc42dca506e10bb67bb6f20f
	get tests working	62f5caf5437416438fe386d3169a3d2c95de44c7
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	64e37475a38cd7180e70065a0b85c0557b7726bd
	added date filtering, added review group filtering, added blank unit tests	ef5f0394cfbcf904b9ecffee4c01530494e1db62
	removed unneeded imports	d01ead0c5789f6f273dde85ffc40820b514e2f1f
	added unit tests for last-updated-from and laste-updated-to parameters and addressed some patch feedback	46ef7bf956bd684356ad088143acc16ca8d53ca7
	finished review-group parameter, unit tests, and flake8 formatting	a82f040f7ad92cc37ac053662d0d7380c8d551b7
	added documentation	55c5247da821df4fb376238c31ac7a6a8f806f32

Diff:

Revision 6 (+8188 -5886)

Show changes

	AUTHORS
	conftest.py
	dev-requirements.txt
	setup.py
	setup.cfg
	contrib/docker/build.py
	contrib/internal/prepare-dev.py
	contrib/internal/webapi-lint.py
	785 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/__init__.py (Diff revision 6)
Show all issues
```
F401 'importlib' imported but unused
```
reviewboard/accounts/backends/ldap.py (Diff revision 6)
Show all issues
```
F401 'django.utils.six' imported but unused
```

Change Summary:

Rebased off of origin/master.

Commits:

	Summary	ID
	attempted adding root_review	4a98ef5189063d4f605a70f87cd78c696ead9e5d
	got endpoint working (rudementarily), added some basic tests	206769261bfca454dc42dca506e10bb67bb6f20f
	get tests working	62f5caf5437416438fe386d3169a3d2c95de44c7
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	64e37475a38cd7180e70065a0b85c0557b7726bd
	added date filtering, added review group filtering, added blank unit tests	ef5f0394cfbcf904b9ecffee4c01530494e1db62
	removed unneeded imports	d01ead0c5789f6f273dde85ffc40820b514e2f1f
	added unit tests for last-updated-from and laste-updated-to parameters and addressed some patch feedback	46ef7bf956bd684356ad088143acc16ca8d53ca7
	finished review-group parameter, unit tests, and flake8 formatting	a82f040f7ad92cc37ac053662d0d7380c8d551b7
	added documentation	55c5247da821df4fb376238c31ac7a6a8f806f32
	attempted adding root_review	ec03d8deeb71d5a57b81acdc543a4e957b9cda98
	got endpoint working (rudementarily), added some basic tests	1cc3bc3ff5e466b8a100801946320fc110ba3261
	get tests working	3de9b81399c00e0ba216cfeb369ab6a9d508bbf4
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	9a18d8d58df4645b6ffea30ba1011058bf3d944c
	added date filtering, added review group filtering, added blank unit tests	02a7ebed1a9622585df30c63e04d4529bc22873e
	removed unneeded imports	1c91b9b3233a47860d390f5edb55e3f3411fed78
	added unit tests for last-updated-from and laste-updated-to parameters and addressed some patch feedback	4a167d944a0c5b6d31891ceec2df29d5d9e3936d
	finished review-group parameter, unit tests, and flake8 formatting	c628f9f7d225b38d7f977dcf231b5c9cfeb4908c
	added documentation	792e6a22a36639861060a11ad0ed484900112071

Diff:

Revision 7 (+915 -175)

Show changes

	docs/manual/webapi/2.0/resources/index.rst
	docs/manual/webapi/2.0/resources/root-review.rst
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/resources/root_review.py
	reviewboard/webapi/tests/test_root_review.py
	reviewboard/webapi/tests/urls.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Change Summary:

confirmed the compiled HTML of the documentation displays as expected.

Commits:

	Summary	ID
	attempted adding root_review	ec03d8deeb71d5a57b81acdc543a4e957b9cda98
	got endpoint working (rudementarily), added some basic tests	1cc3bc3ff5e466b8a100801946320fc110ba3261
	get tests working	3de9b81399c00e0ba216cfeb369ab6a9d508bbf4
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	9a18d8d58df4645b6ffea30ba1011058bf3d944c
	added date filtering, added review group filtering, added blank unit tests	02a7ebed1a9622585df30c63e04d4529bc22873e
	removed unneeded imports	1c91b9b3233a47860d390f5edb55e3f3411fed78
	added unit tests for last-updated-from and laste-updated-to parameters and addressed some patch feedback	4a167d944a0c5b6d31891ceec2df29d5d9e3936d
	finished review-group parameter, unit tests, and flake8 formatting	c628f9f7d225b38d7f977dcf231b5c9cfeb4908c
	added documentation	792e6a22a36639861060a11ad0ed484900112071
	attempted adding root_review	ec03d8deeb71d5a57b81acdc543a4e957b9cda98
	got endpoint working (rudementarily), added some basic tests	1cc3bc3ff5e466b8a100801946320fc110ba3261
	get tests working	3de9b81399c00e0ba216cfeb369ab6a9d508bbf4
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	9a18d8d58df4645b6ffea30ba1011058bf3d944c
	added date filtering, added review group filtering, added blank unit tests	02a7ebed1a9622585df30c63e04d4529bc22873e
	removed unneeded imports	1c91b9b3233a47860d390f5edb55e3f3411fed78
	added unit tests for last-updated-from and laste-updated-to parameters and addressed some patch feedback	4a167d944a0c5b6d31891ceec2df29d5d9e3936d
	finished review-group parameter, unit tests, and flake8 formatting	c628f9f7d225b38d7f977dcf231b5c9cfeb4908c
	added documentation	792e6a22a36639861060a11ad0ed484900112071
	finished up root review documentation and ensure it generates correctly	7b8db5e8d21439436caf0fc04e506a7196d52d68

Diff:

Revision 8 (+943 -195)

Show changes

	docs/manual/webapi/2.0/resources/index.rst
	docs/manual/webapi/2.0/resources/root-review-list.rst
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/resources/root_review.py
	reviewboard/webapi/tests/test_root_review.py
	reviewboard/webapi/tests/urls.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/webapi/resources/root_review.py (Diff revision 8)

Show all issues

Looks great! Only one suggestion here, once speficied in webapi_request_fields, we can get parsed parameters in kwargds. Using kwargds['drafts'] here should get parsed boolean value directly.

Looking great! I have a few comments but they're all trivial style things.

reviewboard/webapi/resources/root_review.py (Diff revision 8)

Show all issues

Please add a module docstring at the top of this file. Something like """Root-level resource for querying reviews."""

reviewboard/webapi/resources/root_review.py (Diff revision 8)

Show all issues

Imports from reviewboard should be in a separate group after third-party packages. So:

from django...
from djblets...

from reviewboard...

Everything within those two groups should be sorted alphabetically.

reviewboard/webapi/resources/root_review.py (Diff revision 8)
Show all issues
```
This can be wrapped much later. Line width is 79 columns.
```

reviewboard/webapi/resources/root_review.py (Diff revision 8)

Show all issues

I know you probably copied this from our other code, but this should use our new docstring standards: https://www.notion.so/reviewboard/Writing-Python-Docs-845c696271194d85b69503246db1d0e6

reviewboard/webapi/resources/root_review.py (Diff revision 8)
Show all issues
```
This needs a docstring.
```
reviewboard/webapi/resources/root_review.py (Diff revision 8)
Show all issues
```
Please update for new docstring standards.
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 8)
Show all issues
```
This file needs a module docstring.
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 8)
Show all issues
```
Please sort alphabetically - t before u
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 8)
Show all issues
```
This needs a blank line between these two.
```
reviewboard/webapi/tests/test_root_review.py (Diff revision 8)
Show all issues
```
Please add a docstring.
```

reviewboard/webapi/tests/test_root_review.py (Diff revision 8)

Show all issues

When we wrap a single-line docstring, please put the final """ on its own line:

def test_get_with_counts_only(self):
    """Testing the GET reviews/?counts_only=1 API returns expected
    counts
    """

reviewboard/webapi/tests/test_root_review.py (Diff revision 8)
Show all issues
```
""" on its own line.
```

reviewboard/webapi/tests/test_root_review.py (Diff revision 8)

Show all issues

""" on its own line. Please go through the rest of this file and change where appropriate.

Commits:

	Summary	ID
	attempted adding root_review	ec03d8deeb71d5a57b81acdc543a4e957b9cda98
	got endpoint working (rudementarily), added some basic tests	1cc3bc3ff5e466b8a100801946320fc110ba3261
	get tests working	3de9b81399c00e0ba216cfeb369ab6a9d508bbf4
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	9a18d8d58df4645b6ffea30ba1011058bf3d944c
	added date filtering, added review group filtering, added blank unit tests	02a7ebed1a9622585df30c63e04d4529bc22873e
	removed unneeded imports	1c91b9b3233a47860d390f5edb55e3f3411fed78
	added unit tests for last-updated-from and laste-updated-to parameters and addressed some patch feedback	4a167d944a0c5b6d31891ceec2df29d5d9e3936d
	finished review-group parameter, unit tests, and flake8 formatting	c628f9f7d225b38d7f977dcf231b5c9cfeb4908c
	added documentation	792e6a22a36639861060a11ad0ed484900112071
	finished up root review documentation and ensure it generates correctly	7b8db5e8d21439436caf0fc04e506a7196d52d68
	attempted adding root_review	ec03d8deeb71d5a57b81acdc543a4e957b9cda98
	got endpoint working (rudementarily), added some basic tests	1cc3bc3ff5e466b8a100801946320fc110ba3261
	get tests working	3de9b81399c00e0ba216cfeb369ab6a9d508bbf4
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	9a18d8d58df4645b6ffea30ba1011058bf3d944c
	added date filtering, added review group filtering, added blank unit tests	02a7ebed1a9622585df30c63e04d4529bc22873e
	removed unneeded imports	1c91b9b3233a47860d390f5edb55e3f3411fed78
	added unit tests for last-updated-from and laste-updated-to parameters and addressed some patch feedback	4a167d944a0c5b6d31891ceec2df29d5d9e3936d
	finished review-group parameter, unit tests, and flake8 formatting	c628f9f7d225b38d7f977dcf231b5c9cfeb4908c
	added documentation	792e6a22a36639861060a11ad0ed484900112071
	finished up root review documentation and ensure it generates correctly	7b8db5e8d21439436caf0fc04e506a7196d52d68
	feedback from chaoyu	c56e7745cc1782bfbcc4cc5954b87a2e66059444

Diff:

Revision 9 (+941 -199)

Show changes

	docs/manual/webapi/2.0/resources/index.rst
	docs/manual/webapi/2.0/resources/root-review-list.rst
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/resources/root_review.py
	reviewboard/webapi/tests/test_root_review.py
	reviewboard/webapi/tests/urls.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Commits:

	Summary	ID
	attempted adding root_review	ec03d8deeb71d5a57b81acdc543a4e957b9cda98
	got endpoint working (rudementarily), added some basic tests	1cc3bc3ff5e466b8a100801946320fc110ba3261
	get tests working	3de9b81399c00e0ba216cfeb369ab6a9d508bbf4
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	9a18d8d58df4645b6ffea30ba1011058bf3d944c
	added date filtering, added review group filtering, added blank unit tests	02a7ebed1a9622585df30c63e04d4529bc22873e
	removed unneeded imports	1c91b9b3233a47860d390f5edb55e3f3411fed78
	added unit tests for last-updated-from and laste-updated-to parameters and addressed some patch feedback	4a167d944a0c5b6d31891ceec2df29d5d9e3936d
	finished review-group parameter, unit tests, and flake8 formatting	c628f9f7d225b38d7f977dcf231b5c9cfeb4908c
	added documentation	792e6a22a36639861060a11ad0ed484900112071
	finished up root review documentation and ensure it generates correctly	7b8db5e8d21439436caf0fc04e506a7196d52d68
	feedback from chaoyu	c56e7745cc1782bfbcc4cc5954b87a2e66059444
	attempted adding root_review	ec03d8deeb71d5a57b81acdc543a4e957b9cda98
	got endpoint working (rudementarily), added some basic tests	1cc3bc3ff5e466b8a100801946320fc110ba3261
	get tests working	3de9b81399c00e0ba216cfeb369ab6a9d508bbf4
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	9a18d8d58df4645b6ffea30ba1011058bf3d944c
	added date filtering, added review group filtering, added blank unit tests	02a7ebed1a9622585df30c63e04d4529bc22873e
	removed unneeded imports	1c91b9b3233a47860d390f5edb55e3f3411fed78
	added unit tests for last-updated-from and laste-updated-to parameters and addressed some patch feedback	4a167d944a0c5b6d31891ceec2df29d5d9e3936d
	finished review-group parameter, unit tests, and flake8 formatting	c628f9f7d225b38d7f977dcf231b5c9cfeb4908c
	added documentation	792e6a22a36639861060a11ad0ed484900112071
	finished up root review documentation and ensure it generates correctly	7b8db5e8d21439436caf0fc04e506a7196d52d68
	feedback from chaoyu	c56e7745cc1782bfbcc4cc5954b87a2e66059444
	addressed feedback from David	27fa75dc9644639e7392f8cc1c34cbf82c09c77f

Diff:

Revision 10 (+1004 -232)

Show changes

	docs/manual/webapi/2.0/resources/index.rst
	docs/manual/webapi/2.0/resources/root-review-list.rst
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/resources/root_review.py
	reviewboard/webapi/tests/test_root_review.py
	reviewboard/webapi/tests/urls.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/webapi/resources/root_review.py (Diff revision 10)
Show all issues
```
webapi.decorators before webapi.fields
```

reviewboard/webapi/resources/root_review.py (Diff revision 10)

Show all issues

This should be in the imperative mood ("Return" instead of "Returns")

reviewboard/webapi/resources/root_review.py (Diff revision 10)
Show all issues
```
This line can dedent 4 spaces.
```
reviewboard/webapi/resources/root_review.py (Diff revision 10)
Show all issues
```
Returns -> Return
```
reviewboard/webapi/resources/root_review.py (Diff revision 10)
Show all issues
```
Returns -> Return
```

reviewboard/webapi/tests/test_root_review.py (Diff revision 10)

Show all issues

Instead of listing "reviews/" in each docstring, let's use "<URL>/" and add on the @webapi_test_template decorator.

sheenaNg April 4, 2022, 9:54 p.m.

I think it looks great overall! I just added a minor suggestion to add some blank lines in between groups of codes in the unit tests to improve readability and consistency in terms of styling.

reviewboard/webapi/tests/test_root_review.py (Diff revision 10)

Show all issues

I think everything looks good overall.

I just have a small suggestion to improve the unit tests readability: I think it would be easier to read if you add some blank lines to separate different groups of codes in the unit tests.

For example, add blank line after the codes that create review_request, review etc. and before calling the API endpoint. Then, add another blank line after calling the API endpoint and before the assertions.

I see that you have added some blank lines in some unit tests but not all. It will improve the consistency if this is applied to the rest of the unit tests.

Commits:

	Summary	ID
	attempted adding root_review	ec03d8deeb71d5a57b81acdc543a4e957b9cda98
	got endpoint working (rudementarily), added some basic tests	1cc3bc3ff5e466b8a100801946320fc110ba3261
	get tests working	3de9b81399c00e0ba216cfeb369ab6a9d508bbf4
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	9a18d8d58df4645b6ffea30ba1011058bf3d944c
	added date filtering, added review group filtering, added blank unit tests	02a7ebed1a9622585df30c63e04d4529bc22873e
	removed unneeded imports	1c91b9b3233a47860d390f5edb55e3f3411fed78
	added unit tests for last-updated-from and laste-updated-to parameters and addressed some patch feedback	4a167d944a0c5b6d31891ceec2df29d5d9e3936d
	finished review-group parameter, unit tests, and flake8 formatting	c628f9f7d225b38d7f977dcf231b5c9cfeb4908c
	added documentation	792e6a22a36639861060a11ad0ed484900112071
	finished up root review documentation and ensure it generates correctly	7b8db5e8d21439436caf0fc04e506a7196d52d68
	feedback from chaoyu	c56e7745cc1782bfbcc4cc5954b87a2e66059444
	addressed feedback from David	27fa75dc9644639e7392f8cc1c34cbf82c09c77f
	attempted adding root_review	ec03d8deeb71d5a57b81acdc543a4e957b9cda98
	got endpoint working (rudementarily), added some basic tests	1cc3bc3ff5e466b8a100801946320fc110ba3261
	get tests working	3de9b81399c00e0ba216cfeb369ab6a9d508bbf4
	Added user filtering by username. Added repository filtering by repository name. Added unit tests for user filtering and repository filtering	9a18d8d58df4645b6ffea30ba1011058bf3d944c
	added date filtering, added review group filtering, added blank unit tests	02a7ebed1a9622585df30c63e04d4529bc22873e
	removed unneeded imports	1c91b9b3233a47860d390f5edb55e3f3411fed78
	added unit tests for last-updated-from and laste-updated-to parameters and addressed some patch feedback	4a167d944a0c5b6d31891ceec2df29d5d9e3936d
	finished review-group parameter, unit tests, and flake8 formatting	c628f9f7d225b38d7f977dcf231b5c9cfeb4908c
	added documentation	792e6a22a36639861060a11ad0ed484900112071
	finished up root review documentation and ensure it generates correctly	7b8db5e8d21439436caf0fc04e506a7196d52d68
	feedback from chaoyu	c56e7745cc1782bfbcc4cc5954b87a2e66059444
	addressed feedback from David	27fa75dc9644639e7392f8cc1c34cbf82c09c77f
	addressed feedback from David and Sheena.	cacca7efd27207c02b718e271275dbe66416c69e

Diff:

Revision 11 (+1104 -262)

Show changes

	docs/manual/webapi/2.0/resources/index.rst
	docs/manual/webapi/2.0/resources/root-review-list.rst
	reviewboard/webapi/resources/root.py
	reviewboard/webapi/resources/root_review.py
	reviewboard/webapi/tests/test_root_review.py
	reviewboard/webapi/tests/urls.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

reviewboard/webapi/resources/root_review.py (Diff revision 11)

Show all issues

The review_request api endpoint filters by the ID of the repository instead of the name. Should we filter by ID here too for consistency or should we just specify in the description that this field is the name of the repository?

reviewboard/webapi/resources/root_review.py (Diff revision 11)

Show all issues

I'm going to specify that this is the "review group name of users" rather than "the group of users"

reviewboard/webapi/resources/root_review.py (Diff revision 11)

Show all issues

It might be worthwhile to add fields for "time-added-to" and "time-added-from" just so that there's more options for date filtering. Should I add these fields?

Status: Discarded

Change Summary:

This work has moved to /r/12297