Top Level Reviews API Endpoint

 






 

 


  Review Request #12028
  —
  Created Feb. 3, 2022 and discarded  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  TaylorChristie
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
    

  • Added top level reviews endpoint.
    • 

  • Ability to filter by username using ?user=username parameter.
    • 

  • Ability to filter by repository name using ?repository=repoName parameter.
    • 

  • Ability to filter by date range using ?last-updated-from and ?last-updated-to parameters.
    • 

  • Ability to filter by review group using ?review-group=group_name parameter.
    • 

  • Added tests for the new root_reviews resource.
    • 

  • Added documentation for top level reviews endpoint.
    • 


 








  


 
 

  
    

  • Wrote unit tests for all new functionality
    • 

  • Ran unit tests for root_reviews resource and ensure they pass
    • 

  • Tested new API endpoint manually and confirmed results were as expected.
    • 


 







 









 





  








 




 







   

    
    
Changes between revision 6 and 7



    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10
11

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    
attempted adding root_review

   
  		
  4a98ef5189063d4f605a70f87cd78c696ead9e5d
  Taylor Christie
 


 
  
 
 
  
   
    
got endpoint working (rudementarily), added some basic tests

   
  		
  206769261bfca454dc42dca506e10bb67bb6f20f
  Taylor Christie
 


 
  
 
 
  
   
    
get tests working

   
  		
  62f5caf5437416438fe386d3169a3d2c95de44c7
  Taylor Christie
 


 
  
 
 
  
   
    
Added user filtering by username. Added repository filtering by repository na...

   
  		
  64e37475a38cd7180e70065a0b85c0557b7726bd
  Taylor Christie
 


 
  
 
 
  
   
    
added date filtering, added review group filtering, added blank unit tests

   
  		
  ef5f0394cfbcf904b9ecffee4c01530494e1db62
  Taylor Christie
 


 
  
 
 
  
   
    
removed unneeded imports

   
  		
  d01ead0c5789f6f273dde85ffc40820b514e2f1f
  Taylor Christie
 


 
  
 
 
  
   
    
added unit tests for last-updated-from and laste-updated-to parameters and ad...

   
  		
  46ef7bf956bd684356ad088143acc16ca8d53ca7
  Taylor Christie
 


 
  
 
 
  
   
    
finished review-group parameter, unit tests, and flake8 formatting

   
  		
  a82f040f7ad92cc37ac053662d0d7380c8d551b7
  Taylor Christie
 


 
  
 
 
  
   
    
added documentation

   
  		
  55c5247da821df4fb376238c31ac7a6a8f806f32
  Taylor Christie
 


 
  
 
 
  
   
    
attempted adding root_review

   
  		
  ec03d8deeb71d5a57b81acdc543a4e957b9cda98
  Taylor Christie
 


 
  
 
 
  
   
    
got endpoint working (rudementarily), added some basic tests

   
  		
  1cc3bc3ff5e466b8a100801946320fc110ba3261
  Taylor Christie
 


 
  
 
 
  
   
    
get tests working

   
  		
  3de9b81399c00e0ba216cfeb369ab6a9d508bbf4
  Taylor Christie
 


 
  
 
 
  
   
    
Added user filtering by username. Added repository filtering by repository na...

   
  		
  9a18d8d58df4645b6ffea30ba1011058bf3d944c
  Taylor Christie
 


 
  
 
 
  
   
    
added date filtering, added review group filtering, added blank unit tests

   
  		
  02a7ebed1a9622585df30c63e04d4529bc22873e
  Taylor Christie
 


 
  
 
 
  
   
    
removed unneeded imports

   
  		
  1c91b9b3233a47860d390f5edb55e3f3411fed78
  Taylor Christie
 


 
  
 
 
  
   
    
added unit tests for last-updated-from and laste-updated-to parameters and ad...

   
  		
  4a167d944a0c5b6d31891ceec2df29d5d9e3936d
  Taylor Christie
 


 
  
 
 
  
   
    
finished review-group parameter, unit tests, and flake8 formatting

   
  		
  c628f9f7d225b38d7f977dcf231b5c9cfeb4908c
  Taylor Christie
 


 
  
 
 
  
   
    
added documentation

   
  		
  792e6a22a36639861060a11ad0ed484900112071
  Taylor Christie
 




    


    
    

 This diff has been split across 39 pages:
 
  <
 
 
  
   1
  
 
  
   2
  
 
  
   3
  
 
  
   4
  
 
  
   5
  
 
  
   6
  
 
  
   7
  
 
  
   8
  
 
  
   9
  
 
  
   10
  
 
  
   11
  
 
  
   12
  
 
  
   13
  
 
  
   14
  
 
  
   15
  
 
  
   16
  
 
  
   17
  
 
  
   18
  
 
  
   19
  
 
  
   20
  
 
  
   21
  
 
  
   22
  
 
  
   23
  
 
  
   24
  
 
  
   25
  
 
  
   26
  
 
  
   27
  
 
  
   28
  
 
  
   29
  
 
  
   30
  
 
  
   31
  
 
  
   32
  
 
  
   33
  
 
  
   34
  
 
  
   35
  
 
  
   36
  
 
  
   37
  
 
  
   38
  
 
  
   39
  
 
 
  >
 


   

  

 









 

  

   
    

     
      
      reviewboard/diffviewer/evolutions/filediffdata_line_counts.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/evolutions/raw_diff_file_data.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/management/commands/condensediffs.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/models/__init__.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/models/diffcommit.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/models/diffset.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/models/diffset_history.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/models/filediff.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/models/legacy_file_diff_data.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/models/raw_file_diff_data.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/templatetags/difftags.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/testing/__init__.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/testing/mixins.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_commit_utils.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_diff_chunk_generator.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_diff_opcode_generator.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_diff_parser.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_diff_renderer.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_diffcommit.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/diffviewer/tests/test_diffcommit_manager.py
     
    

   
  

 





 This diff has been split across 39 pages:
 
  <
 
 
  
   1
  
 
  
   2
  
 
  
   3
  
 
  
   4
  
 
  
   5
  
 
  
   6
  
 
  
   7
  
 
  
   8
  
 
  
   9
  
 
  
   10
  
 
  
   11
  
 
  
   12
  
 
  
   13
  
 
  
   14
  
 
  
   15
  
 
  
   16
  
 
  
   17
  
 
  
   18
  
 
  
   19
  
 
  
   20
  
 
  
   21
  
 
  
   22
  
 
  
   23
  
 
  
   24
  
 
  
   25
  
 
  
   26
  
 
  
   27
  
 
  
   28
  
 
  
   29
  
 
  
   30
  
 
  
   31
  
 
  
   32
  
 
  
   33
  
 
  
   34
  
 
  
   35
  
 
  
   36
  
 
  
   37
  
 
  
   38
  
 
  
   39
  
 
 
  >
 







     

    

   

  

  

   
   Loading...