Top Level Reviews API Endpoint

 






 

 


  Review Request #12028
  —
  Created Feb. 3, 2022 and discarded  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  TaylorChristie
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
    

  • Added top level reviews endpoint.
    • 

  • Ability to filter by username using ?user=username parameter.
    • 

  • Ability to filter by repository name using ?repository=repoName parameter.
    • 

  • Ability to filter by date range using ?last-updated-from and ?last-updated-to parameters.
    • 

  • Ability to filter by review group using ?review-group=group_name parameter.
    • 

  • Added tests for the new root_reviews resource.
    • 

  • Added documentation for top level reviews endpoint.
    • 


 








  


 
 

  
    

  • Wrote unit tests for all new functionality
    • 

  • Ran unit tests for root_reviews resource and ensure they pass
    • 

  • Tested new API endpoint manually and confirmed results were as expected.
    • 


 







 









 





  








 




 







   

    
    
Diff Revision 10


This is not the most recent revision of the diff. The latest diff is revision 11. See what's changed.

    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10
11

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    
attempted adding root_review

   
  		
  ec03d8deeb71d5a57b81acdc543a4e957b9cda98
  Taylor Christie
 


 
  
   
  
  
   
  
 
 
  
   
    
got endpoint working (rudementarily), added some basic tests

   
  		
  1cc3bc3ff5e466b8a100801946320fc110ba3261
  Taylor Christie
 


 
  
   
  
  
   
  
 
 
  
   
    
get tests working

   
  		
  3de9b81399c00e0ba216cfeb369ab6a9d508bbf4
  Taylor Christie
 


 
  
   
  
  
   
  
 
 
  
   
    
Added user filtering by username. Added repository filtering by repository na...

   
  		
  9a18d8d58df4645b6ffea30ba1011058bf3d944c
  Taylor Christie
 


 
  
   
  
  
   
  
 
 
  
   
    
added date filtering, added review group filtering, added blank unit tests

   
  		
  02a7ebed1a9622585df30c63e04d4529bc22873e
  Taylor Christie
 


 
  
   
  
  
   
  
 
 
  
   
    
removed unneeded imports

   
  		
  1c91b9b3233a47860d390f5edb55e3f3411fed78
  Taylor Christie
 


 
  
   
  
  
   
  
 
 
  
   
    
added unit tests for last-updated-from and laste-updated-to parameters and ad...

   
  		
  4a167d944a0c5b6d31891ceec2df29d5d9e3936d
  Taylor Christie
 


 
  
   
  
  
   
  
 
 
  
   
    
finished review-group parameter, unit tests, and flake8 formatting

   
  		
  c628f9f7d225b38d7f977dcf231b5c9cfeb4908c
  Taylor Christie
 


 
  
   
  
  
   
  
 
 
  
   
    
added documentation

   
  		
  792e6a22a36639861060a11ad0ed484900112071
  Taylor Christie
 


 
  
   
  
  
   
  
 
 
  
   
    
finished up root review documentation and ensure it generates correctly

   
  		
  7b8db5e8d21439436caf0fc04e506a7196d52d68
  Taylor Christie
 


 
  
   
  
  
   
  
 
 
  
   
    
feedback from chaoyu

   
  		
  c56e7745cc1782bfbcc4cc5954b87a2e66059444
  Taylor Christie
 


 
  
   
  
  
   
  
 
 
  
   
    
addressed feedback from David

   
  		
  27fa75dc9644639e7392f8cc1c34cbf82c09c77f
  Taylor Christie
 




    


    
    

   

  

 









 

  

   
    

     
      
      docs/manual/webapi/2.0/resources/index.rst
     
    

   
  

 



 

  

   
    

     
      
      docs/manual/webapi/2.0/resources/root-review-list.rst
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/root.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/resources/root_review.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/test_root_review.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/webapi/tests/urls.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...