Call middleware with new style invocation.

 






 

 


  Review Request #12027
  —
  Created Feb. 3, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
The old process_request method for middleware was deprecated with the

move to MIDDLEWARE from the old MIDDLEWARE_CLASSES. Our testcase

create_http_request method does a bunch of stuff to build a fake HTTP

request, including running the session and message middleware to

populate attributes on the request. This change moves that invocation

over to the new style (instantiate with a get_response method, and

then treat as a callable).

 








  


 
 

  
Ran unit tests.

 







 









 





  








 




 







   

    
    
Diff Revision 2 (Latest)



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Call middleware with new style invocation.
     
The old `process_request` method for middleware was deprecated with the
move to `MIDDLEWARE` from the old `MIDDLEWARE_CLASSES`. Our testcase
`create_http_request` method does a bunch of stuff to build a fake HTTP
request, including running the session and message middleware to
populate attributes on the request. This change moves that invocation
over to the new style (instantiate with a `get_response` method, and
then treat as a callable).

Testing Done:
Ran unit tests.

    

   
  		
  55d1a92fad07a75fb1d68dedd0fc93910a298fb9
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      reviewboard/accounts/tests/test_account_settings_form.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/accounts/tests/test_x509_auth_middleware.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/testing/testcase.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...