Summary:

Call middleware with new style invocation.

Review Request #12027 — Created Feb. 3, 2022 and submitted Feb. 8, 2022, 11:10 p.m.

Information
Owner:	david
Repository:	Review Board
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

The old process_request method for middleware was deprecated with the
move to MIDDLEWARE from the old MIDDLEWARE_CLASSES. Our testcase
create_http_request method does a bunch of stuff to build a fake HTTP
request, including running the session and message middleware to
populate attributes on the request. This change moves that invocation
over to the new style (instantiate with a get_response method, and
then treat as a callable).

Testing Done

Ran unit tests.

Commits

Summary
	Call middleware with new style invocation.

Screenshots

Issues

Description	From	Last Updated
Even better, let's move this code to use self.create_http_request() instead. This code predates that function.	chipx86	Feb. 3, 2022, 10:57 p.m.

flake8 passed.

JSHint passed.

reviewboard/accounts/tests/test_account_settings_form.py (Diff revision 1)

Show all issues

Even better, let's move this code to use self.create_http_request() instead. This code predates that function.

Commits:

	Summary
-		Call middleware with new style invocation.
+		Call middleware with new style invocation.

Diff:

Revision 2 (+20 -96)

Show changes

	reviewboard/accounts/tests/test_account_settings_form.py
	reviewboard/accounts/tests/test_x509_auth_middleware.py
	reviewboard/testing/testcase.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to django-3.2 (2fb504d)