Convert ugettext to gettext.

 






 

 


  Review Request #12026
  —
  Created Feb. 2, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Review Board
 









 
 

  master
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Now that Django is Python 3 only, the regular gettext methods always

return unicode str types. The aliases prefixed with u were

deprecated and will be removed in Django 4.x, so we should switch over

now to silence a ton of warnings.

 








  


 
 

  
Ran unit tests.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Convert ugettext to gettext.
     
Now that Django is Python 3 only, the regular `gettext` methods always
return unicode `str` types. The aliases prefixed with `u` were
deprecated and will be removed in Django 4.x, so we should switch over
now to silence a ton of warnings.

Testing Done:
Ran unit tests.

    

   
  		
  5d7cffb174f85324d432594d47f8ae81c9fadc0c
  David Trowbridge
 




    


    
    

 This diff has been split across 8 pages:
 
  <
 
 
  
   1
  
 
  
   2
  
 
  
   3
  
 
  
   4
  
 
  
   5
  
 
  
   6
  
 
  
   7
  
 
  
   8
  
 
 
  >
 


   

  

 









 

  

   
    

     
      
      reviewboard/reviews/models/diff_comment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/models/file_attachment_comment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/models/general_comment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/models/group.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/models/review.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/models/review_request.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/models/review_request_draft.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/models/screenshot.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/models/screenshot_comment.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/models/status_update.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/templatetags/reviewtags.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/tests/test_fields.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/ui/base.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/reviews/ui/markdownui.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/admin.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/clearcase.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/conditions.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/core.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/cvs.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/scmtools/errors.py
     
    

   
  

 





 This diff has been split across 8 pages:
 
  <
 
 
  
   1
  
 
  
   2
  
 
  
   3
  
 
  
   4
  
 
  
   5
  
 
  
   6
  
 
  
   7
  
 
  
   8
  
 
 
  >
 







     

    

   

  

  

   
   Loading...