Summary

Convert ugettext to gettext.

Review Request #12026 — Created Feb. 2, 2022 and submitted Feb. 8, 2022, 12:07 a.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Now that Django is Python 3 only, the regular gettext methods always

return unicode str types. The aliases prefixed with u were

deprecated and will be removed in Django 4.x, so we should switch over

now to silence a ton of warnings.

Testing Done

Ran unit tests.

Commits

Summary	ID
Convert ugettext to gettext. Now that Django is Python 3 only, the regular `gettext` methods always return unicode `str` types. The aliases prefixed with `u` were deprecated and will be removed in Django 4.x, so we should switch over now to silence a ton of warnings. Testing Done: Ran unit tests.	fe2dfdb587abffd4acdb816d971fbf49b918561a

Issues

Description	From	Last Updated
F401 'django.utils.translation.gettext as _' imported but unused	reviewbot	Feb. 2, 2022, 1:51 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/decorators.py (Diff revision 1)
The issue has been dropped. Show all issues
```
F401 'django.utils.translation.gettext as _' imported but unused
```

Commits:

	Summary	ID
	Convert ugettext to gettext. Now that Django is Python 3 only, the regular `gettext` methods always return unicode `str` types. The aliases prefixed with `u` were deprecated and will be removed in Django 4.x, so we should switch over now to silence a ton of warnings. Testing Done: Ran unit tests.	5d7cffb174f85324d432594d47f8ae81c9fadc0c
	Convert ugettext to gettext. Now that Django is Python 3 only, the regular `gettext` methods always return unicode `str` types. The aliases prefixed with `u` were deprecated and will be removed in Django 4.x, so we should switch over now to silence a ton of warnings. Testing Done: Ran unit tests.	fe2dfdb587abffd4acdb816d971fbf49b918561a

Diff:

Revision 2 (+640 -650)

Show changes

	reviewboard/accounts/admin.py
	reviewboard/accounts/mixins.py
	reviewboard/accounts/models.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/privacy.py
	reviewboard/accounts/trophies.py
	reviewboard/accounts/views.py
	reviewboard/accounts/backends/ad.py
	159 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to django-3.2 (3bd98ad)