Fix errors from BitBucket submitted hook with too many logins.

Review Request #12019 — Created Jan. 28, 2022 and submitted — Latest diff uploaded

Information

Review Board
release-4.0.x

Reviewers

When a BitBucket repository is configured with an account with an
incorrect password, at some point BitBucket will lock the account and
start returning 403s instead of 401s. Because our check for
authorization-related errors was only checking for 401, the submitted
hook would end up with uncaught exceptions, triggering e-mails to the
admins.

This change adds a check for the error message that BitBucket returns in
this case to handle the error correctly.

Ran unit tests.

Commits

Files

    Loading...