Summary

Fix errors from BitBucket submitted hook with too many logins.

Review Request #12019 — Created Jan. 28, 2022 and submitted Feb. 3, 2022, 3 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

When a BitBucket repository is configured with an account with an
incorrect password, at some point BitBucket will lock the account and
start returning 403s instead of 401s. Because our check for
authorization-related errors was only checking for 401, the submitted
hook would end up with uncaught exceptions, triggering e-mails to the
admins.

This change adds a check for the error message that BitBucket returns in
this case to handle the error correctly.

Testing Done

Ran unit tests.

Commits

Summary	ID
Fix erors from BitBucket submitted hook with too many logins. When a BitBucket repository is configured with an account with an incorrect password, at some point BitBucket will lock the account and start returning 403s instead of 401s. Because our check for authorization-related errors was only checking for 401, the submitted hook would end up with uncaught exceptions, triggering e-mails to the admins. This change adds a check for the error message that BitBucket returns in this case to handle the error correctly. Testing Done: Ran unit tests.	e81365ea0efb6428135385c597febf12abd66dea

Summary

Fix erors from BitBucket submitted hook with too many logins.

When a BitBucket repository is configured with an account with an incorrect password, at some point BitBucket will lock the account and start returning 403s instead of 401s. Because our check for authorization-related errors was only checking for 401, the submitted hook would end up with uncaught exceptions, triggering e-mails to the admins. This change adds a check for the error message that BitBucket returns in this case to handle the error correctly. Testing Done: Ran unit tests.

e81365ea0efb6428135385c597febf12abd66dea

Issues

Description	From	Last Updated
Typo in the summary: "erors"	chipx86	Feb. 1, 2022, 9:51 p.m.
E501 line too long (83 > 79 characters)	reviewbot	Jan. 28, 2022, 2:38 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/tests/test_bitbucket.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (83 > 79 characters)
```

Commits:

	Summary	ID
	Fix erors from BitBucket submitted hook with too many logins. When a BitBucket repository is configured with an account with an incorrect password, at some point BitBucket will lock the account and start returning 403s instead of 401s. Because our check for authorization-related errors was only checking for 401, the submitted hook would end up with uncaught exceptions, triggering e-mails to the admins. This change adds a check for the error message that BitBucket returns in this case to handle the error correctly. Testing Done: Ran unit tests.	7bcbe4f25b6a87c752d3c0111027324da1568133
	Fix erors from BitBucket submitted hook with too many logins. When a BitBucket repository is configured with an account with an incorrect password, at some point BitBucket will lock the account and start returning 403s instead of 401s. Because our check for authorization-related errors was only checking for 401, the submitted hook would end up with uncaught exceptions, triggering e-mails to the admins. This change adds a check for the error message that BitBucket returns in this case to handle the error correctly. Testing Done: Ran unit tests.	e81365ea0efb6428135385c597febf12abd66dea

Diff:

Revision 2 (+152 -8)

Show changes

	reviewboard/hostingsvcs/bitbucket.py
	reviewboard/hostingsvcs/tests/test_bitbucket.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

The issue has been resolved. Show all issues
```
Typo in the summary: "erors"
```

Summary:: Fix erors from BitBucket submitted hook with too many logins.
Fix errors from BitBucket submitted hook with too many logins.

Status:: Completed
Change Summary:: Pushed to release-4.0.x (b096557)