Summary

Use getfullargspec on Python 3 and getargspec on Python 2.

Review Request #11996 — Created Jan. 24, 2022 and submitted Jan. 25, 2022, 2:13 p.m.

Information

Owner

chipx86

Repository

Django Evolution

Branch

release-2.x

Bugs

Depends On

Reviewers

Groups

django-evolution

People

Description

We need to check the arguments of the function passed into a

SQLMutation, to determine if we need to be in a legacy mode when

calling that function. We were using getargspec() for this, but that

emits deprecation warnings on Python 3.
We now call getfullargspec() on Python 3 instead, avoiding these

warnings.

Testing Done

All unit tests pass for all supported configurations.

Commits

Summary	ID
Use getfullargspec on Python 3 and getargspec on Python 2. We need to check the arguments of the function passed into a `SQLMutation`, to determine if we need to be in a legacy mode when calling that function. We were using `getargspec()` for this, but that emits deprecation warnings on Python 3. We now call `getfullargspec()` on Python 3 instead, avoiding these warnings.	d5301d6793fb486aefe37352717d70305d3c4100

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.x (3cb84c0)