Summary

Switch away from six moves shims.

Review Request #11981 — Created Jan. 22, 2022 and submitted Feb. 4, 2022, 3:43 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Now that we're Python 3 only, we don't need to use the six library to
handle relocated or renamed APIs. This change gets rid of all the
six.moves usage.

Testing Done

Ran unit tests.

Commits

Summary	ID
Switch away from six moves shims. Now that we're Python 3 only, we don't need to use the six library to handle relocated or renamed APIs. This change gets rid of all the `six.moves` usage. Testing Done: Ran unit tests.	c66683a0203c9fca46b28afe7646f9de8c1b9790

Issues

Description	From	Last Updated
F401 'urllib.parse.urlencode' imported but unused	reviewbot	Jan. 22, 2022, 3:04 p.m.
F401 'urllib.error.URLError' imported but unused	reviewbot	Jan. 22, 2022, 3:04 p.m.
F401 'urllib.error.HTTPError' imported but unused	reviewbot	Jan. 22, 2022, 3:04 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/hostingsvcs/gerrit.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'urllib.parse.urlencode' imported but unused
```
reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'urllib.error.URLError' imported but unused
```
reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
F401 'urllib.error.HTTPError' imported but unused
```

Change Summary:

Make Review Bot happy

Commits:

	Summary	ID
	Switch away from six moves shims. Now that we're Python 3 only, we don't need to use the six library to handle relocated or renamed APIs. This change gets rid of all the `six.moves` usage. Testing Done: Ran unit tests.	943499d042c9b5ff7404cd5577594098ce007e8e
	Switch away from six moves shims. Now that we're Python 3 only, we don't need to use the six library to handle relocated or renamed APIs. This change gets rid of all the `six.moves` usage. Testing Done: Ran unit tests.	c66683a0203c9fca46b28afe7646f9de8c1b9790

Diff:

Revision 2 (+166 -218)

Show changes

	setup.cfg
	reviewboard/manage.py
	reviewboard/accounts/decorators.py
	reviewboard/accounts/forms/pages.py
	reviewboard/admin/security_checks.py
	reviewboard/admin/server.py
	reviewboard/admin/forms/general_settings.py
	reviewboard/avatars/services.py
	54 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-5.0.x (1326bae)