Summary

Fix some test errors in extension manager caused by database changes.

Review Request #11976 — Created Jan. 22, 2022 and submitted Feb. 3, 2022, 10:26 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

The extension manager tests were encountering a few errors caused by
changes to Django's database layer.

First, there were some errors coming from django-evolution using the
schema editor. The sqlite backend has been changed to error out if the
schema editor is invoked in the middle of an existing atomic
transaction, and django testcases are all run from within transactions.
To get around this, I've made it so the entire extension manager test
case disabled constraint checking.

Second, the allow_thread_sharing property was made read-only, and
changing it now requires using the inc_thread_sharing() and
dec_thread_sharing() methods. These have been added where appropriate.

Testing Done

Ran unit tests.

Commits

Summary	ID
Fix some test errors in extension manager caused by database changes. The extension manager tests were encountering a few errors caused by changes to Django's database layer. First, there were some errors coming from django-evolution using the schema editor. The sqlite backend has been changed to error out if the schema editor is invoked in the middle of an existing atomic transaction, and django testcases are all run from within transactions. To get around this, I've made it so the entire extension manager test case disabled constraint checking. Second, the `allow_thread_sharing` property was made read-only, and changing it now requires using the `inc_thread_sharing()` and `dec_thread_sharing()` methods. These have been added where appropriate. Testing Done: Ran unit tests.	90f5cf9abbbc2dd1c2322dd302bf8a322cd251a8

Summary

Fix some test errors in extension manager caused by database changes.

The extension manager tests were encountering a few errors caused by changes to Django's database layer. First, there were some errors coming from django-evolution using the schema editor. The sqlite backend has been changed to error out if the schema editor is invoked in the middle of an existing atomic transaction, and django testcases are all run from within transactions. To get around this, I've made it so the entire extension manager test case disabled constraint checking. Second, the `allow_thread_sharing` property was made read-only, and changing it now requires using the `inc_thread_sharing()` and `dec_thread_sharing()` methods. These have been added where appropriate. Testing Done: Ran unit tests.

90f5cf9abbbc2dd1c2322dd302bf8a322cd251a8

Issues

Description	From	Last Updated
I feel we want to wrap this all in a try/finally.	chipx86	Jan. 25, 2022, 11:28 p.m.

flake8 passed.

JSHint passed.

djblets/extensions/tests/test_extension_manager.py (Diff revision 1)

The issue has been resolved. Show all issues

I feel we want to wrap this all in a try/finally.

Commits:

	Summary	ID
	Fix some test errors in extension manager caused by database changes. The extension manager tests were encountering a few errors caused by changes to Django's database layer. First, there were some errors coming from django-evolution using the schema editor. The sqlite backend has been changed to error out if the schema editor is invoked in the middle of an existing atomic transaction, and django testcases are all run from within transactions. To get around this, I've made it so the entire extension manager test case disabled constraint checking. Second, the `allow_thread_sharing` property was made read-only, and changing it now requires using the `inc_thread_sharing()` and `dec_thread_sharing()` methods. These have been added where appropriate. Testing Done: Ran unit tests.	65bc3673e1725688e35df44eaca01eec2efcb6ac
	Fix some test errors in extension manager caused by database changes. The extension manager tests were encountering a few errors caused by changes to Django's database layer. First, there were some errors coming from django-evolution using the schema editor. The sqlite backend has been changed to error out if the schema editor is invoked in the middle of an existing atomic transaction, and django testcases are all run from within transactions. To get around this, I've made it so the entire extension manager test case disabled constraint checking. Second, the `allow_thread_sharing` property was made read-only, and changing it now requires using the `inc_thread_sharing()` and `dec_thread_sharing()` methods. These have been added where appropriate. Testing Done: Ran unit tests.	90f5cf9abbbc2dd1c2322dd302bf8a322cd251a8

Diff:

Revision 2 (+52 -24)

Show changes

djblets/extensions/tests/test_extension_manager.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (ed25d87)