Use named logging in accounts module

Review Request #11965 — Created Jan. 21, 2022 and submitted

kylemclean
Review Board
release-4.0.x
4898
reviewboard

This commit fixes bug #4898 by replacing uses of logging functions
with functions on a named Logger object in each file of the accounts
module.

Ran unit tests in reviewboard.accounts.tests.

Summary
Use named logging in accounts module
Fix indentation in logging changes of accounts module
Description From Last Updated

Please put the bug number into the "Bugs" field rather than the description.

daviddavid

These lines need to be dedented by 1 space to match.

daviddavid

These lines need to be dedented by 1 space to match.

daviddavid

These lines need to be dedented by 1 space to match.

daviddavid

These lines need to be dedented by 1 space to match.

daviddavid

While we're in here, let's change these strings to use single quotes around the outside, and double quotes on the …

daviddavid

This line needs to be dedented by 1 space to match.

daviddavid

This line needs to be dedented by 1 space to match.

daviddavid

These lines need to be dedented by 1 space to match.

daviddavid

These lines need to be dedented by 1 space to match.

daviddavid

These lines need to be dedented by 1 space to match.

daviddavid

These lines need to be dedented by 1 space to match.

daviddavid

This line needs to be dedented by 1 space to match.

daviddavid

This line needs to be dedented by 1 space to match.

daviddavid

These lines need to be dedented by 1 space to match.

daviddavid

These lines need to be dedented by 1 space to match.

daviddavid
david
  1. 
      
  2. Please put the bug number into the "Bugs" field rather than the description.

  3. reviewboard/accounts/backends/registry.py (Diff revision 1)
     
     
     
     

    These lines need to be dedented by 1 space to match.

  4. reviewboard/accounts/backends/registry.py (Diff revision 1)
     
     
     

    These lines need to be dedented by 1 space to match.

  5. reviewboard/accounts/backends/standard.py (Diff revision 1)
     
     
     
     

    These lines need to be dedented by 1 space to match.

  6. These lines need to be dedented by 1 space to match.

  7. reviewboard/accounts/backends/x509.py (Diff revision 1)
     
     
     
     
     

    While we're in here, let's change these strings to use single quotes around the outside, and double quotes on the inside.

  8. reviewboard/accounts/backends/x509.py (Diff revision 1)
     
     

    This line needs to be dedented by 1 space to match.

  9. reviewboard/accounts/backends/x509.py (Diff revision 1)
     
     

    This line needs to be dedented by 1 space to match.

  10. reviewboard/accounts/forms/pages.py (Diff revision 1)
     
     
     

    These lines need to be dedented by 1 space to match.

  11. reviewboard/accounts/forms/pages.py (Diff revision 1)
     
     
     

    These lines need to be dedented by 1 space to match.

  12. reviewboard/accounts/forms/pages.py (Diff revision 1)
     
     
     

    These lines need to be dedented by 1 space to match.

  13. reviewboard/accounts/forms/pages.py (Diff revision 1)
     
     
     

    These lines need to be dedented by 1 space to match.

  14. reviewboard/accounts/managers.py (Diff revision 1)
     
     

    This line needs to be dedented by 1 space to match.

  15. reviewboard/accounts/managers.py (Diff revision 1)
     
     

    This line needs to be dedented by 1 space to match.

  16. reviewboard/accounts/views.py (Diff revision 1)
     
     
     

    These lines need to be dedented by 1 space to match.

  17. reviewboard/accounts/views.py (Diff revision 1)
     
     
     

    These lines need to be dedented by 1 space to match.

  18. 
      
KY
KY
KY
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to django-3.2 (5b22a8e)
david
  1. Ship It!
  2. 
      
Loading...