Summary

Use named logging in accounts module

Review Request #11965 — Created Jan. 21, 2022 and submitted March 24, 2022, 12:09 p.m.

Information

Owner

kylemclean

Repository

Review Board

Branch

release-4.0.x

Bugs

4898

Depends On

Reviewers

Groups

reviewboard

People

Description

This commit fixes bug #4898 by replacing uses of logging functions
with functions on a named Logger object in each file of the accounts
module.

Testing Done

Ran unit tests in reviewboard.accounts.tests.

Commits

Summary	ID
Use named logging in accounts module This commit fixes bug #4898 by replacing uses of `logging` functions with functions on a named `Logger` object in each file of the accounts module.	4891fa1dc164b3747350f027d840b4bdde6d4568
Fix indentation in logging changes of accounts module	55bd49f4364ada0de666eec448bbeb4e502110b2

Issues

Description	From	Last Updated
Please put the bug number into the "Bugs" field rather than the description.	david	Jan. 22, 2022, 8:53 a.m.
These lines need to be dedented by 1 space to match.	david	Jan. 22, 2022, 8:56 a.m.
These lines need to be dedented by 1 space to match.	david	Jan. 22, 2022, 10:19 a.m.
These lines need to be dedented by 1 space to match.	david	Jan. 22, 2022, 10:19 a.m.
These lines need to be dedented by 1 space to match.	david	Jan. 22, 2022, 10:20 a.m.
While we're in here, let's change these strings to use single quotes around the outside, and double quotes on the …	david	Jan. 22, 2022, 10:20 a.m.
This line needs to be dedented by 1 space to match.	david	Jan. 22, 2022, 10:21 a.m.
This line needs to be dedented by 1 space to match.	david	Jan. 22, 2022, 10:21 a.m.
These lines need to be dedented by 1 space to match.	david	Jan. 22, 2022, 10:21 a.m.
These lines need to be dedented by 1 space to match.	david	Jan. 22, 2022, 10:22 a.m.
These lines need to be dedented by 1 space to match.	david	Jan. 22, 2022, 10:22 a.m.
These lines need to be dedented by 1 space to match.	david	Jan. 22, 2022, 10:22 a.m.
This line needs to be dedented by 1 space to match.	david	Jan. 22, 2022, 10:22 a.m.
This line needs to be dedented by 1 space to match.	david	Jan. 22, 2022, 10:22 a.m.
These lines need to be dedented by 1 space to match.	david	Jan. 22, 2022, 10:23 a.m.
These lines need to be dedented by 1 space to match.	david	Jan. 22, 2022, 10:23 a.m.

flake8 passed.

JSHint passed.

Show all issues

Please put the bug number into the "Bugs" field rather than the description.

reviewboard/accounts/backends/registry.py (Diff revision 1)
Show all issues
```
These lines need to be dedented by 1 space to match.
```
reviewboard/accounts/backends/registry.py (Diff revision 1)
Show all issues
```
These lines need to be dedented by 1 space to match.
```
reviewboard/accounts/backends/standard.py (Diff revision 1)
Show all issues
```
These lines need to be dedented by 1 space to match.
```
reviewboard/accounts/backends/standard.py (Diff revision 1)
Show all issues
```
These lines need to be dedented by 1 space to match.
```

reviewboard/accounts/backends/x509.py (Diff revision 1)

Show all issues

While we're in here, let's change these strings to use single quotes around the outside, and double quotes on the inside.

reviewboard/accounts/backends/x509.py (Diff revision 1)
Show all issues
```
This line needs to be dedented by 1 space to match.
```
reviewboard/accounts/backends/x509.py (Diff revision 1)
Show all issues
```
This line needs to be dedented by 1 space to match.
```
reviewboard/accounts/forms/pages.py (Diff revision 1)
Show all issues
```
These lines need to be dedented by 1 space to match.
```
reviewboard/accounts/forms/pages.py (Diff revision 1)
Show all issues
```
These lines need to be dedented by 1 space to match.
```
reviewboard/accounts/forms/pages.py (Diff revision 1)
Show all issues
```
These lines need to be dedented by 1 space to match.
```
reviewboard/accounts/forms/pages.py (Diff revision 1)
Show all issues
```
These lines need to be dedented by 1 space to match.
```
reviewboard/accounts/managers.py (Diff revision 1)
Show all issues
```
This line needs to be dedented by 1 space to match.
```
reviewboard/accounts/managers.py (Diff revision 1)
Show all issues
```
This line needs to be dedented by 1 space to match.
```

reviewboard/accounts/views.py (Diff revision 1)

Show all issues

These lines need to be dedented by 1 space to match.

reviewboard/accounts/views.py (Diff revision 1)

Show all issues

These lines need to be dedented by 1 space to match.

Change Summary:

Add bug number to Bugs field

Bugs:

+	4898

Change Summary:


Fix indentation in logging changes of acconuts module.
Make the requested change to replace the double-quoted string with a single-quoted string.

Commits:

	Summary	ID
	Use named logging in accounts module This commit fixes bug #4898 by replacing uses of `logging` functions with functions on a named `Logger` object in each file of the accounts module.	4891fa1dc164b3747350f027d840b4bdde6d4568
	Use named logging in accounts module This commit fixes bug #4898 by replacing uses of `logging` functions with functions on a named `Logger` object in each file of the accounts module.	4891fa1dc164b3747350f027d840b4bdde6d4568
	Fix indentation in logging changes of accounts module	55bd49f4364ada0de666eec448bbeb4e502110b2

Diff:

Revision 2 (+122 -82)

Show changes

	reviewboard/accounts/managers.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/views.py
	reviewboard/accounts/backends/registry.py
	reviewboard/accounts/backends/standard.py
	reviewboard/accounts/backends/x509.py
	reviewboard/accounts/forms/pages.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to django-3.2 (5b22a8e)

Ship it!

```
Ship It!
```