flake8
failed.
JSHint
passed.
flake8
-
reviewboard/notifications/email/utils.py (Diff revision 1) Show all issues
Added email validation for users before they are added to an email recipient list
Review Request #11958 — Created Jan. 21, 2022 and updated
Added email validation so only valid emails are being sent to and any blank or invalid emails are not included.
- Created a user with an email and verified there were no errors when creating/updating a review request
- Removed the users email and verified that the recipient had an invalid email and has issues sending the email
- added in validation and ensure that a warning log is printed when a user has an invalid email
- Added back the email and ensured that the user was included on the email
| Summary | ID |
|---|---|
| 3a79866394ab9504a9cf82152bfe8050810fe2e0 | |
| 9ad64d6f066fb5fd29d97aca2702881ea22f398e | |
| 1a4d3e32529fcd44d5f515618f817744c49cda5f |
| Description | From | Last Updated |
|---|---|---|
|
Instead of listing the bug number in the summary and linking it in the description, just add the bug number … |
 david
|
|
|
For the summary, let's make sure it starts with a capital letter. |
david
|
|
|
In the description, please explain what the bug was and how your change fixes it. |
david
|
|
|
F841 local variable 'e' is assigned to but never used |
 reviewbot
|
|
|
We should probably keep this as-is and do validation for everything in the addresses set. get_email_addresses_for_group can give us potentially … |
david
|
Description: |
|
|---|
Commits: |
|
|||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+22 -4) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
Instead of listing the bug number in the summary and linking it in the description, just add the bug number to the "Bugs" field.
-
-
-
reviewboard/notifications/email/utils.py (Diff revision 2) We should probably keep this as-is and do validation for everything in the
addressesset.get_email_addresses_for_groupcan give us potentially invalid addresses as well.
Summary: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||
Bugs: |
|