Summary:

Added email validation for users before they are added to an email recipient list

Review Request #11958 — Created Jan. 21, 2022 and updated Feb. 3, 2022, 4:30 p.m.

Information
Owner:	TaylorChristie
Repository:	Review Board
Branch:	release-4.0.x
Bugs:	4937
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

Added email validation so only valid emails are being sent to and any blank or invalid emails are not included.

Testing Done


Created a user with an email and verified there were no errors when creating/updating a review request
Removed the users email and verified that the recipient had an invalid email and has issues sending the email
added in validation and ensure that a warning log is printed when a user has an invalid email
Added back the email and ensured that the user was included on the email

Commits

Summary
[4937] added email validation for users before they are added to an email recipient list
[4937] added back missing whitespace
[4937] removed needless assignment of exception

Screenshots

Issues

Description	From	Last Updated
Instead of listing the bug number in the summary and linking it in the description, just add the bug number …	david	Jan. 21, 2022, 3:45 p.m.
For the summary, let's make sure it starts with a capital letter.	david	Jan. 21, 2022, 3:45 p.m.
In the description, please explain what the bug was and how your change fixes it.	david	Jan. 21, 2022, 3:47 p.m.
F841 local variable 'e' is assigned to but never used	reviewbot	Jan. 21, 2022, 1:36 p.m.
We should probably keep this as-is and do validation for everything in the addresses set. get_email_addresses_for_group can give us potentially …	david	Jan. 21, 2022, 3:10 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/notifications/email/utils.py (Diff revision 1)
Show all issues
```
F841 local variable 'e' is assigned to but never used
```

Description:

~		Added email validation so only valid emails are being sent an email and any blank or invalid emails are not included on a given email.
	~	Added email validation so only valid emails are being sent to and any blank or invalid emails are not included.

		Fixes: https://hellosplat.com/s/beanbag/tickets/4937/

Commits:

	Summary
-	[4937] added email validation for users before they are added to an email recipient list
-	[4937] added back missing whitespace
+	[4937] added email validation for users before they are added to an email recipient list
+	[4937] added back missing whitespace
+	[4937] removed needless assignment of exception

Diff:

Revision 2 (+22 -4)

Show changes

reviewboard/notifications/email/utils.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Fix it!

Show all issues

Instead of listing the bug number in the summary and linking it in the description, just add the bug number to the "Bugs" field.

Show all issues

For the summary, let's make sure it starts with a capital letter.

Show all issues

In the description, please explain what the bug was and how your change fixes it.

reviewboard/notifications/email/utils.py (Diff revision 2)

Show all issues

We should probably keep this as-is and do validation for everything in the addresses set. get_email_addresses_for_group can give us potentially invalid addresses as well.

Summary:

-	[4937] added email validation for users before they are added to an email recipient list
+	Added email validation for users before they are added to an email recipient list

Description:

		Added email validation so only valid emails are being sent to and any blank or invalid emails are not included.
-
-		Fixes: https://hellosplat.com/s/beanbag/tickets/4937/

Bugs:

+	4937