Summary

Update URL patterns to use new path() and re_path().

Review Request #11956 — Created Jan. 21, 2022 and submitted Feb. 3, 2022, 11:27 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Django 2+ provides a new method for definings URLs, path(). This is
much simpler for basic cases, and makes URL patterns more readable. In
addition, the old url() method has been renamed to re_path(), and a
warning is raised when using the old name, so switch to that too.

Testing Done

Ran unit tests.

Commits

Summary	ID
Update URL patterns to use new path() and re_path(). Django 2+ provides a new method for definings URLs, `path()`. This is much simpler for basic cases, and makes URL patterns more readable. In addition, the old `url()` method has been renamed to `re_path()`, and a warning is raised when using the old name, so switch to that too. Testing Done: Ran unit tests.	0bffd78fa1db5fba618a57556aa84c6751228e59

Issues

Description	From	Last Updated
Mind tweaking the summary to be a little more clear on what this does? I went into this thinking the …	chipx86	Jan. 25, 2022, 11:52 p.m.
W605 invalid escape sequence '\.'	reviewbot	Jan. 21, 2022, 1:28 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Jan. 21, 2022, 1:28 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Jan. 21, 2022, 1:28 p.m.
Alignment is off.	chipx86	Jan. 25, 2022, 11:50 p.m.
Alignment is off.	chipx86	Jan. 25, 2022, 11:50 p.m.
Alignment is off.	chipx86	Jan. 25, 2022, 11:51 p.m.
Alignment is off. Can we just put the { on the path( line so that we can keep the contents …	chipx86	Jan. 25, 2022, 11:51 p.m.
This was already here, but the }) alignment is off.	chipx86	Jan. 25, 2022, 11:51 p.m.
Alignment is off.	chipx86	Jan. 25, 2022, 11:52 p.m.
Indentation of the subsequent lines are all too far.	chipx86	Jan. 31, 2022, 3:50 p.m.
django.urls should be last.	chipx86	Jan. 31, 2022, 3:50 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/integrations/urls.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W605 invalid escape sequence '\.'
```
djblets/webapi/resources/base.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (84 > 79 characters)
```
djblets/webapi/resources/root.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```

Commits:

	Summary	ID
	Update URL patterns. Django 2+ provides a new method for definings URLs, `path()`. This is much simpler for basic cases, and makes URL patterns more readable. In addition, the old `url()` method has been renamed to `re_path()`, and a warning is raised when using the old name, so switch to that too. Testing Done: Ran unit tests.	55fef718e66b859d9d62c903202c4d442f855c46
	Update URL patterns. Django 2+ provides a new method for definings URLs, `path()`. This is much simpler for basic cases, and makes URL patterns more readable. In addition, the old `url()` method has been renamed to `re_path()`, and a warning is raised when using the old name, so switch to that too. Testing Done: Ran unit tests.	eee12ddc7866436116eb522af848bd1ef7094517

Diff:

Revision 2 (+140 -144)

Show changes

	djblets/auth/urls.py
	djblets/extensions/hooks.py
	djblets/extensions/manager.py
	djblets/extensions/resources.py
	djblets/extensions/urls.py
	djblets/extensions/tests/test_url_hook.py
	djblets/extensions/tests/test_views.py
	djblets/extensions/tests/apps/urls.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Mind tweaking the summary to be a little more clear on what this does? I went into this thinking the change was going to be something entirely different.

djblets/extensions/manager.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Alignment is off.
```
djblets/extensions/manager.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Alignment is off.
```
djblets/extensions/tests/test_url_hook.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Alignment is off.
```

djblets/extensions/tests/test_views.py (Diff revision 2)

The issue has been resolved. Show all issues

Alignment is off.
Can we just put the { on the path( line so that we can keep the contents nicely indented 4 spaces relative to path(? I think we may also want to make this a kwargs={?

djblets/feedview/test_urls.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This was already here, but the }) alignment is off.
```
djblets/urls/root.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Alignment is off.
```

Summary:

-	Update URL patterns.
+	Update URL patterns to use new path() and re_path().

Description:

		Django 2+ provides a new method for definings URLs, `path()`. This is
		much simpler for basic cases, and makes URL patterns more readable. In
		addition, the old `url()` method has been renamed to `re_path()`, and a
		warning is raised when using the old name, so switch to that too.
	+
	+	Testing Done:
	+	Ran unit tests.

Commits:

	Summary	ID
	Update URL patterns. Django 2+ provides a new method for definings URLs, `path()`. This is much simpler for basic cases, and makes URL patterns more readable. In addition, the old `url()` method has been renamed to `re_path()`, and a warning is raised when using the old name, so switch to that too. Testing Done: Ran unit tests.	eee12ddc7866436116eb522af848bd1ef7094517
	Update URL patterns to use new path() and re_path(). Django 2+ provides a new method for definings URLs, `path()`. This is much simpler for basic cases, and makes URL patterns more readable. In addition, the old `url()` method has been renamed to `re_path()`, and a warning is raised when using the old name, so switch to that too. Testing Done: Ran unit tests.	3be9cce18f4d4486e5b562be456ea96d5d768f37

Diff:

Revision 3 (+150 -156)

Show changes

	djblets/auth/urls.py
	djblets/extensions/hooks.py
	djblets/extensions/manager.py
	djblets/extensions/resources.py
	djblets/extensions/urls.py
	djblets/extensions/tests/test_url_hook.py
	djblets/extensions/tests/test_views.py
	djblets/extensions/tests/apps/urls.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

		Django 2+ provides a new method for definings URLs, `path()`. This is
		much simpler for basic cases, and makes URL patterns more readable. In
		addition, the old `url()` method has been renamed to `re_path()`, and a
		warning is raised when using the old name, so switch to that too.
-
-		Testing Done:
-		Ran unit tests.

djblets/extensions/tests/test_views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Indentation of the subsequent lines are all too far.
```
djblets/urls/root.py (Diff revision 3)
The issue has been resolved. Show all issues
```
django.urls should be last.
```

Commits:

	Summary	ID
	Update URL patterns to use new path() and re_path(). Django 2+ provides a new method for definings URLs, `path()`. This is much simpler for basic cases, and makes URL patterns more readable. In addition, the old `url()` method has been renamed to `re_path()`, and a warning is raised when using the old name, so switch to that too. Testing Done: Ran unit tests.	3be9cce18f4d4486e5b562be456ea96d5d768f37
	Update URL patterns to use new path() and re_path(). Django 2+ provides a new method for definings URLs, `path()`. This is much simpler for basic cases, and makes URL patterns more readable. In addition, the old `url()` method has been renamed to `re_path()`, and a warning is raised when using the old name, so switch to that too. Testing Done: Ran unit tests.	0bffd78fa1db5fba618a57556aa84c6751228e59

Diff:

Revision 4 (+158 -164)

Show changes

	djblets/auth/urls.py
	djblets/extensions/hooks.py
	djblets/extensions/manager.py
	djblets/extensions/resources.py
	djblets/extensions/urls.py
	djblets/extensions/tests/test_url_hook.py
	djblets/extensions/tests/test_views.py
	djblets/extensions/tests/apps/urls.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (870a9095).