Summary:

Update URL patterns to use new path() and re_path().

Review Request #11956 — Created Jan. 21, 2022 and submitted Feb. 3, 2022, 10:27 p.m.

Information
Owner:	david
Repository:	Djblets
Branch:	release-3.x
Bugs:
Depends On:
Reviewers
Groups:	djblets
People:

Description

Django 2+ provides a new method for definings URLs, path(). This is
much simpler for basic cases, and makes URL patterns more readable. In
addition, the old url() method has been renamed to re_path(), and a
warning is raised when using the old name, so switch to that too.

Testing Done

Ran unit tests.

Commits

Summary
	Update URL patterns to use new path() and re_path().

Screenshots

Issues

Description	From	Last Updated
Mind tweaking the summary to be a little more clear on what this does? I went into this thinking the …	chipx86	Jan. 25, 2022, 10:52 p.m.
W605 invalid escape sequence '\.'	reviewbot	Jan. 21, 2022, 12:28 p.m.
E501 line too long (84 > 79 characters)	reviewbot	Jan. 21, 2022, 12:28 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Jan. 21, 2022, 12:28 p.m.
Alignment is off.	chipx86	Jan. 25, 2022, 10:50 p.m.
Alignment is off.	chipx86	Jan. 25, 2022, 10:50 p.m.
Alignment is off.	chipx86	Jan. 25, 2022, 10:51 p.m.
Alignment is off. Can we just put the { on the path( line so that we can keep the contents …	chipx86	Jan. 25, 2022, 10:51 p.m.
This was already here, but the }) alignment is off.	chipx86	Jan. 25, 2022, 10:51 p.m.
Alignment is off.	chipx86	Jan. 25, 2022, 10:52 p.m.
Indentation of the subsequent lines are all too far.	chipx86	Jan. 31, 2022, 2:50 p.m.
django.urls should be last.	chipx86	Jan. 31, 2022, 2:50 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/integrations/urls.py (Diff revision 1)
Show all issues
```
W605 invalid escape sequence '\.'
```
djblets/webapi/resources/base.py (Diff revision 1)
Show all issues
```
E501 line too long (84 > 79 characters)
```
djblets/webapi/resources/root.py (Diff revision 1)
Show all issues
```
E501 line too long (80 > 79 characters)
```

Commits:

	Summary
-		Update URL patterns.
+		Update URL patterns.

Diff:

Revision 2 (+140 -144)

Show changes

	djblets/auth/urls.py
	djblets/extensions/hooks.py
	djblets/extensions/manager.py
	djblets/extensions/resources.py
	djblets/extensions/urls.py
	djblets/extensions/tests/test_url_hook.py
	djblets/extensions/tests/test_views.py
	djblets/extensions/tests/apps/urls.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Show all issues

Mind tweaking the summary to be a little more clear on what this does? I went into this thinking the change was going to be something entirely different.

djblets/extensions/manager.py (Diff revision 2)
Show all issues
```
Alignment is off.
```
djblets/extensions/manager.py (Diff revision 2)
Show all issues
```
Alignment is off.
```
djblets/extensions/tests/test_url_hook.py (Diff revision 2)
Show all issues
```
Alignment is off.
```

djblets/extensions/tests/test_views.py (Diff revision 2)

Show all issues

Alignment is off.
Can we just put the { on the path( line so that we can keep the contents nicely indented 4 spaces relative to path(? I think we may also want to make this a kwargs={?

djblets/feedview/test_urls.py (Diff revision 2)

Show all issues

This was already here, but the }) alignment is off.

djblets/urls/root.py (Diff revision 2)
Show all issues
```
Alignment is off.
```

Summary:

-	Update URL patterns.
+	Update URL patterns to use new path() and re_path().

Description:

		Django 2+ provides a new method for definings URLs, `path()`. This is
		much simpler for basic cases, and makes URL patterns more readable. In
		addition, the old `url()` method has been renamed to `re_path()`, and a
		warning is raised when using the old name, so switch to that too.
	+
	+	Testing Done:
	+	Ran unit tests.

Commits:

	Summary
-		Update URL patterns.
+		Update URL patterns to use new path() and re_path().

Diff:

Revision 3 (+150 -156)

Show changes

	djblets/auth/urls.py
	djblets/extensions/hooks.py
	djblets/extensions/manager.py
	djblets/extensions/resources.py
	djblets/extensions/urls.py
	djblets/extensions/tests/test_url_hook.py
	djblets/extensions/tests/test_views.py
	djblets/extensions/tests/apps/urls.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Description:

		Django 2+ provides a new method for definings URLs, `path()`. This is
		much simpler for basic cases, and makes URL patterns more readable. In
		addition, the old `url()` method has been renamed to `re_path()`, and a
		warning is raised when using the old name, so switch to that too.
-
-		Testing Done:
-		Ran unit tests.

djblets/extensions/tests/test_views.py (Diff revision 3)

Show all issues

Indentation of the subsequent lines are all too far.

djblets/urls/root.py (Diff revision 3)
Show all issues
```
django.urls should be last.
```

Commits:

	Summary
-		Update URL patterns to use new path() and re_path().
+		Update URL patterns to use new path() and re_path().

Diff:

Revision 4 (+158 -164)

Show changes

	djblets/auth/urls.py
	djblets/extensions/hooks.py
	djblets/extensions/manager.py
	djblets/extensions/resources.py
	djblets/extensions/urls.py
	djblets/extensions/tests/test_url_hook.py
	djblets/extensions/tests/test_views.py
	djblets/extensions/tests/apps/urls.py
	9 more

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (870a9095).