Switch to using named logging inside cmdline folder

Review Request #11954 — Created Jan. 21, 2022 and submitted

Information

Review Board
release-4.0.x

Reviewers

Instantiate a logger and use that instead of calling logging function in cmdline folder

Tested by calling the scripts in the command line and verified that the error logs were being printed when using logger.error instead of logging.error.

Summary ID
Switch to using named logging inside cmdline folder
e70345053ebd260cf298b3de1ea00753e7df907f
Description From Last Updated

Please add the bug number to the "Bugs" field.

daviddavid

Indentation on these lines needs to be changed to match (logger is one character shorter than logging).

daviddavid

Can you revert the change to this file?

daviddavid

Python wants two blank lines around top-level items in a file.

daviddavid

Indentation on this line needs to be changed to match (logger is one character shorter than logging). Let's also put …

daviddavid

Indentation on this line needs to be changed to match (logger is one character shorter than logging). Let's also put …

daviddavid

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot
gdehal
mike_conley
  1. Hi Gurvir! So there's a bunch of things in here that don't seem to be related to your patch... did you make sure to create this commit on top of a branch off of 4.0.x?

    Also, we need a bit more for the summary / description / testing done. Please see https://www.notion.so/reviewboard/Writing-Good-Change-Descriptions-10529e7c207743fa8ca90153d4b21fea

  2. 
      
gdehal
mike_conley
  1. Here's an example of a review request doing one of these named logger changes with a more fleshed out description / testing done: https://reviews.reviewboard.org/r/11811/

  2. 
      
gdehal
gdehal
david
  1. 
      
  2. Please add the bug number to the "Bugs" field.

  3. reviewboard/cmdline/rbext.py (Diff revision 3)
     
     
     

    Indentation on these lines needs to be changed to match (logger is one character shorter than logging).

  4. reviewboard/cmdline/rbsite.py (Diff revision 3)
     
     

    Can you revert the change to this file?

  5. reviewboard/cmdline/rbssh.py (Diff revision 3)
     
     
     
     

    Python wants two blank lines around top-level items in a file.

  6. reviewboard/cmdline/rbssh.py (Diff revision 3)
     
     

    Indentation on this line needs to be changed to match (logger is one character shorter than logging).

    Let's also put the % on the second line rather than the first:

    logger.error('...'
                 % username)
    
  7. reviewboard/cmdline/rbssh.py (Diff revision 3)
     
     

    Indentation on this line needs to be changed to match (logger is one character shorter than logging).

    Let's also put the % on the second line rather than the first.

  8. 
      
gdehal
Review request changed

Change Summary:

Addressed code review comments

Commits:

Summary ID
Switched from using logging to logger
af1a352f0098b7faf6b0b8fd30299695dcd028f0
Change logger.basicConfig to use logging
9f73de7300aeb00483f260ea8591448bd07d627d
Switch to using named logging inside cmdline folder
f7c285df25d4e4917d11241e7385638a76ef3913

Bugs:

+4902

Diff:

Revision 4 (+32 -16)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

gdehal
gdehal
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to django-3.2 (0c0e034)
david
  1. Ship It!
  2. 
      
Loading...