Switch to using named logging inside cmdline folder
Review Request #11954 — Created Jan. 21, 2022 and submitted
Instantiate a logger and use that instead of calling logging function in cmdline folder
Tested by calling the scripts in the command line and verified that the error logs were being printed when using
logger.error
instead oflogging.error
.
Summary | ID |
---|---|
e70345053ebd260cf298b3de1ea00753e7df907f |
Description | From | Last Updated |
---|---|---|
Please add the bug number to the "Bugs" field. |
david | |
Indentation on these lines needs to be changed to match (logger is one character shorter than logging). |
david | |
Can you revert the change to this file? |
david | |
Python wants two blank lines around top-level items in a file. |
david | |
Indentation on this line needs to be changed to match (logger is one character shorter than logging). Let's also put … |
david | |
Indentation on this line needs to be changed to match (logger is one character shorter than logging). Let's also put … |
david | |
W291 trailing whitespace |
reviewbot | |
W291 trailing whitespace |
reviewbot |
- Commits:
-
Summary ID ff24bc18bd6fe88c5a7f47c9ad84a9ccff6caa9c af1a352f0098b7faf6b0b8fd30299695dcd028f0
Checks run (2 succeeded)
-
Here's an example of a review request doing one of these named logger changes with a more fleshed out description / testing done: https://reviews.reviewboard.org/r/11811/
- Description:
-
~ Switch from using logging to logger in cmdline folder
~ Instantiate a logger and use that instead of calling logging function in cmdline folder
- Testing Done:
-
+ Tested by calling the scripts in the command line and verified that the error logs were being printed when using
logger.error
instead oflogging.error
. - Commits:
-
Summary ID af1a352f0098b7faf6b0b8fd30299695dcd028f0 af1a352f0098b7faf6b0b8fd30299695dcd028f0 9f73de7300aeb00483f260ea8591448bd07d627d
Checks run (2 succeeded)
-
-
-
Indentation on these lines needs to be changed to match (
logger
is one character shorter thanlogging
). -
-
-
Indentation on this line needs to be changed to match (
logger
is one character shorter thanlogging
).Let's also put the % on the second line rather than the first:
logger.error('...' % username)
-
Indentation on this line needs to be changed to match (
logger
is one character shorter thanlogging
).Let's also put the % on the second line rather than the first.
- Change Summary:
-
Addressed code review comments
- Commits:
-
Summary ID af1a352f0098b7faf6b0b8fd30299695dcd028f0 9f73de7300aeb00483f260ea8591448bd07d627d f7c285df25d4e4917d11241e7385638a76ef3913 - Bugs: