Explicitly escape for "unsafe" mode in definevar.

Review Request #11953 — Created Jan. 21, 2022 and submitted

Information

Djblets
release-3.x

Reviewers

Our definevar tag was relying on str being treated as unsafe strings,
but in the test suite that seems to no longer be the case for template
tags (though I'm not finding much in the documentation about this). This
change updates it to explicitly call escape instead of relying on the
type-checking deeper down.

Ran unit tests.

Summary ID
Explicitly escape for "unsafe" mode in definevar.
Our `definevar` tag was relying on `str` being treated as unsafe strings, but in the test suite that seems to no longer be the case for template tags (though I'm not finding much in the documentation about this). This change updates it to explicitly call `escape` instead of relying on the type-checking deeper down. Testing Done: Ran unit tests.
7338851306362770fe5ffec19d833288feb1ceda
chipx86
  1. Ship It!
  2. 
      
david
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.x (0570b0e)