Summary

Switch to class-based JavascriptCatalog view.

Review Request #11952 — Created Jan. 21, 2022 and submitted Feb. 3, 2022, 10:26 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

The old javascript_catalog function-based view has been removed, so we
need to use the class-based one instead.

Testing Done

Ran unit tests.

Commits

Summary	ID
Switch to class-based JavascriptCatalog view. The old javascript_catalog function-based view has been removed, so we need to use the class-based one instead. Testing Done: Ran unit tests.	651711146c19ce56b8f9c085293fd433531bc5af

Issues

Description	From	Last Updated
E501 line too long (85 > 79 characters)	reviewbot	Jan. 21, 2022, 10:56 a.m.
Can we instantiate this only when cache_memoize needs to generate data?	chipx86	Jan. 25, 2022, 11:26 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/util/views.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (85 > 79 characters)
```

Commits:

	Summary	ID
	Switch to class-based JavascriptCatalog view. The old javascript_catalog function-based view has been removed, so we need to use the class-based one instead. Testing Done: Ran unit tests.	8d007545bacebf539eda2aad0328fa89be97999b
	Switch to class-based JavascriptCatalog view. The old javascript_catalog function-based view has been removed, so we need to use the class-based one instead. Testing Done: Ran unit tests.	467dbc32e204e633cf889e9ad1b29f11639ea308

Diff:

Revision 2 (+8 -4)

Show changes

djblets/util/views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

djblets/util/views.py (Diff revision 2)

The issue has been resolved. Show all issues

Can we instantiate this only when cache_memoize needs to generate data?

Commits:

	Summary	ID
	Switch to class-based JavascriptCatalog view. The old javascript_catalog function-based view has been removed, so we need to use the class-based one instead. Testing Done: Ran unit tests.	467dbc32e204e633cf889e9ad1b29f11639ea308
	Switch to class-based JavascriptCatalog view. The old javascript_catalog function-based view has been removed, so we need to use the class-based one instead. Testing Done: Ran unit tests.	651711146c19ce56b8f9c085293fd433531bc5af

Diff:

Revision 3 (+6 -4)

Show changes

djblets/util/views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (8b7ee14)