- Download Diff

Summary:

Switch to class-based JavascriptCatalog view.

Review Request #11952 — Created Jan. 21, 2022 and submitted Feb. 3, 2022, 10:26 p.m.

Information
Owner:	david
Repository:	Djblets
Branch:	release-3.x
Bugs:
Depends On:
Reviewers
Groups:	djblets
People:

Description

The old javascript_catalog function-based view has been removed, so we
need to use the class-based one instead.

Testing Done

Ran unit tests.

Commits

Summary
	Switch to class-based JavascriptCatalog view.

Screenshots

Issues

Description	From	Last Updated
E501 line too long (85 > 79 characters)	reviewbot	Jan. 21, 2022, 10:56 a.m.
Can we instantiate this only when cache_memoize needs to generate data?	chipx86	Jan. 25, 2022, 11:26 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/util/views.py (Diff revision 1)
Show all issues
```
E501 line too long (85 > 79 characters)
```

Commits:

	Summary
-		Switch to class-based JavascriptCatalog view.
+		Switch to class-based JavascriptCatalog view.

Diff:

Revision 2 (+8 -4)

Show changes

djblets/util/views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

djblets/util/views.py (Diff revision 2)

Show all issues

Can we instantiate this only when cache_memoize needs to generate data?

Commits:

	Summary
-		Switch to class-based JavascriptCatalog view.
+		Switch to class-based JavascriptCatalog view.

Diff:

Revision 3 (+6 -4)

Show changes

djblets/util/views.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (8b7ee14)

You have a pending review.

Review Board 5.0 alpha 0 (dev)

Switch to class-based JavascriptCatalog view.

flake8

Commits:

Diff:

Checks run (2 succeeded)

Commits:

Diff:

Checks run (2 succeeded)

Status: Closed (submitted)

Change Summary: