Remove use of six

Review Request #11939 — Created Jan. 19, 2022 and submitted

Information

Djblets
release-3.x

Reviewers

This change removes the remainder of the uses of the six library from
Djblets.

In conjunction with other changes, ran unit tests.

Summary ID
Remove use of six
This change removes the remainder of the uses of the `six` library from Djblets. Testing Done: In conjunction with other changes, ran unit tests.
4b7f7a56a939671924cc57f14d72c762a384ba90
Description From Last Updated

E999 SyntaxError: invalid syntax

reviewbotreviewbot

Just to keep things very cleanly separated, can we move the pipeline stuff into a new change?

chipx86chipx86

We can now just put "str" in the string itself in place of "%s".

chipx86chipx86

Same here.

chipx86chipx86

Too many blank lines.

chipx86chipx86

Can we pull the call out into a related_links variable and iterate over that? This looks kinda wonky.

chipx86chipx86

Typo: "exetnsions" -> "extensions"

chipx86chipx86

E999 SyntaxError: invalid syntax

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

chipx86
  1. 
      
  2. djblets/extensions/staticfiles.py (Diff revision 1)
     
     

    Just to keep things very cleanly separated, can we move the pipeline stuff into a new change?

    1. Whoops, not sure how this slipped into this change. Good catch.

  3. djblets/util/tests/test_json_utils.py (Diff revision 1)
     
     
     
     

    We can now just put "str" in the string itself in place of "%s".

  4. djblets/util/tests/test_json_utils.py (Diff revision 1)
     
     
     

    Same here.

  5. djblets/util/tests/test_properties.py (Diff revision 1)
     
     
     
     
     
     

    Too many blank lines.

  6. djblets/webapi/resources/base.py (Diff revision 1)
     
     
     

    Can we pull the call out into a related_links variable and iterate over that? This looks kinda wonky.

  7. 
      
david
Review request changed

Commits:

Summary ID
Remove use of six
This change removes the remainder of the uses of the `six` library from Djblets. Testing Done: In conjunction with other changes, ran unit tests.
f0f55f7be56a41afe8bff567a993f05df6302e19
Remove use of six
This change removes the remainder of the uses of the `six` library from Djblets. Testing Done: In conjunction with other changes, ran unit tests.
4b7f7a56a939671924cc57f14d72c762a384ba90

Diff:

Revision 2 (+534 -814)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

chipx86
  1. 
      
  2. djblets/extensions/hooks.py (Diff revision 2)
     
     

    Typo: "exetnsions" -> "extensions"

  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (873baf5)
Loading...