flake8
-
djblets/extensions/hooks.py (Diff revision 1) Show all issues
Review Request #11939 — Created Jan. 19, 2022 and submitted
Information | |
---|---|
david | |
Djblets | |
release-3.x | |
Reviewers | |
djblets | |
This change removes the remainder of the uses of the
six
library from
Djblets.
In conjunction with other changes, ran unit tests.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
E999 SyntaxError: invalid syntax |
![]() |
|
Just to keep things very cleanly separated, can we move the pipeline stuff into a new change? |
|
|
We can now just put "str" in the string itself in place of "%s". |
|
|
Same here. |
|
|
Too many blank lines. |
|
|
Can we pull the call out into a related_links variable and iterate over that? This looks kinda wonky. |
|
|
Typo: "exetnsions" -> "extensions" |
|
|
E999 SyntaxError: invalid syntax |
![]() |
djblets/extensions/staticfiles.py (Diff revision 1) |
---|
Just to keep things very cleanly separated, can we move the pipeline stuff into a new change?
djblets/util/tests/test_json_utils.py (Diff revision 1) |
---|
We can now just put "str" in the string itself in place of "%s".
djblets/webapi/resources/base.py (Diff revision 1) |
---|
Can we pull the call out into a
related_links
variable and iterate over that? This looks kinda wonky.
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 2 (+534 -814) |