This change has been marked as completed.

Describe the completed change (optional):

Pushed to release-3.x (873baf5)

Summary

Remove use of six

Review Request #11939 — Created Jan. 19, 2022 and submitted 3 years, 3 months ago

Information

Owner

david*

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description*

This change removes the remainder of the uses of the six library from
Djblets.

Testing Done

In conjunction with other changes, ran unit tests.

Commits

Summary	ID
Remove use of six This change removes the remainder of the uses of the `six` library from Djblets. Testing Done: In conjunction with other changes, ran unit tests.	4b7f7a56a939671924cc57f14d72c762a384ba90

Issues

Description	From	Last Updated
E999 SyntaxError: invalid syntax	reviewbot	3 years, 3 months ago
Just to keep things very cleanly separated, can we move the pipeline stuff into a new change?	chipx86	3 years, 3 months ago
We can now just put "str" in the string itself in place of "%s".	chipx86	3 years, 3 months ago
Same here.	chipx86	3 years, 3 months ago
Too many blank lines.	chipx86	3 years, 3 months ago
Can we pull the call out into a related_links variable and iterate over that? This looks kinda wonky.	chipx86	3 years, 3 months ago
Typo: "exetnsions" -> "extensions"	chipx86	3 years, 3 months ago
E999 SyntaxError: invalid syntax	reviewbot	3 years, 3 months ago
There are no open issues

flake8 failed.

JSHint passed.

flake8

djblets/extensions/hooks.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```

djblets/extensions/staticfiles.py (Diff revision 1)

The issue has been resolved. Show all issues

Just to keep things very cleanly separated, can we move the pipeline stuff into a new change?

david 3 years, 3 months ago

Whoops, not sure how this slipped into this change. Good catch.

djblets/util/tests/test_json_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
We can now just put "str" in the string itself in place of "%s".
```
djblets/util/tests/test_json_utils.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here.
```
djblets/util/tests/test_properties.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Too many blank lines.
```

djblets/webapi/resources/base.py (Diff revision 1)

The issue has been resolved. Show all issues

Can we pull the call out into a related_links variable and iterate over that? This looks kinda wonky.

Commits:

	Summary	ID
	Remove use of six This change removes the remainder of the uses of the `six` library from Djblets. Testing Done: In conjunction with other changes, ran unit tests.	f0f55f7be56a41afe8bff567a993f05df6302e19
	Remove use of six This change removes the remainder of the uses of the `six` library from Djblets. Testing Done: In conjunction with other changes, ran unit tests.	4b7f7a56a939671924cc57f14d72c762a384ba90

Diff:

Revision 2 (+534 -814)

Show changes

	djblets/auth/ratelimit.py
	djblets/auth/tests/test_ratelimit.py
	djblets/cache/backend.py
	djblets/conditions/conditions.py
	djblets/conditions/tests/test_conditions.py
	djblets/configforms/forms.py
	djblets/configforms/views.py
	djblets/configforms/tests/test_config_pages_view.py
	89 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

djblets/extensions/hooks.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```

Ship it!

djblets/extensions/hooks.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Typo: "exetnsions" -> "extensions"
```

Status:: Completed
Change Summary:: Pushed to release-3.x (873baf5)