Ignore a specific six-related import warning on Python 3.10 in tests.

 






 

 


  Review Request #11930
  —
  Created Jan. 12, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  chipx86
 









 
 

  Djblets
 









 
 

  release-2.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
The version of six in all versions of Django can trigger the following

ImportWarning on Python 3.10:


_SixMetaPathImporter.find_spec() not found; falling back to
find_module()



This wasn't an issue with the old test runner, but is being hit in

pytest, causing tests to fail.


The simplest solution, unfortunately, is just to filter this out in

assertWarns. This implements that filter, fixing those tests.

 








  


 
 

  
Unit tests pass on all supported versions of Python.

 







 









 





  








 




 







   

    
    
Changes between revision 1 and 2



    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Ignore a specific six-related import warning on Python 3.10 in tests.
     
The version of `six` in all versions of Django can trigger the following
`ImportWarning` on Python 3.10:

    _SixMetaPathImporter.find_spec() not found; falling back to
    find_module()

This wasn't an issue with the old test runner, but is being hit in
`pytest`, causing tests to fail.

The simplest solution, unfortunately, is just to filter this out in
`assertWarns`. This implements that filter, fixing those tests.

    

   
  		
  4d3a85b276b9ea11fd34e7af2b792eedf9124c53
  Christian Hammond
 


 
  
 
 
  
   
    

     Ignore a specific six-related import warning on Python 3.10 in tests.
     
The version of `six` in all versions of Django can trigger the following
`ImportWarning` on Python 3.10:

    _SixMetaPathImporter.find_spec() not found; falling back to
    find_module()

This wasn't an issue with the old test runner, but is being hit in
`pytest`, causing tests to fail.

The simplest solution, unfortunately, is just to filter this out in
`assertWarns`. This implements that filter, fixing those tests.

    

   
  		
  cbf3902ae86bf4f1c95df8c1101950f8b2ac1e29
  Christian Hammond
 




    


    
    

   

  

 









 

  

   
    

     
      
      djblets/testing/testcases.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...