Summary:

Ignore a specific six-related import warning on Python 3.10 in tests.

Review Request #11930 — Created Jan. 12, 2022 and submitted Jan. 14, 2022, 3:30 a.m.

Information
Owner:	chipx86
Repository:	Djblets
Branch:	release-2.x
Bugs:
Depends On:
Reviewers
Groups:	djblets
People:

Description

The version of six in all versions of Django can trigger the following
ImportWarning on Python 3.10:

_SixMetaPathImporter.find_spec() not found; falling back to
find_module()

This wasn't an issue with the old test runner, but is being hit in
pytest, causing tests to fail.

The simplest solution, unfortunately, is just to filter this out in
assertWarns. This implements that filter, fixing those tests.

Testing Done

Unit tests pass on all supported versions of Python.

Commits

Summary
	Ignore a specific six-related import warning on Python 3.10 in tests.

Screenshots

Issues

Description	From	Last Updated
W605 invalid escape sequence '\)'	reviewbot	Jan. 12, 2022, 11:28 p.m.
W605 invalid escape sequence '\('	reviewbot	Jan. 12, 2022, 11:29 p.m.
W605 invalid escape sequence '\('	reviewbot	Jan. 12, 2022, 11:28 p.m.
W605 invalid escape sequence '\)'	reviewbot	Jan. 12, 2022, 11:28 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/testing/testcases.py (Diff revision 1)
Show all issues
```
W605 invalid escape sequence '\)'
```
djblets/testing/testcases.py (Diff revision 1)
Show all issues
```
W605 invalid escape sequence '\('
```
djblets/testing/testcases.py (Diff revision 1)
Show all issues
```
W605 invalid escape sequence '\('
```
djblets/testing/testcases.py (Diff revision 1)
Show all issues
```
W605 invalid escape sequence '\)'
```

Change Summary:

Marked the regex strings as raw strings.

Commits:

	Summary
-		Ignore a specific six-related import warning on Python 3.10 in tests.
+		Ignore a specific six-related import warning on Python 3.10 in tests.

Diff:

Revision 2 (+32)

djblets/testing/testcases.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.x (f7017bb)

Loading...