Summary

Ignore a specific six-related import warning on Python 3.10 in tests.

Review Request #11930 — Created Jan. 12, 2022 and submitted Jan. 14, 2022, 3:30 a.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-2.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

The version of six in all versions of Django can trigger the following
ImportWarning on Python 3.10:

_SixMetaPathImporter.find_spec() not found; falling back to
find_module()

This wasn't an issue with the old test runner, but is being hit in
pytest, causing tests to fail.

The simplest solution, unfortunately, is just to filter this out in
assertWarns. This implements that filter, fixing those tests.

Testing Done

Unit tests pass on all supported versions of Python.

Commits

Summary	ID
Ignore a specific six-related import warning on Python 3.10 in tests. The version of `six` in all versions of Django can trigger the following `ImportWarning` on Python 3.10: _SixMetaPathImporter.find_spec() not found; falling back to find_module() This wasn't an issue with the old test runner, but is being hit in `pytest`, causing tests to fail. The simplest solution, unfortunately, is just to filter this out in `assertWarns`. This implements that filter, fixing those tests.	cbf3902ae86bf4f1c95df8c1101950f8b2ac1e29

Summary

Ignore a specific six-related import warning on Python 3.10 in tests.

The version of `six` in all versions of Django can trigger the following `ImportWarning` on Python 3.10: _SixMetaPathImporter.find_spec() not found; falling back to find_module() This wasn't an issue with the old test runner, but is being hit in `pytest`, causing tests to fail. The simplest solution, unfortunately, is just to filter this out in `assertWarns`. This implements that filter, fixing those tests.

cbf3902ae86bf4f1c95df8c1101950f8b2ac1e29

Issues

Description	From	Last Updated
W605 invalid escape sequence '\)'	reviewbot	Jan. 12, 2022, 11:28 p.m.
W605 invalid escape sequence '\('	reviewbot	Jan. 12, 2022, 11:29 p.m.
W605 invalid escape sequence '\('	reviewbot	Jan. 12, 2022, 11:28 p.m.
W605 invalid escape sequence '\)'	reviewbot	Jan. 12, 2022, 11:28 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/testing/testcases.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W605 invalid escape sequence '\)'
```
djblets/testing/testcases.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W605 invalid escape sequence '\('
```
djblets/testing/testcases.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W605 invalid escape sequence '\('
```
djblets/testing/testcases.py (Diff revision 1)
The issue has been resolved. Show all issues
```
W605 invalid escape sequence '\)'
```

Change Summary:

Marked the regex strings as raw strings.

Commits:

	Summary	ID
	Ignore a specific six-related import warning on Python 3.10 in tests. The version of `six` in all versions of Django can trigger the following `ImportWarning` on Python 3.10: _SixMetaPathImporter.find_spec() not found; falling back to find_module() This wasn't an issue with the old test runner, but is being hit in `pytest`, causing tests to fail. The simplest solution, unfortunately, is just to filter this out in `assertWarns`. This implements that filter, fixing those tests.	4d3a85b276b9ea11fd34e7af2b792eedf9124c53
	Ignore a specific six-related import warning on Python 3.10 in tests. The version of `six` in all versions of Django can trigger the following `ImportWarning` on Python 3.10: _SixMetaPathImporter.find_spec() not found; falling back to find_module() This wasn't an issue with the old test runner, but is being hit in `pytest`, causing tests to fail. The simplest solution, unfortunately, is just to filter this out in `assertWarns`. This implements that filter, fixing those tests.	cbf3902ae86bf4f1c95df8c1101950f8b2ac1e29

Diff:

Revision 2 (+32)

Show changes

djblets/testing/testcases.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.x (f7017bb)