Summary

Add and use backports of Django's arg spec functions.

Review Request #11928 — Created Jan. 12, 2022 and submitted Jan. 14, 2022, 3:30 a.m.

Information

Owner

chipx86

Repository

Djblets

Branch

release-2.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

We have some deprecated uses of inspect.getargspec(), which has long
since been replaced by inspect.getfullargspec and inspect.Signature.

Most of our uses in Djblets (and Review Board) check for the same few
things (presence of **kwargs, specific parameters, etc.), and
fortunately Django has some nice utility methods in
django.utils.inspect for these purposes. These were introduced in
Django 1.8, and since Djblets 2.x supports Django 1.6, we can't import
them directly.

This change adds a compat module for django.utils.inspect
(djblets.util.compat.django.utils.inspect), and switches our code to
using it.

It also updates the deprecation warning for one of the uses to use our
deprecation classes.

Testing Done

All unit tests pass on all versions of Django and Python.

Commits

Summary	ID
Add and use backports of Django's arg spec functions. We have some deprecated uses of `inspect.getargspec()`, which has long since been replaced by `inspect.getfullargspec` and `inspect.Signature`. Most of our uses in Djblets (and Review Board) check for the same few things (presence of ``**kwargs``, specific parameters, etc.), and fortunately Django has some nice utility methods in `django.utils.inspect` for these purposes. These were introduced in Django 1.8, and since Djblets 2.x supports Django 1.6, we can't import them directly. This change adds a compat module for `django.utils.inspect` (`djblets.util.compat.django.utils.inspect`), and switches our code to using it. It also updates the deprecation warning for one of the uses to use our deprecation classes.	0b58896a9e46de2106b87f637005478e9a1bee4e

Summary

Add and use backports of Django's arg spec functions.

We have some deprecated uses of `inspect.getargspec()`, which has long since been replaced by `inspect.getfullargspec` and `inspect.Signature`. Most of our uses in Djblets (and Review Board) check for the same few things (presence of ``**kwargs``, specific parameters, etc.), and fortunately Django has some nice utility methods in `django.utils.inspect` for these purposes. These were introduced in Django 1.8, and since Djblets 2.x supports Django 1.6, we can't import them directly. This change adds a compat module for `django.utils.inspect` (`djblets.util.compat.django.utils.inspect`), and switches our code to using it. It also updates the deprecation warning for one of the uses to use our deprecation classes.

0b58896a9e46de2106b87f637005478e9a1bee4e

Issues

Description	From	Last Updated
E303 too many blank lines (2)	reviewbot	Jan. 12, 2022, 10:26 p.m.
E303 too many blank lines (2)	reviewbot	Jan. 12, 2022, 10:26 p.m.
E303 too many blank lines (2)	reviewbot	Jan. 12, 2022, 10:26 p.m.
E303 too many blank lines (2)	reviewbot	Jan. 12, 2022, 10:26 p.m.
E303 too many blank lines (2)	reviewbot	Jan. 12, 2022, 10:26 p.m.
E303 too many blank lines (2)	reviewbot	Jan. 12, 2022, 10:26 p.m.

flake8 failed.

JSHint passed.

flake8

djblets/util/compat/django/utils/inspect.py (Diff revision 1)
Show all issues
```
E303 too many blank lines (2)
```
djblets/util/compat/django/utils/inspect.py (Diff revision 1)
Show all issues
```
E303 too many blank lines (2)
```
djblets/util/compat/django/utils/inspect.py (Diff revision 1)
Show all issues
```
E303 too many blank lines (2)
```
djblets/util/compat/django/utils/inspect.py (Diff revision 1)
Show all issues
```
E303 too many blank lines (2)
```
djblets/util/compat/django/utils/inspect.py (Diff revision 1)
Show all issues
```
E303 too many blank lines (2)
```
djblets/util/compat/django/utils/inspect.py (Diff revision 1)
Show all issues
```
E303 too many blank lines (2)
```

Change Summary:

Removed extra blank lines.

Commits:

	Summary	ID
	Add and use backports of Django's arg spec functions. We have some deprecated uses of `inspect.getargspec()`, which has long since been replaced by `inspect.getfullargspec` and `inspect.Signature`. Most of our uses in Djblets (and Review Board) check for the same few things (presence of ``**kwargs``, specific parameters, etc.), and fortunately Django has some nice utility methods in `django.utils.inspect` for these purposes. These were introduced in Django 1.8, and since Djblets 2.x supports Django 1.6, we can't import them directly. This change adds a compat module for `django.utils.inspect` (`djblets.util.compat.django.utils.inspect`), and switches our code to using it. It also updates the deprecation warning for one of the uses to use our deprecation classes.	601555f64c96ecbcfe467afaeef787dff730394b
	Add and use backports of Django's arg spec functions. We have some deprecated uses of `inspect.getargspec()`, which has long since been replaced by `inspect.getfullargspec` and `inspect.Signature`. Most of our uses in Djblets (and Review Board) check for the same few things (presence of ``**kwargs``, specific parameters, etc.), and fortunately Django has some nice utility methods in `django.utils.inspect` for these purposes. These were introduced in Django 1.8, and since Djblets 2.x supports Django 1.6, we can't import them directly. This change adds a compat module for `django.utils.inspect` (`djblets.util.compat.django.utils.inspect`), and switches our code to using it. It also updates the deprecation warning for one of the uses to use our deprecation classes.	0b5c6c2737a5ebc4faf0a78d842cb34d5b2af6d0

Diff:

Revision 2 (+368 -10)

Show changes

	djblets/extensions/templatetags/djblets_extensions.py
	djblets/util/decorators.py
	djblets/util/compat/django/utils/inspect.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Change Summary:

Updated for the new usage of getargspec for middleware.

Commits:

	Summary	ID
	Add and use backports of Django's arg spec functions. We have some deprecated uses of `inspect.getargspec()`, which has long since been replaced by `inspect.getfullargspec` and `inspect.Signature`. Most of our uses in Djblets (and Review Board) check for the same few things (presence of ``**kwargs``, specific parameters, etc.), and fortunately Django has some nice utility methods in `django.utils.inspect` for these purposes. These were introduced in Django 1.8, and since Djblets 2.x supports Django 1.6, we can't import them directly. This change adds a compat module for `django.utils.inspect` (`djblets.util.compat.django.utils.inspect`), and switches our code to using it. It also updates the deprecation warning for one of the uses to use our deprecation classes.	0b5c6c2737a5ebc4faf0a78d842cb34d5b2af6d0
	Add and use backports of Django's arg spec functions. We have some deprecated uses of `inspect.getargspec()`, which has long since been replaced by `inspect.getfullargspec` and `inspect.Signature`. Most of our uses in Djblets (and Review Board) check for the same few things (presence of ``**kwargs``, specific parameters, etc.), and fortunately Django has some nice utility methods in `django.utils.inspect` for these purposes. These were introduced in Django 1.8, and since Djblets 2.x supports Django 1.6, we can't import them directly. This change adds a compat module for `django.utils.inspect` (`djblets.util.compat.django.utils.inspect`), and switches our code to using it. It also updates the deprecation warning for one of the uses to use our deprecation classes.	0b58896a9e46de2106b87f637005478e9a1bee4e

Diff:

Revision 3 (+382 -20)

Show changes

	djblets/extensions/extension.py
	djblets/extensions/templatetags/djblets_extensions.py
	djblets/util/decorators.py
	djblets/util/compat/django/utils/inspect.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Status: Closed (submitted)

Change Summary:

Pushed to release-2.x (6fec0c2)