Update djblets for future Django deprecations.

 






 

 


  Review Request #11921
  —
  Created Jan. 10, 2022 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  Djblets
 









 
 

  release-3.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  djblets
 









 
 

  
 






 








 





  


 
 

  
This change updates the Djblets codebase for some upcoming changes to

Django:


    

  • The authenticate method in authentication backends needs to take the
    
  request as the first positional argument.
    • 

  • Admin site URLs are now added directly in the url() method instead
    
  of through include(). The Djblets impact here is in loading admin
    
  URLs defined by extensions.
    • 


 








  


 
 

  
Ran unit tests and saw no more deprecation warnings.

 







 









 





  








 




 







   

    
    
Diff Revision 1


This is not the most recent revision of the diff. The latest diff is revision 2. See what's changed.

    

 

 

 

 
orig
1
2

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    

     Update djblets for future Django deprecations.
     
This change updates the Djblets codebase for some upcoming changes to
Django:

- `User.is_anonymous` and `User.is_authenticated` have been changed to
  be properties rather than methods.
- The `authenticate` method in authentication backends needs to take the
  request as the first positional argument.
- Admin site URLs are now added directly in the `url()` method instead
  of through `include()`. The Djblets impact here is in loading admin
  URLs defined by extensions.

Testing Done:
Ran unit tests and saw no more deprecation warnings.

    

   
  		
  2b7e3239ca5690b38d28a292673636fe812d72e3
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      djblets/auth/ratelimit.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/datagrid/grids.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/extensions/manager.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/gravatars/__init__.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/privacy/consent/forms.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/privacy/consent/views.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/webapi/decorators.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/webapi/auth/backends/api_tokens.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/webapi/auth/backends/base.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/webapi/auth/backends/oauth2_tokens.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/webapi/resources/base.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/webapi/resources/user.py
     
    

   
  

 



 

  

   
    

     
      
      djblets/webapi/testing/resources.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...