Summary

Update djblets for future Django deprecations.

Review Request #11921 — Created Jan. 10, 2022 and submitted Jan. 13, 2022, 8:41 a.m.

Information

Owner

david

Repository

Djblets

Branch

release-3.x

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

This change updates the Djblets codebase for some upcoming changes to
Django:

The authenticate method in authentication backends needs to take the
request as the first positional argument.
Admin site URLs are now added directly in the url() method instead
of through include(). The Djblets impact here is in loading admin
URLs defined by extensions.

Testing Done

Ran unit tests and saw no more deprecation warnings.

Commits

Summary	ID
Update djblets for future Django deprecations. This change updates the Djblets codebase for some upcoming changes to Django: - `User.is_anonymous` and `User.is_authenticated` have been changed to be properties rather than methods. - The `authenticate` method in authentication backends needs to take the request as the first positional argument. - Admin site URLs are now added directly in the `url()` method instead of through `include()`. The Djblets impact here is in loading admin URLs defined by extensions. Testing Done: Ran unit tests and saw no more deprecation warnings.	3b2d6325c81823e65feb6bf0c1fb61cc272485fb

Summary

Update djblets for future Django deprecations.

This change updates the Djblets codebase for some upcoming changes to Django: - `User.is_anonymous` and `User.is_authenticated` have been changed to be properties rather than methods. - The `authenticate` method in authentication backends needs to take the request as the first positional argument. - Admin site URLs are now added directly in the `url()` method instead of through `include()`. The Djblets impact here is in loading admin URLs defined by extensions. Testing Done: Ran unit tests and saw no more deprecation warnings.

3b2d6325c81823e65feb6bf0c1fb61cc272485fb

Issues

Description	From	Last Updated
This will need to land for 3.x, since 2.x supports Django 1.6, which expects is_{anonymous,authenticated} to be methods.	chipx86	Jan. 11, 2022, 8:25 a.m.
Your latest revision undid all the is_{anonymous,authenticated} changes.	chipx86	Jan. 12, 2022, 11:28 a.m.
Missing , optional	chipx86	Jan. 11, 2022, 8:25 a.m.
While here, can you add the missing **kwargs?	chipx86	Jan. 13, 2022, 8:38 a.m.

flake8 passed.

JSHint passed.

Ship it!

Show all issues

This will need to land for 3.x, since 2.x supports Django 1.6, which expects is_{anonymous,authenticated} to be methods.

djblets/webapi/auth/backends/api_tokens.py (Diff revision 1)
Show all issues
```
Missing , optional
```

Commits:

	Summary	ID
	Update djblets for future Django deprecations. This change updates the Djblets codebase for some upcoming changes to Django: - `User.is_anonymous` and `User.is_authenticated` have been changed to be properties rather than methods. - The `authenticate` method in authentication backends needs to take the request as the first positional argument. - Admin site URLs are now added directly in the `url()` method instead of through `include()`. The Djblets impact here is in loading admin URLs defined by extensions. Testing Done: Ran unit tests and saw no more deprecation warnings.	2b7e3239ca5690b38d28a292673636fe812d72e3
	Update djblets for future Django deprecations. This change updates the Djblets codebase for some upcoming changes to Django: - `User.is_anonymous` and `User.is_authenticated` have been changed to be properties rather than methods. - The `authenticate` method in authentication backends needs to take the request as the first positional argument. - Admin site URLs are now added directly in the `url()` method instead of through `include()`. The Djblets impact here is in loading admin URLs defined by extensions. Testing Done: Ran unit tests and saw no more deprecation warnings.	3b2d6325c81823e65feb6bf0c1fb61cc272485fb

Branch:

-	release-2.x
+	release-3.x

Diff:

Revision 2 (+22 -12)

Show changes

	djblets/extensions/manager.py
	djblets/webapi/auth/backends/api_tokens.py
	djblets/webapi/auth/backends/oauth2_tokens.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Show all issues

Your latest revision undid all the is_{anonymous,authenticated} changes.

chipx86 Jan. 11, 2022, 11:58 p.m.

Oh, saw the other change. Maybe just the description needs to be changed?

chipx86 Jan. 12, 2022, midnight
```
Scratch that. That was in Review Board.
```

david Jan. 12, 2022, 11:15 a.m.

Huh. That's... I don't know how that happened.

david Jan. 12, 2022, 11:28 a.m.

Aha. You'd already done that on release-3.x a while ago.

chipx86 Jan. 12, 2022, 4:34 p.m.

Wait, I did? Wow.

I don't even remember.

Description:

		This change updates the Djblets codebase for some upcoming changes to
		Django:

~		`User.is_anonymous` and `User.is_authenticated` have been changed to be properties rather than methods.
~		The `authenticate` method in authentication backends needs to take the request as the first positional argument.
	~	The `authenticate` method in authentication backends needs to take the request as the first positional argument.
	~	Admin site URLs are now added directly in the `url()` method instead of through `include()`. The Djblets impact here is in loading admin URLs defined by extensions.
-		Admin site URLs are now added directly in the `url()` method instead of through `include()`. The Djblets impact here is in loading admin URLs defined by extensions.

Ship it!

djblets/webapi/auth/backends/api_tokens.py (Diff revision 2)

Show all issues

While here, can you add the missing **kwargs?

Status: Closed (submitted)

Change Summary:

Pushed to release-3.x (4af2d35)