Update djblets for future Django deprecations.
Review Request #11921 — Created Jan. 10, 2022 and submitted
Information | |
---|---|
david | |
Djblets | |
release-3.x | |
Reviewers | |
djblets | |
This change updates the Djblets codebase for some upcoming changes to
Django:
- The
authenticate
method in authentication backends needs to take the
request as the first positional argument. - Admin site URLs are now added directly in the
url()
method instead
of throughinclude()
. The Djblets impact here is in loading admin
URLs defined by extensions.
Ran unit tests and saw no more deprecation warnings.
Summary | |
---|---|
Description | From | Last Updated |
---|---|---|
This will need to land for 3.x, since 2.x supports Django 1.6, which expects is_{anonymous,authenticated} to be methods. |
|
|
Your latest revision undid all the is_{anonymous,authenticated} changes. |
|
|
Missing , optional |
|
|
While here, can you add the missing **kwargs? |
|
Commits: |
|
|||||||||
---|---|---|---|---|---|---|---|---|---|---|
Branch: |
|
|||||||||
Diff: |
Revision 2 (+22 -12) |
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
Description: |
|
---|
-
-
djblets/webapi/auth/backends/api_tokens.py (Diff revision 2) While here, can you add the missing
**kwargs
?