david got a fish trophy!
Update to modern MIDDLEWARE setting.
Review Request #11911 — Created Jan. 7, 2022 and submitted
Django 1.10 introduced some changes to the way that middleware works.
Instead of having separate
methods, middleware is now a callable which chains together. This
simplifies most cases to the point where most middleware can be
implemented as a nested function rather than a class. Opting into this
new behavior is done by changing the settings key from
This change updates Review Board to use the new setting, and the
built-in middlewares to use the new pattern. As part of this, I needed
to upgrade django-cors-headers to a newer version. I've chosen the last
version that still supports Python 2.7.
- Ran unit tests.
- Smoke tested the Review Board UI.
Seems the class should keep the bulk of the docstring in this case.
Revision 2 (+432 -166)
Checks run (2 succeeded)