david got a fish trophy!

Summary

Update to modern MIDDLEWARE setting.

Review Request #11911 — Created Jan. 7, 2022 and submitted Jan. 12, 2022, 11:14 a.m.

Information

Owner

david

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Django 1.10 introduced some changes to the way that middleware works.

Instead of having separate process_request and process_response

methods, middleware is now a callable which chains together. This

simplifies most cases to the point where most middleware can be

implemented as a nested function rather than a class. Opting into this

new behavior is done by changing the settings key from

MIDDLEWARE_CLASSES to MIDDLEWARE.
This change updates Review Board to use the new setting, and the

built-in middlewares to use the new pattern. As part of this, I needed

to upgrade django-cors-headers to a newer version. I've chosen the last

version that still supports Python 2.7.

Testing Done


Ran unit tests.
Smoke tested the Review Board UI.

Commits

Summary	ID
Update to modern MIDDLEWARE setting. Django 1.10 introduced some changes to the way that middleware works. Instead of having separate `process_request` and `process_response` methods, middleware is now a callable which chains together. This simplifies most cases to the point where most middleware can be implemented as a nested function rather than a class. Opting into this new behavior is done by changing the settings key from `MIDDLEWARE_CLASSES` to `MIDDLEWARE`. This change updates Review Board to use the new setting, and the built-in middlewares to use the new pattern. As part of this, I needed to upgrade django-cors-headers to a newer version. I've chosen the last version that still supports Python 2.7. Testing Done: - Ran unit tests. - Smoke tested the Review Board UI.	9d3c3a06d65092298f97980c4ba8b0d875232d25

Summary

Update to modern MIDDLEWARE setting.

Django 1.10 introduced some changes to the way that middleware works. Instead of having separate `process_request` and `process_response` methods, middleware is now a callable which chains together. This simplifies most cases to the point where most middleware can be implemented as a nested function rather than a class. Opting into this new behavior is done by changing the settings key from `MIDDLEWARE_CLASSES` to `MIDDLEWARE`. This change updates Review Board to use the new setting, and the built-in middlewares to use the new pattern. As part of this, I needed to upgrade django-cors-headers to a newer version. I've chosen the last version that still supports Python 2.7. Testing Done: - Ran unit tests. - Smoke tested the Review Board UI.

9d3c3a06d65092298f97980c4ba8b0d875232d25

Issues

Description	From	Last Updated
Seems the class should keep the bulk of the docstring in this case.	chipx86	Jan. 10, 2022, 1:05 p.m.

flake8 passed.

JSHint passed.

reviewboard/site/middleware.py (Diff revision 1)

The issue has been resolved. Show all issues

Seems the class should keep the bulk of the docstring in this case.

Commits:

	Summary	ID
	Update to modern MIDDLEWARE setting. Django 1.10 introduced some changes to the way that middleware works. Instead of having separate `process_request` and `process_response` methods, middleware is now a callable which chains together. This simplifies most cases to the point where most middleware can be implemented as a nested function rather than a class. Opting into this new behavior is done by changing the settings key from `MIDDLEWARE_CLASSES` to `MIDDLEWARE`. This change updates Review Board to use the new setting, and the built-in middlewares to use the new pattern. As part of this, I needed to upgrade django-cors-headers to a newer version. I've chosen the last version that still supports Python 2.7. Testing Done: - Ran unit tests. - Smoke tested the Review Board UI.	00ee85d7784228ccb295e110a56bea455a6b3763
	Update to modern MIDDLEWARE setting. Django 1.10 introduced some changes to the way that middleware works. Instead of having separate `process_request` and `process_response` methods, middleware is now a callable which chains together. This simplifies most cases to the point where most middleware can be implemented as a nested function rather than a class. Opting into this new behavior is done by changing the settings key from `MIDDLEWARE_CLASSES` to `MIDDLEWARE`. This change updates Review Board to use the new setting, and the built-in middlewares to use the new pattern. As part of this, I needed to upgrade django-cors-headers to a newer version. I've chosen the last version that still supports Python 2.7. Testing Done: - Ran unit tests. - Smoke tested the Review Board UI.	9d3c3a06d65092298f97980c4ba8b0d875232d25

Diff:

Revision 2 (+432 -166)

Show changes

	reviewboard/dependencies.py
	reviewboard/settings.py
	reviewboard/accounts/middleware.py
	reviewboard/accounts/tests/test_update_last_login_middleware.py
	reviewboard/accounts/tests/test_x509_auth_middleware.py
	reviewboard/admin/middleware.py
	reviewboard/site/middleware.py
	reviewboard/site/tests.py

Checks run (2 succeeded)

flake8 passed.

JSHint passed.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-4.0.x (e58b0ce)