Summary:

[WIP]: Optimal version for allowing collapsed entries to fetch data on request

Review Request #11889 — Created Dec. 6, 2021 and updated Dec. 6, 2021, 10:57 p.m.

Information
Owner:	cynthia
Repository:	Review Board
Branch:	master
Bugs:
Depends On:
Reviewers
Groups:	reviewboard
People:

Description

This is a modified version of the working lazy collapsed project

based on Christian's suggestions in the review request here:

https://reviews.reviewboard.org/r/11886/.
The only difference is that instead of checking the entry's html attributes,

we keep a state on the entry model indicating if the entry has been loaded,

which would be part of the initial model data on the page. If loaded,do 

nothing.If not then load it by calling the function "fetchEntryUpdates"

which can trigger an immediate update to load the content of an entry.
TODO: Set the "loaded" state of an expand entry to true.

Testing Done

TODO: Require writing tests for entry model for the newly "loaded" added state.

Commits

Summary	Author
add console log for debug	Your Name
load the collapsed entry info, finally get it working	Your Name
finalize project	Your Name
code clean up	Your Name
remove white spaces	Your Name
remove white space	Your Name
review bot issues	Your Name
review bot issues	Your Name
remove white spaces	Your Name
remove white spaces	Your Name
Address the comments and issues opened by David on the review request	Your Name
remove white spaces	Your Name
remove white spaces	Your Name
change test	Your Name
address issues opened	Your Name
remove space	Your Name
initial setup for new loaded state in entry model	Your Name
change comment	Your Name

Screenshots

Issues

Description	From	Last Updated

flake8 passed.

JSHint passed.

Summary:

-	WIP: Allow collapsed entries to fetch data on request - optimal version
+	[WIP]: Optimal version for allowing collapsed entries to fetch data on request

Description:

~		This is a modified version based on Christian's suggestions in review
~		request here: https://reviews.reviewboard.org/r/11886/.
	~	This is a modified version of the working lazy collapsed project
	~	based on Christian's suggestions in the review request here:
	+	https://reviews.reviewboard.org/r/11886/.

~		TODO: Set the "loaded" state of an expand entry to true.
~
~		Review Board will collapse old reviews to streamline information.
~		While the data is visually hidden it will still be computed
~		and loaded to the client which can cause slowness.
	~	The only difference is that instead of checking the entry's html attributes,
	~	we keep a state on the entry model indicating if the entry has been loaded,
	~	which would be part of the initial model data on the page. If loaded,do
	~	nothing.If not then load it by calling the function "fetchEntryUpdates"
	~	which can trigger an immediate update to load the content of an entry.

~		This change makes collapsed review entries get sent to the client
	~	TODO: Set the "loaded" state of an expand entry to true.
-		empty, then fetch its content on request. When they expand the entry,
-		we first check if this entry already has content loaded.
-		Instead of checking the entry's html attributes, we keep a state on the
-		entry model indicating if the entry has been loaded, which would be part
-		of the initial model data on the page. If loaded, have this function do
-		nothing.If not then load it by using the new function "fetchEntryUpdates".
-		which can trigger an immediate update to load the content of an entry.
-		This function uses and extends the machinery related to "page pending updates"
-		In order to make it feel even snappier, I add a mouseover event listener
-		on the expand button and the expand all button. We start to pull down information
-		before they even lift the mouse button.
-
-		Only load the entry content if the entry is of type "review". Without this restriction,
-		when they click the expand all button, the entry of type "initial_status_updates" or
-		"changedesc"also tries to check whether it has content which causes an error.

Testing Done:

~		Require writing tests for entry model for the newly added state.
	~	TODO: Require writing tests for entry model for the newly "loaded" added state.

Commits:

	Summary	Author
-	add console log for debug	Your Name
-	load the collapsed entry info, finally get it working	Your Name
-	finalize project	Your Name
-	code clean up	Your Name
-	remove white spaces	Your Name
-	remove white space	Your Name
-	review bot issues	Your Name
-	review bot issues	Your Name
-	remove white spaces	Your Name
-	remove white spaces	Your Name
-	Address the comments and issues opened by David on the review request	Your Name
-	remove white spaces	Your Name
-	remove white spaces	Your Name
-	change test	Your Name
-	address issues opened	Your Name
-	remove space	Your Name
-	initial setup for new loaded state in entry model	Your Name
+	add console log for debug	Your Name
+	load the collapsed entry info, finally get it working	Your Name
+	finalize project	Your Name
+	code clean up	Your Name
+	remove white spaces	Your Name
+	remove white space	Your Name
+	review bot issues	Your Name
+	review bot issues	Your Name
+	remove white spaces	Your Name
+	remove white spaces	Your Name
+	Address the comments and issues opened by David on the review request	Your Name
+	remove white spaces	Your Name
+	remove white spaces	Your Name
+	change test	Your Name
+	address issues opened	Your Name
+	remove space	Your Name
+	initial setup for new loaded state in entry model	Your Name
+	change comment	Your Name

Diff:

Revision 2 (+2416 -1942)

Show changes

	reviewboard/staticbundles.py
	reviewboard/static/rb/js/reviewRequestPage/models/entryModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/models/reviewRequestPageModel.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/entryView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/reviewRequestPageView.es6.js
	reviewboard/static/rb/js/reviewRequestPage/views/tests/entryViewTests.es6.js
	reviewboard/templates/reviews/entries/_review_body.html
	reviewboard/templates/reviews/entries/entry.js

Checks run (2 succeeded)

flake8 passed.

JSHint passed.