Add the `rbt review` command.

 






 

 


  Review Request #11883
  —
  Created Nov. 24, 2021 and submitted  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  david
 









 
 

  RBTools
 









 
 

  master
 









 
 

  
 









 
 

  11882
 






 




 

  

   Reviewers

  





 
 

  rbtools
 









 
 

  
 






 








 





  


 
 

  
This change adds a new RBTools command for creating and editing reviews.

This uses the new MultiCommand subclass in order to provide a variety

of functionality within a single command:


    

  • rbt review edit will create or edit a draft review.
    • 

  • rbt review discard will discard a draft review.
    • 

  • rbt review publish will publish a draft review.
    • 

  • rbt review add-diff-comment will add a new diff comment.
    • 

  • rbt review add-file-attachment-comment will add a new file
    
  attachment comment.
    • 

  • rbt review add-general-comment will add a new general comment.
    • 



Based on work by Anahita Mohapatra at /r/11502/.

 








  


 
 

  
Ran through manual test cases for each of the review subcommands:

- Creating a new review with various content.

- Editing an existing draft review.

- Creating general comments (both markdown and plain)

- Creating file attachment comments (both markdown and plain)

- Creating diff comments (markdown and plain, single- and multi-line).

- Discarding a draft review.

- Publishing a draft review.

- Tested validation and error handling (file attachment IDs, diff

  filenames, diff revisions)

 







 









 





  








 




 







   

    
    
Changes between revision 2 and 3



    

 

 

 

 
orig
1
2
3
4

 



    


    

      
Commits

      

 

 

  
   
  
  Summary
  ID
  Author
 



 
  
 
 
  
   
    

     Add the `rbt review` command.
     
This change adds a new RBTools command for creating and editing reviews.
This uses the new `MultiCommand` subclass in order to provide a variety
of functionality within a single command:

- `rbt review edit` will create or edit a draft review.
- `rbt review discard` will discard a draft review.
- `rbt review publish` will publish a draft review.
- `rbt review add-diff-comment` will add a new diff comment.
- `rbt review add-file-attachment-comment` will add a new file
  attachment comment.
- `rbt review add-general-comment` will add a new general comment.

Based on work by Anahita Mohapatra at /r/11502/.

Testing Done:
Ran through manual test cases for each of the review subcommands:
- Creating a new review with various content.
- Editing an existing draft review.
- Creating general comments (both markdown and plain)
- Creating file attachment comments (both markdown and plain)
- Creating diff comments (markdown and plain, single- and multi-line).
- Discarding a draft review.
- Publishing a draft review.
- Tested validation and error handling (file attachment IDs, diff
  filenames, diff revisions)

    

   
  		
  1c58b8cf688041a757331156a000d57efab3afa2
  David Trowbridge
 


 
  
 
 
  
   
    

     Add the `rbt review` command.
     
This change adds a new RBTools command for creating and editing reviews.
This uses the new `MultiCommand` subclass in order to provide a variety
of functionality within a single command:

- `rbt review edit` will create or edit a draft review.
- `rbt review discard` will discard a draft review.
- `rbt review publish` will publish a draft review.
- `rbt review add-diff-comment` will add a new diff comment.
- `rbt review add-file-attachment-comment` will add a new file
  attachment comment.
- `rbt review add-general-comment` will add a new general comment.

Based on work by Anahita Mohapatra at /r/11502/.

Testing Done:
Ran through manual test cases for each of the review subcommands:
- Creating a new review with various content.
- Editing an existing draft review.
- Creating general comments (both markdown and plain)
- Creating file attachment comments (both markdown and plain)
- Creating diff comments (markdown and plain, single- and multi-line).
- Discarding a draft review.
- Publishing a draft review.
- Tested validation and error handling (file attachment IDs, diff
  filenames, diff revisions)

    

   
  		
  fc382004cfbd87825870de4a3c33f26eafd58230
  David Trowbridge
 




    


    
    

   

  

 









 

  

   
    

     
      
      rbtools/commands/__init__.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/commands/post.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/commands/publish.py
     
    

   
  

 



 

  

   
    

     
      
      rbtools/commands/review.py
     
    

   
  

 










     

    

   

  

  

   
   Loading...