Summary

Add compat imports for collections.abc.

Review Request #11881 — Created Nov. 23, 2021 and submitted Nov. 26, 2021, 3:14 p.m.

Information

Owner

david

Repository

Djblets

Branch

master

Bugs

Depends On

Reviewers

Groups

djblets

People

Description

Python 3.10 removed a bunch of deprecated aliases for items in the
collections.abc module. Unfortunately for us, both Django 1.11 and nose
rely on these imports. This change adds a compat module that will
recreate the aliases we need.

Testing Done

Ran unit tests with Python 3.10.

Commits

Summary	ID
Add compat imports for collections.abc. Python 3.10 removed a bunch of deprecated aliases for items in the collections.abc module. Unfortunately for us, both Django 1.11 and nose rely on these imports. This change adds a compat module that will recreate the aliases we need. Testing Done: Ran unit tests with Python 3.10.	72b66d19b45cb754686c400e3b49fdbd4647705a

Issues

Description	From	Last Updated
This needs to land on release-2.x.	chipx86	Nov. 26, 2021, 3:08 p.m.
Can we duplicate the information here, where it's more likely we'll see it regularly?	chipx86	Nov. 26, 2021, 3:11 p.m.
F401 'djblets.util.compat.python.collections' imported but unused	reviewbot	Nov. 23, 2021, 10:02 a.m.
Can you add a docstring to this function, with a Version Added?	chipx86	Nov. 26, 2021, 3:10 p.m.
F401 'collections.Iterator' imported but unused	reviewbot	Nov. 23, 2021, 10:02 a.m.
F401 'djblets.util.compat.python.collections' imported but unused	reviewbot	Nov. 23, 2021, 10:02 a.m.

flake8 failed.

JSHint passed.

flake8

djblets/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
F401 'djblets.util.compat.python.collections' imported but unused
```
djblets/util/compat/python/collections.py (Diff revision 1)
The issue has been dropped. Show all issues
```
F401 'collections.Iterator' imported but unused
```
tests/runtests.py (Diff revision 1)
The issue has been dropped. Show all issues
```
F401 'djblets.util.compat.python.collections' imported but unused
```

Ship it!

The issue has been resolved. Show all issues
```
This needs to land on release-2.x.
```

djblets/__init__.py (Diff revision 1)

The issue has been resolved. Show all issues

Can we duplicate the information here, where it's more likely we'll see it regularly?

djblets/util/compat/python/collections.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Can you add a docstring to this function, with a Version Added?
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.x (5edd3ef)