Custom Admin Emoji Panel (Djblets)

Review Request #11878 — Created Nov. 20, 2021 and updated

mxwang
Djblets
release-2.x
11858
djblets

Adds a ListEditEmojiDictionaryField (inherited from Michelle Aubin's
ListEditDictionaryField class), which takes in a dictionary of values and
splits it into a tuple of (key, value1, value2, value3).

EmojiFileInput class is a subclass of FileInput, which takes in a file
upload from the user, and saves it into the context variable. In future
implementations, the get_context() method can also be used to render image
previews if the file uploaded is a valid image file.

Unit testing: Unit test suites for ListEditDictionaryField and ListEditField
Local testing: making sure the app runs property with print() statements.

Summary Author
ListEditDictionaryField Patch from Michelle Aubin.
mxiuwang
[WIP] Adding custom emojis in admin emoji dashboard.
mxiuwang
[WIP] rendering images.
mxiuwang
[WIP] Render images.
mxiuwang
Add docstring, code cleanup.
mxiuwang
Add Djblets tests.
mxiuwang
Fix automatically-raised whitespace issues.
mxiuwang
Define ListEditEmojiDictionaryField as its own class.
mxiuwang
Fix suggestions.
mxiuwang
Render emoji preview image.
mxiuwang
Fix flake8 suggestions.
mxiuwang
Description From Last Updated

Description needs to wrap with 80 chars I believe

akim.ruslanovakim.ruslanov

In testing done, mention what kind of new test was added

akim.ruslanovakim.ruslanov

The review request description and summary should also reflect what this commit does, not the work being done in Review ...

chipx86chipx86

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (93 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

Col: 87 Missing semicolon.

reviewbotreviewbot

Col: 62 Missing semicolon.

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (95 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (123 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

Col: 87 Missing semicolon.

reviewbotreviewbot

Col: 62 Missing semicolon.

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (95 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (123 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E131 continuation line unaligned for hanging indent

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

This belongs with the Review Board change, since it's really specific to Review Board's implementation. Djblets should be limited to ...

chipx86chipx86

Col: 87 Missing semicolon.

reviewbotreviewbot

Col: 62 Missing semicolon.

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (95 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (123 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E131 continuation line unaligned for hanging indent

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

Col: 87 Missing semicolon.

reviewbotreviewbot

Col: 62 Missing semicolon.

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (95 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (123 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E131 continuation line unaligned for hanging indent

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (95 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (123 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E131 continuation line unaligned for hanging indent

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (95 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E501 line too long (123 > 79 characters)

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E131 continuation line unaligned for hanging indent

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

Col: 87 Missing semicolon.

reviewbotreviewbot

Col: 62 Missing semicolon.

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E502 the backslash is redundant between brackets

reviewbotreviewbot

E203 whitespace before ','

reviewbotreviewbot

E502 the backslash is redundant between brackets

reviewbotreviewbot

E127 continuation line over-indented for visual indent

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E131 continuation line unaligned for hanging indent

reviewbotreviewbot

E502 the backslash is redundant between brackets

reviewbotreviewbot

E128 continuation line under-indented for visual indent

reviewbotreviewbot

E502 the backslash is redundant between brackets

reviewbotreviewbot

E126 continuation line over-indented for hanging indent

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

F401 'django.core.files.storage.get_storage_class' imported but unused

reviewbotreviewbot

F401 'django.core.files.storage.DefaultStorage' imported but unused

reviewbotreviewbot

F401 'django.utils.html.format_html_join' imported but unused

reviewbotreviewbot

F401 'django.utils.html.format_html' imported but unused

reviewbotreviewbot

Col: 87 Missing semicolon.

reviewbotreviewbot

Col: 62 Missing semicolon.

reviewbotreviewbot
Checks run (2 failed)
flake8 failed.
JSHint failed.

flake8

JSHint

mxwang
mxwang
Review request changed

Summary:

-ListEditDictionaryField Patch from Michelle Aubin.
+Custom Admin Emoji Panel (Djblets)

Description:

~  

[WIP] ListEditDictionaryField Patch from Michelle Aubin.

  ~

Adds a page to the admint panel which allows an admin to upload a custom emoji by uploading a name, shortcode, description, and image. These fields are editable whenever the user re-vists the page. The emoji data is loaded from, and saved into SiteConfiguration, while the image data is loaded from and saved to DefaultStorage.

  +
  +

  +
  +

  +
  +

Further work that needs to be done:

  + * Enforcing mandatory fields that user must fill out before clicking "Save", so as to not raise an error.
  + * Adding labels to the form fields, and removing the extra "name" field at the very top of the form.
  + * Rendering a preview of the emoji when loading the page (through get_context() in EmojiFileUpload).

Testing Done:

  +

Unit testing

  + Local testing

Commits:

Summary Author
-
ListEditDictionaryField Patch from Michelle Aubin.
mxiuwang
+
ListEditDictionaryField Patch from Michelle Aubin.
mxiuwang
+
[WIP] Adding custom emojis in admin emoji dashboard.
mxiuwang
+
[WIP] rendering images.
mxiuwang
+
[WIP] Render images.
mxiuwang
+
Add docstring, code cleanup.
mxiuwang
+
Add Djblets tests.
mxiuwang

Diff:

Revision 2 (+1046 -296)

Show changes

Checks run (2 failed)

flake8 failed.
JSHint failed.

flake8

JSHint

akim.ruslanov
  1. 
      
  2. Description needs to wrap with 80 chars I believe

  3. In testing done, mention what kind of new test was added

  4. 
      
mxwang
Review request changed

Description:

~  

Adds a page to the admint panel which allows an admin to upload a custom emoji by uploading a name, shortcode, description, and image. These fields are editable whenever the user re-vists the page. The emoji data is loaded from, and saved into SiteConfiguration, while the image data is loaded from and saved to DefaultStorage.

  ~

Adds a page to the admint panel which allows an admin to upload a custom emoji

  + by uploading a name, shortcode, description, and image. These fields are
  + editable whenever the user re-vists the page. The emoji data is loaded from,
  + and saved into SiteConfiguration, while the image data is loaded from and
  + saved to DefaultStorage.

   
   

   
   

   
   

Further work that needs to be done:

~   * Enforcing mandatory fields that user must fill out before clicking "Save", so as to not raise an error.
~   * Adding labels to the form fields, and removing the extra "name" field at the very top of the form.
~   * Rendering a preview of the emoji when loading the page (through get_context() in EmojiFileUpload).

  ~ * Adding labels to the form fields, and removing the extra "name" field at the
  ~ very top of the form.
  ~ * Rendering a preview of the emoji when loading the page (through get_context()
  + in EmojiFileUpload).

Commits:

Summary Author
-
ListEditDictionaryField Patch from Michelle Aubin.
mxiuwang
-
[WIP] Adding custom emojis in admin emoji dashboard.
mxiuwang
-
[WIP] rendering images.
mxiuwang
-
[WIP] Render images.
mxiuwang
-
Add docstring, code cleanup.
mxiuwang
-
Add Djblets tests.
mxiuwang
+
ListEditDictionaryField Patch from Michelle Aubin.
mxiuwang
+
[WIP] Adding custom emojis in admin emoji dashboard.
mxiuwang
+
[WIP] rendering images.
mxiuwang
+
[WIP] Render images.
mxiuwang
+
Add docstring, code cleanup.
mxiuwang
+
Add Djblets tests.
mxiuwang
+
Fix automatically-raised whitespace issues.
mxiuwang

Diff:

Revision 3 (+1062 -312)

Show changes

Checks run (2 failed)

flake8 failed.
JSHint failed.

flake8

JSHint

mxwang
mxwang
chipx86
  1. This change incorporates a lot of things from Michelle Aubin's change. It makes it hard to know what parts should land from her change and what should land from yours. Can you instead rebase your work on top of hers, only post the range of commits for your work, and mark her review request as a dependency (Depends On field)?

  2. djblets/forms/widgets.py (Diff revision 3)
     
     

    This belongs with the Review Board change, since it's really specific to Review Board's implementation. Djblets should be limited to things that are more generic and reusable.

  3. 
      
chipx86
  1. 
      
  2. The review request description and summary should also reflect what this commit does, not the work being done in Review Board. From the point of view of the Djblets code, Review Board "doesn't exist." That's the way to think about it. There's a separation.

  3. 
      
mxwang
Review request changed

Description:

~  

Adds a page to the admin panel which allows an admin to upload a custom emoji

~   by uploading a name, shortcode, description, and image. These fields are
~   editable whenever the user re-vists the page. The emoji data is loaded from,
  ~

Adds a ListEditEmojiDictionaryField (inherited from Michelle Aubin's

  ~ ListEditDictionaryField class), which takes in a dictionary of values and
  ~ splits it into a tuple of (key, value1, value2, value3).

-   and saved into SiteConfiguration, while the image data is loaded from and
-   saved to DefaultStorage.

   
~  

  ~

EmojiFileInput class is a subclass of ClearableFileInput, which takes in a

  + file upload from the user, and saves it into the context variable. In future
  + implementations, the get_context() method can also be used to render image
  + previews if the file uploaded is a valid image file.

   
   

   
   

Further work that needs to be done:

-   * Adding labels to the form fields, and removing the extra "name" field at the
-   very top of the form.
    * Rendering a preview of the emoji when loading the page (through get_context()
~   in EmojiFileUpload).

  ~ in EmojiFileUpload). Right now, the uploaded image file is being passed as a
  + bytestream, but it needs to be passed as a file or image object in order
  + to be rendered.

Commits:

Summary Author
-
ListEditDictionaryField Patch from Michelle Aubin.
mxiuwang
-
[WIP] Adding custom emojis in admin emoji dashboard.
mxiuwang
-
[WIP] rendering images.
mxiuwang
-
[WIP] Render images.
mxiuwang
-
Add docstring, code cleanup.
mxiuwang
-
Add Djblets tests.
mxiuwang
-
Fix automatically-raised whitespace issues.
mxiuwang
+
ListEditDictionaryField Patch from Michelle Aubin.
mxiuwang
+
[WIP] Adding custom emojis in admin emoji dashboard.
mxiuwang
+
[WIP] rendering images.
mxiuwang
+
[WIP] Render images.
mxiuwang
+
Add docstring, code cleanup.
mxiuwang
+
Add Djblets tests.
mxiuwang
+
Fix automatically-raised whitespace issues.
mxiuwang
+
Define ListEditEmojiDictionaryField as its own class.
mxiuwang

Diff:

Revision 4 (+1305 -333)

Show changes

Checks run (2 failed)

flake8 failed.
JSHint failed.

flake8

JSHint

mxwang
Review request changed

Commits:

Summary Author
-
ListEditDictionaryField Patch from Michelle Aubin.
mxiuwang
-
[WIP] Adding custom emojis in admin emoji dashboard.
mxiuwang
-
[WIP] rendering images.
mxiuwang
-
[WIP] Render images.
mxiuwang
-
Add docstring, code cleanup.
mxiuwang
-
Add Djblets tests.
mxiuwang
-
Fix automatically-raised whitespace issues.
mxiuwang
-
Define ListEditEmojiDictionaryField as its own class.
mxiuwang
+
[WIP] Adding custom emojis in admin emoji dashboard.
mxiuwang
+
[WIP] rendering images.
mxiuwang
+
[WIP] Render images.
mxiuwang
+
Add docstring, code cleanup.
mxiuwang
+
Add Djblets tests.
mxiuwang
+
Fix automatically-raised whitespace issues.
mxiuwang
+
Define ListEditEmojiDictionaryField as its own class.
mxiuwang

Diff:

Revision 5 (+457 -155)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Commits:

Summary Author
-
[WIP] Adding custom emojis in admin emoji dashboard.
mxiuwang
-
[WIP] rendering images.
mxiuwang
-
[WIP] Render images.
mxiuwang
-
Add docstring, code cleanup.
mxiuwang
-
Add Djblets tests.
mxiuwang
-
Fix automatically-raised whitespace issues.
mxiuwang
-
Define ListEditEmojiDictionaryField as its own class.
mxiuwang
+
[WIP] Adding custom emojis in admin emoji dashboard.
mxiuwang
+
[WIP] rendering images.
mxiuwang
+
[WIP] Render images.
mxiuwang
+
Add docstring, code cleanup.
mxiuwang
+
Add Djblets tests.
mxiuwang
+
Fix automatically-raised whitespace issues.
mxiuwang
+
Define ListEditEmojiDictionaryField as its own class.
mxiuwang
+
Fix suggestions.
mxiuwang

Diff:

Revision 6 (+420 -192)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

mxwang
mxwang
Review request changed

Commits:

Summary Author
-
[WIP] Adding custom emojis in admin emoji dashboard.
mxiuwang
-
[WIP] rendering images.
mxiuwang
-
[WIP] Render images.
mxiuwang
-
Add docstring, code cleanup.
mxiuwang
-
Add Djblets tests.
mxiuwang
-
Fix automatically-raised whitespace issues.
mxiuwang
-
Define ListEditEmojiDictionaryField as its own class.
mxiuwang
-
Fix suggestions.
mxiuwang
+
ListEditDictionaryField Patch from Michelle Aubin.
mxiuwang
+
[WIP] Adding custom emojis in admin emoji dashboard.
mxiuwang
+
[WIP] rendering images.
mxiuwang
+
[WIP] Render images.
mxiuwang
+
Add docstring, code cleanup.
mxiuwang
+
Add Djblets tests.
mxiuwang
+
Fix automatically-raised whitespace issues.
mxiuwang
+
Define ListEditEmojiDictionaryField as its own class.
mxiuwang
+
Fix suggestions.
mxiuwang
+
Render emoji preview image.
mxiuwang

Diff:

Revision 7 (+1273 -371)

Show changes

Checks run (2 failed)

flake8 failed.
JSHint failed.

flake8

JSHint

mxwang
mxwang
Review request changed

Commits:

Summary Author
-
ListEditDictionaryField Patch from Michelle Aubin.
mxiuwang
-
[WIP] Adding custom emojis in admin emoji dashboard.
mxiuwang
-
[WIP] rendering images.
mxiuwang
-
[WIP] Render images.
mxiuwang
-
Add docstring, code cleanup.
mxiuwang
-
Add Djblets tests.
mxiuwang
-
Fix automatically-raised whitespace issues.
mxiuwang
-
Define ListEditEmojiDictionaryField as its own class.
mxiuwang
-
Fix suggestions.
mxiuwang
-
Render emoji preview image.
mxiuwang
+
ListEditDictionaryField Patch from Michelle Aubin.
mxiuwang
+
[WIP] Adding custom emojis in admin emoji dashboard.
mxiuwang
+
[WIP] rendering images.
mxiuwang
+
[WIP] Render images.
mxiuwang
+
Add docstring, code cleanup.
mxiuwang
+
Add Djblets tests.
mxiuwang
+
Fix automatically-raised whitespace issues.
mxiuwang
+
Define ListEditEmojiDictionaryField as its own class.
mxiuwang
+
Fix suggestions.
mxiuwang
+
Render emoji preview image.
mxiuwang
+
Fix flake8 suggestions.
mxiuwang

Diff:

Revision 8 (+1298 -388)

Show changes

Checks run (2 failed)

flake8 failed.
JSHint failed.

flake8

JSHint

Loading...