Summary:

Custom Admin Emoji Panel (Djblets)

Review Request #11878 — Created Nov. 20, 2021 and updated Dec. 6, 2021, 10:23 p.m.

Information
Owner:	mxwang
Repository:	Djblets
Branch:	release-2.x
Bugs:
Depends On:	~~11858~~
Reviewers
Groups:	djblets
People:

Description

Adds a ListEditEmojiDictionaryField (inherited from Michelle Aubin's 

ListEditDictionaryField class), which takes in a dictionary of values and

splits it into a tuple of (key, value1, value2, value3).
EmojiFileInput class is a subclass of FileInput, which takes in a file 

upload from the user, and saves it into the context variable. In future

implementations, the get_context() method can also be used to render image 

previews if the file uploaded is a valid image file.

Testing Done

Unit testing: Unit test suites for ListEditDictionaryField and ListEditField
Local testing: making sure the app runs property with print() statements.

Commits

Summary	Author
ListEditDictionaryField Patch from Michelle Aubin.	mxiuwang
[WIP] Adding custom emojis in admin emoji dashboard.	mxiuwang
[WIP] rendering images.	mxiuwang
[WIP] Render images.	mxiuwang
Add docstring, code cleanup.	mxiuwang
Add Djblets tests.	mxiuwang
Fix automatically-raised whitespace issues.	mxiuwang
Define ListEditEmojiDictionaryField as its own class.	mxiuwang
Fix suggestions.	mxiuwang
Render emoji preview image.	mxiuwang
Fix flake8 suggestions.	mxiuwang

Screenshots

Issues

Description	From	Last Updated
Description needs to wrap with 80 chars I believe	akim.ruslanov	Dec. 5, 2021, 12:10 p.m.
In testing done, mention what kind of new test was added	akim.ruslanov	Dec. 5, 2021, 12:12 p.m.
The review request description and summary should also reflect what this commit does, not the work being done in Review …	chipx86	Dec. 5, 2021, 11:37 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:57 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:57 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:57 p.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:57 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:57 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:57 p.m.
E501 line too long (93 > 79 characters)	reviewbot	Dec. 3, 2021, 10:57 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:57 p.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:57 p.m.
Col: 87 Missing semicolon.	reviewbot	Dec. 3, 2021, 10:57 p.m.
Col: 62 Missing semicolon.	reviewbot	Dec. 3, 2021, 10:57 p.m.
W293 blank line contains whitespace	reviewbot	Dec. 5, 2021, 12:09 p.m.
W293 blank line contains whitespace	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
W293 blank line contains whitespace	reviewbot	Dec. 5, 2021, 12:09 p.m.
W291 trailing whitespace	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
W291 trailing whitespace	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 5, 2021, 12:09 p.m.
E501 line too long (95 > 79 characters)	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E501 line too long (123 > 79 characters)	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
W291 trailing whitespace	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:09 p.m.
Col: 87 Missing semicolon.	reviewbot	Dec. 5, 2021, 12:09 p.m.
Col: 62 Missing semicolon.	reviewbot	Dec. 5, 2021, 12:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:12 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:12 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:12 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:12 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:12 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:12 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:12 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:12 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 5, 2021, 12:12 p.m.
E501 line too long (95 > 79 characters)	reviewbot	Dec. 5, 2021, 12:12 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:12 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:12 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:12 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:12 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:12 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:12 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:12 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:12 p.m.
E501 line too long (123 > 79 characters)	reviewbot	Dec. 5, 2021, 12:12 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:13 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:13 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:13 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:13 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:13 p.m.
E131 continuation line unaligned for hanging indent	reviewbot	Dec. 5, 2021, 12:13 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:13 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:13 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:13 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:13 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:13 p.m.
This belongs with the Review Board change, since it's really specific to Review Board's implementation. Djblets should be limited to …	chipx86	Dec. 6, 2021, 12:31 a.m.
Col: 87 Missing semicolon.	reviewbot	Dec. 5, 2021, 12:13 p.m.
Col: 62 Missing semicolon.	reviewbot	Dec. 5, 2021, 12:13 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
W291 trailing whitespace	reviewbot	Dec. 6, 2021, midnight
E302 expected 2 blank lines, found 1	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
W292 no newline at end of file	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E261 at least two spaces before inline comment	reviewbot	Dec. 6, 2021, midnight
E501 line too long (95 > 79 characters)	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E501 line too long (123 > 79 characters)	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
E131 continuation line unaligned for hanging indent	reviewbot	Dec. 6, 2021, midnight
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, midnight
Col: 87 Missing semicolon.	reviewbot	Dec. 6, 2021, midnight
Col: 62 Missing semicolon.	reviewbot	Dec. 6, 2021, midnight
E302 expected 2 blank lines, found 1	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
W292 no newline at end of file	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 6, 2021, 12:31 a.m.
E501 line too long (95 > 79 characters)	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E501 line too long (123 > 79 characters)	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E131 continuation line unaligned for hanging indent	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 12:31 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
W292 no newline at end of file	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 6, 2021, 9:48 p.m.
E501 line too long (95 > 79 characters)	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E501 line too long (123 > 79 characters)	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E131 continuation line unaligned for hanging indent	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:15 p.m.
W291 trailing whitespace	reviewbot	Dec. 6, 2021, 10:15 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 6, 2021, 10:15 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:15 p.m.
W292 no newline at end of file	reviewbot	Dec. 6, 2021, 10:16 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:16 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:16 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:17 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:17 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:17 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:18 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:18 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 6, 2021, 10:18 p.m.
E501 line too long (95 > 79 characters)	reviewbot	Dec. 6, 2021, 10:18 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:19 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:19 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:19 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:19 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:19 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:19 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:19 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:19 p.m.
E501 line too long (123 > 79 characters)	reviewbot	Dec. 6, 2021, 10:19 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:20 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:20 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:20 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:20 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:20 p.m.
E131 continuation line unaligned for hanging indent	reviewbot	Dec. 6, 2021, 10:20 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:20 p.m.
Col: 87 Missing semicolon.	reviewbot	Dec. 6, 2021, 10:23 p.m.
Col: 62 Missing semicolon.	reviewbot	Dec. 6, 2021, 10:23 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:23 p.m.
E502 the backslash is redundant between brackets	reviewbot	Dec. 6, 2021, 10:23 p.m.
E203 whitespace before ','	reviewbot	Dec. 6, 2021, 10:23 p.m.
E502 the backslash is redundant between brackets	reviewbot	Dec. 6, 2021, 10:23 p.m.
E127 continuation line over-indented for visual indent	reviewbot	Dec. 6, 2021, 10:23 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:23 p.m.
E131 continuation line unaligned for hanging indent	reviewbot	Dec. 6, 2021, 10:23 p.m.
E502 the backslash is redundant between brackets	reviewbot	Dec. 6, 2021, 10:23 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Dec. 6, 2021, 10:23 p.m.
E502 the backslash is redundant between brackets	reviewbot	Dec. 6, 2021, 10:23 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Dec. 6, 2021, 10:23 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:23 p.m.
F401 'django.core.files.storage.get_storage_class' imported but unused	reviewbot	Dec. 6, 2021, 10:23 p.m.
F401 'django.core.files.storage.DefaultStorage' imported but unused	reviewbot	Dec. 6, 2021, 10:23 p.m.
F401 'django.utils.html.format_html_join' imported but unused	reviewbot	Dec. 6, 2021, 10:23 p.m.
F401 'django.utils.html.format_html' imported but unused	reviewbot	Dec. 6, 2021, 10:23 p.m.
Col: 87 Missing semicolon.	reviewbot	Dec. 6, 2021, 10:23 p.m.
Col: 62 Missing semicolon.	reviewbot	Dec. 6, 2021, 10:23 p.m.

flake8 failed.

JSHint failed.

flake8

djblets/forms/fields.py (Diff revision 1)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 1)
Show all issues
```
E261 at least two spaces before inline comment
```
djblets/forms/fields.py (Diff revision 1)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```
djblets/forms/fields.py (Diff revision 1)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 1)
Show all issues
```
E261 at least two spaces before inline comment
```
djblets/forms/fields.py (Diff revision 1)
Show all issues
```
E501 line too long (93 > 79 characters)
```
djblets/forms/fields.py (Diff revision 1)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```

JSHint

djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 1)
Show all issues
```
Col: 87
 Missing semicolon.
```
djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 1)
Show all issues
```
Col: 62
 Missing semicolon.
```

Description:

~		ListEditDictionaryField Patch from Michelle Aubin.
	~	[WIP] ListEditDictionaryField Patch from Michelle Aubin.

Summary:

-	ListEditDictionaryField Patch from Michelle Aubin.
+	Custom Admin Emoji Panel (Djblets)

Description:

~		[WIP] ListEditDictionaryField Patch from Michelle Aubin.
	~	Adds a page to the admint panel which allows an admin to upload a custom emoji by uploading a name, shortcode, description, and image. These fields are editable whenever the user re-vists the page. The emoji data is loaded from, and saved into SiteConfiguration, while the image data is loaded from and saved to DefaultStorage.
	+
	+
	+
	+
	+
	+	Further work that needs to be done:
	+	* Enforcing mandatory fields that user must fill out before clicking "Save", so as to not raise an error.
	+	* Adding labels to the form fields, and removing the extra "name" field at the very top of the form.
	+	* Rendering a preview of the emoji when loading the page (through get_context() in EmojiFileUpload).

Testing Done:

	+	Unit testing
	+	Local testing

Commits:

	Summary	Author
-	ListEditDictionaryField Patch from Michelle Aubin.	mxiuwang
+	ListEditDictionaryField Patch from Michelle Aubin.	mxiuwang
+	[WIP] Adding custom emojis in admin emoji dashboard.	mxiuwang
+	[WIP] rendering images.	mxiuwang
+	[WIP] Render images.	mxiuwang
+	Add docstring, code cleanup.	mxiuwang
+	Add Djblets tests.	mxiuwang

Diff:

Revision 2 (+1046 -296)

Show changes

	djblets/avatars/services/base.py
	djblets/avatars/services/file_upload.py
	djblets/forms/fields.py
	djblets/forms/widgets.py
	djblets/forms/templates/djblets_forms/emoji_file_input.html
	djblets/forms/templates/djblets_forms/list_edit_widget.html
	djblets/forms/tests/test_list_edit_dictionary_field.py
	djblets/forms/tests/test_list_edit_field.py
	1 more

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

```
Warning: Showing 30 of 55 failures.
```
djblets/avatars/services/base.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
djblets/avatars/services/file_upload.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
djblets/forms/fields.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
djblets/forms/fields.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E261 at least two spaces before inline comment
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E501 line too long (95 > 79 characters)
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E501 line too long (123 > 79 characters)
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 2)
Show all issues
```
E231 missing whitespace after ','
```

JSHint

djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 2)
Show all issues
```
Col: 87
 Missing semicolon.
```
djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 2)
Show all issues
```
Col: 62
 Missing semicolon.
```

Show all issues

Description needs to wrap with 80 chars I believe

Show all issues

In testing done, mention what kind of new test was added

Description:

~		Adds a page to the admint panel which allows an admin to upload a custom emoji by uploading a name, shortcode, description, and image. These fields are editable whenever the user re-vists the page. The emoji data is loaded from, and saved into SiteConfiguration, while the image data is loaded from and saved to DefaultStorage.
	~	Adds a page to the admint panel which allows an admin to upload a custom emoji
	+	by uploading a name, shortcode, description, and image. These fields are
	+	editable whenever the user re-vists the page. The emoji data is loaded from,
	+	and saved into SiteConfiguration, while the image data is loaded from and
	+	saved to DefaultStorage.





		Further work that needs to be done:
~		* Enforcing mandatory fields that user must fill out before clicking "Save", so as to not raise an error.
~		* Adding labels to the form fields, and removing the extra "name" field at the very top of the form.
~		* Rendering a preview of the emoji when loading the page (through get_context() in EmojiFileUpload).
	~	* Adding labels to the form fields, and removing the extra "name" field at the
	~	very top of the form.
	~	* Rendering a preview of the emoji when loading the page (through get_context()
	+	in EmojiFileUpload).

Commits:

	Summary	Author
-	ListEditDictionaryField Patch from Michelle Aubin.	mxiuwang
-	[WIP] Adding custom emojis in admin emoji dashboard.	mxiuwang
-	[WIP] rendering images.	mxiuwang
-	[WIP] Render images.	mxiuwang
-	Add docstring, code cleanup.	mxiuwang
-	Add Djblets tests.	mxiuwang
+	ListEditDictionaryField Patch from Michelle Aubin.	mxiuwang
+	[WIP] Adding custom emojis in admin emoji dashboard.	mxiuwang
+	[WIP] rendering images.	mxiuwang
+	[WIP] Render images.	mxiuwang
+	Add docstring, code cleanup.	mxiuwang
+	Add Djblets tests.	mxiuwang
+	Fix automatically-raised whitespace issues.	mxiuwang

Diff:

Revision 3 (+1062 -312)

Show changes

	djblets/avatars/services/file_upload.py
	djblets/forms/fields.py
	djblets/forms/widgets.py
	djblets/forms/templates/djblets_forms/emoji_file_input.html
	djblets/forms/templates/djblets_forms/list_edit_widget.html
	djblets/forms/tests/test_list_edit_dictionary_field.py
	djblets/forms/tests/test_list_edit_field.py
	djblets/static/djblets/js/forms/views/listEditView.es6.js

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

```
Warning: Showing 30 of 45 failures.
```
djblets/forms/fields.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E261 at least two spaces before inline comment
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E501 line too long (95 > 79 characters)
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E501 line too long (123 > 79 characters)
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E131 continuation line unaligned for hanging indent
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_dictionary_field.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```

JSHint

djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 3)
Show all issues
```
Col: 87
 Missing semicolon.
```
djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 3)
Show all issues
```
Col: 62
 Missing semicolon.
```

Testing Done:

~		Unit testing
~		Local testing
	~	Unit testing: Unit test suites for ListEditDictionaryField and ListEditField
	~	Local testing: making sure the app runs property with print() statements.

Description:

~		Adds a page to the admint panel which allows an admin to upload a custom emoji
	~	Adds a page to the admin panel which allows an admin to upload a custom emoji
		by uploading a name, shortcode, description, and image. These fields are
		editable whenever the user re-vists the page. The emoji data is loaded from,
		and saved into SiteConfiguration, while the image data is loaded from and
		saved to DefaultStorage.





		Further work that needs to be done:
		* Adding labels to the form fields, and removing the extra "name" field at the
		very top of the form.
		* Rendering a preview of the emoji when loading the page (through get_context()
		in EmojiFileUpload).

This change incorporates a lot of things from Michelle Aubin's change. It makes it hard to know what parts should land from her change and what should land from yours. Can you instead rebase your work on top of hers, only post the range of commits for your work, and mark her review request as a dependency (Depends On field)?

djblets/forms/widgets.py (Diff revision 3)

Show all issues

This belongs with the Review Board change, since it's really specific to Review Board's implementation. Djblets should be limited to things that are more generic and reusable.

Show all issues

The review request description and summary should also reflect what this commit does, not the work being done in Review Board. From the point of view of the Djblets code, Review Board "doesn't exist." That's the way to think about it. There's a separation.

Description:

~		Adds a page to the admin panel which allows an admin to upload a custom emoji
~		by uploading a name, shortcode, description, and image. These fields are
~		editable whenever the user re-vists the page. The emoji data is loaded from,
	~	Adds a ListEditEmojiDictionaryField (inherited from Michelle Aubin's
	~	ListEditDictionaryField class), which takes in a dictionary of values and
	~	splits it into a tuple of (key, value1, value2, value3).
-		and saved into SiteConfiguration, while the image data is loaded from and
-		saved to DefaultStorage.

~
	~	EmojiFileInput class is a subclass of ClearableFileInput, which takes in a
	+	file upload from the user, and saves it into the context variable. In future
	+	implementations, the get_context() method can also be used to render image
	+	previews if the file uploaded is a valid image file.



		Further work that needs to be done:
-		* Adding labels to the form fields, and removing the extra "name" field at the
-		very top of the form.
		* Rendering a preview of the emoji when loading the page (through get_context()
~		in EmojiFileUpload).
	~	in EmojiFileUpload). Right now, the uploaded image file is being passed as a
	+	bytestream, but it needs to be passed as a file or image object in order
	+	to be rendered.

Commits:

	Summary	Author
-	ListEditDictionaryField Patch from Michelle Aubin.	mxiuwang
-	[WIP] Adding custom emojis in admin emoji dashboard.	mxiuwang
-	[WIP] rendering images.	mxiuwang
-	[WIP] Render images.	mxiuwang
-	Add docstring, code cleanup.	mxiuwang
-	Add Djblets tests.	mxiuwang
-	Fix automatically-raised whitespace issues.	mxiuwang
+	ListEditDictionaryField Patch from Michelle Aubin.	mxiuwang
+	[WIP] Adding custom emojis in admin emoji dashboard.	mxiuwang
+	[WIP] rendering images.	mxiuwang
+	[WIP] Render images.	mxiuwang
+	Add docstring, code cleanup.	mxiuwang
+	Add Djblets tests.	mxiuwang
+	Fix automatically-raised whitespace issues.	mxiuwang
+	Define ListEditEmojiDictionaryField as its own class.	mxiuwang

Diff:

Revision 4 (+1305 -333)

Show changes

	djblets/avatars/services/file_upload.py
	djblets/forms/fields.py
	djblets/forms/widgets.py
	djblets/forms/templates/djblets_forms/emoji_file_input.html
	djblets/forms/templates/djblets_forms/list_edit_widget.html
	djblets/forms/tests/test_list_edit_dictionary_field.py
	djblets/forms/tests/test_list_edit_emoji_dictionary_field.py
	djblets/forms/tests/test_list_edit_field.py
	1 more

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

```
Warning: Showing 30 of 49 failures.
```
djblets/forms/fields.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 4)
Show all issues
```
W291 trailing whitespace
```
djblets/forms/fields.py (Diff revision 4)
Show all issues
```
E302 expected 2 blank lines, found 1
```
djblets/forms/fields.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 4)
Show all issues
```
W292 no newline at end of file
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E261 at least two spaces before inline comment
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E501 line too long (95 > 79 characters)
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E501 line too long (123 > 79 characters)
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E131 continuation line unaligned for hanging indent
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```

JSHint

djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 4)
Show all issues
```
Col: 87
 Missing semicolon.
```
djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 4)
Show all issues
```
Col: 62
 Missing semicolon.
```

Commits:

	Summary	Author
-	ListEditDictionaryField Patch from Michelle Aubin.	mxiuwang
-	[WIP] Adding custom emojis in admin emoji dashboard.	mxiuwang
-	[WIP] rendering images.	mxiuwang
-	[WIP] Render images.	mxiuwang
-	Add docstring, code cleanup.	mxiuwang
-	Add Djblets tests.	mxiuwang
-	Fix automatically-raised whitespace issues.	mxiuwang
-	Define ListEditEmojiDictionaryField as its own class.	mxiuwang
+	[WIP] Adding custom emojis in admin emoji dashboard.	mxiuwang
+	[WIP] rendering images.	mxiuwang
+	[WIP] Render images.	mxiuwang
+	Add docstring, code cleanup.	mxiuwang
+	Add Djblets tests.	mxiuwang
+	Fix automatically-raised whitespace issues.	mxiuwang
+	Define ListEditEmojiDictionaryField as its own class.	mxiuwang

Diff:

Revision 5 (+457 -155)

Show changes

	djblets/avatars/services/file_upload.py
	djblets/forms/fields.py
	djblets/forms/widgets.py
	djblets/forms/templates/djblets_forms/emoji_file_input.html
	djblets/forms/templates/djblets_forms/list_edit_widget.html
	djblets/forms/tests/test_list_edit_emoji_dictionary_field.py
	djblets/static/djblets/js/forms/views/listEditView.es6.js

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 47 failures.
```
djblets/forms/fields.py (Diff revision 5)
Show all issues
```
E302 expected 2 blank lines, found 1
```
djblets/forms/fields.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 5)
Show all issues
```
W292 no newline at end of file
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E261 at least two spaces before inline comment
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E501 line too long (95 > 79 characters)
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E501 line too long (123 > 79 characters)
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E131 continuation line unaligned for hanging indent
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```

Commits:

	Summary	Author
-	[WIP] Adding custom emojis in admin emoji dashboard.	mxiuwang
-	[WIP] rendering images.	mxiuwang
-	[WIP] Render images.	mxiuwang
-	Add docstring, code cleanup.	mxiuwang
-	Add Djblets tests.	mxiuwang
-	Fix automatically-raised whitespace issues.	mxiuwang
-	Define ListEditEmojiDictionaryField as its own class.	mxiuwang
+	[WIP] Adding custom emojis in admin emoji dashboard.	mxiuwang
+	[WIP] rendering images.	mxiuwang
+	[WIP] Render images.	mxiuwang
+	Add docstring, code cleanup.	mxiuwang
+	Add Djblets tests.	mxiuwang
+	Fix automatically-raised whitespace issues.	mxiuwang
+	Define ListEditEmojiDictionaryField as its own class.	mxiuwang
+	Fix suggestions.	mxiuwang

Diff:

Revision 6 (+420 -192)

Show changes

	djblets/avatars/services/file_upload.py
	djblets/forms/fields.py
	djblets/forms/widgets.py
	djblets/forms/templates/djblets_forms/emoji_file_input.html
	djblets/forms/templates/djblets_forms/list_edit_widget.html
	djblets/forms/tests/test_list_edit_emoji_dictionary_field.py
	djblets/static/djblets/js/forms/views/listEditView.es6.js

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 46 failures.
```
djblets/forms/fields.py (Diff revision 6)
Show all issues
```
E302 expected 2 blank lines, found 1
```
djblets/forms/fields.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 6)
Show all issues
```
W292 no newline at end of file
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E261 at least two spaces before inline comment
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E501 line too long (95 > 79 characters)
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E501 line too long (123 > 79 characters)
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E131 continuation line unaligned for hanging indent
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```

Depends On:

+	~~11858 - Modify djblets.forms.widgets.ListEditWidget to handle any type of widget and form field~~

Commits:

	Summary	Author
-	[WIP] Adding custom emojis in admin emoji dashboard.	mxiuwang
-	[WIP] rendering images.	mxiuwang
-	[WIP] Render images.	mxiuwang
-	Add docstring, code cleanup.	mxiuwang
-	Add Djblets tests.	mxiuwang
-	Fix automatically-raised whitespace issues.	mxiuwang
-	Define ListEditEmojiDictionaryField as its own class.	mxiuwang
-	Fix suggestions.	mxiuwang
+	ListEditDictionaryField Patch from Michelle Aubin.	mxiuwang
+	[WIP] Adding custom emojis in admin emoji dashboard.	mxiuwang
+	[WIP] rendering images.	mxiuwang
+	[WIP] Render images.	mxiuwang
+	Add docstring, code cleanup.	mxiuwang
+	Add Djblets tests.	mxiuwang
+	Fix automatically-raised whitespace issues.	mxiuwang
+	Define ListEditEmojiDictionaryField as its own class.	mxiuwang
+	Fix suggestions.	mxiuwang
+	Render emoji preview image.	mxiuwang

Diff:

Revision 7 (+1273 -371)

Show changes

	djblets/avatars/services/file_upload.py
	djblets/forms/fields.py
	djblets/forms/widgets.py
	djblets/forms/templates/djblets_forms/emoji_file_input.html
	djblets/forms/templates/djblets_forms/list_edit_widget.html
	djblets/forms/tests/test_list_edit_dictionary_field.py
	djblets/forms/tests/test_list_edit_emoji_dictionary_field.py
	djblets/forms/tests/test_list_edit_field.py
	1 more

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

```
Warning: Showing 30 of 48 failures.
```
djblets/forms/fields.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 7)
Show all issues
```
W291 trailing whitespace
```
djblets/forms/fields.py (Diff revision 7)
Show all issues
```
E302 expected 2 blank lines, found 1
```
djblets/forms/fields.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/fields.py (Diff revision 7)
Show all issues
```
W292 no newline at end of file
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E261 at least two spaces before inline comment
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E501 line too long (95 > 79 characters)
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E501 line too long (123 > 79 characters)
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E131 continuation line unaligned for hanging indent
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 7)
Show all issues
```
E231 missing whitespace after ','
```

JSHint

djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 7)
Show all issues
```
Col: 87
 Missing semicolon.
```
djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 7)
Show all issues
```
Col: 62
 Missing semicolon.
```

Description:

		Adds a ListEditEmojiDictionaryField (inherited from Michelle Aubin's
		ListEditDictionaryField class), which takes in a dictionary of values and
		splits it into a tuple of (key, value1, value2, value3).

~		EmojiFileInput class is a subclass of ClearableFileInput, which takes in a
~		file upload from the user, and saves it into the context variable. In future
	~	EmojiFileInput class is a subclass of FileInput, which takes in a file
	~	upload from the user, and saves it into the context variable. In future
		implementations, the get_context() method can also be used to render image
~		previews if the file uploaded is a valid image file.
	~	previews if the file uploaded is a valid image file.
-
-
-
-		Further work that needs to be done:
-		* Rendering a preview of the emoji when loading the page (through get_context()
-		in EmojiFileUpload). Right now, the uploaded image file is being passed as a
-		bytestream, but it needs to be passed as a file or image object in order
-		to be rendered.

Commits:

	Summary	Author
-	ListEditDictionaryField Patch from Michelle Aubin.	mxiuwang
-	[WIP] Adding custom emojis in admin emoji dashboard.	mxiuwang
-	[WIP] rendering images.	mxiuwang
-	[WIP] Render images.	mxiuwang
-	Add docstring, code cleanup.	mxiuwang
-	Add Djblets tests.	mxiuwang
-	Fix automatically-raised whitespace issues.	mxiuwang
-	Define ListEditEmojiDictionaryField as its own class.	mxiuwang
-	Fix suggestions.	mxiuwang
-	Render emoji preview image.	mxiuwang
+	ListEditDictionaryField Patch from Michelle Aubin.	mxiuwang
+	[WIP] Adding custom emojis in admin emoji dashboard.	mxiuwang
+	[WIP] rendering images.	mxiuwang
+	[WIP] Render images.	mxiuwang
+	Add docstring, code cleanup.	mxiuwang
+	Add Djblets tests.	mxiuwang
+	Fix automatically-raised whitespace issues.	mxiuwang
+	Define ListEditEmojiDictionaryField as its own class.	mxiuwang
+	Fix suggestions.	mxiuwang
+	Render emoji preview image.	mxiuwang
+	Fix flake8 suggestions.	mxiuwang

Diff:

Revision 8 (+1298 -388)

Show changes

	djblets/avatars/services/file_upload.py
	djblets/forms/fields.py
	djblets/forms/widgets.py
	djblets/forms/templates/djblets_forms/emoji_file_input.html
	djblets/forms/templates/djblets_forms/list_edit_widget.html
	djblets/forms/tests/test_list_edit_dictionary_field.py
	djblets/forms/tests/test_list_edit_emoji_dictionary_field.py
	djblets/forms/tests/test_list_edit_field.py
	1 more

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 8)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 8)
Show all issues
```
E502 the backslash is redundant between brackets
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 8)
Show all issues
```
E203 whitespace before ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 8)
Show all issues
```
E502 the backslash is redundant between brackets
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 8)
Show all issues
```
E127 continuation line over-indented for visual indent
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 8)
Show all issues
```
E231 missing whitespace after ','
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 8)
Show all issues
```
E131 continuation line unaligned for hanging indent
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 8)
Show all issues
```
E502 the backslash is redundant between brackets
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 8)
Show all issues
```
E128 continuation line under-indented for visual indent
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 8)
Show all issues
```
E502 the backslash is redundant between brackets
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 8)
Show all issues
```
E126 continuation line over-indented for hanging indent
```
djblets/forms/tests/test_list_edit_emoji_dictionary_field.py (Diff revision 8)
Show all issues
```
E231 missing whitespace after ','
```

djblets/forms/widgets.py (Diff revision 8)

Show all issues

F401 'django.core.files.storage.get_storage_class' imported but unused

djblets/forms/widgets.py (Diff revision 8)

Show all issues

F401 'django.core.files.storage.DefaultStorage' imported but unused

djblets/forms/widgets.py (Diff revision 8)

Show all issues

F401 'django.utils.html.format_html_join' imported but unused

djblets/forms/widgets.py (Diff revision 8)

Show all issues

F401 'django.utils.html.format_html' imported but unused

JSHint

djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 8)
Show all issues
```
Col: 87
 Missing semicolon.
```
djblets/static/djblets/js/forms/views/listEditView.es6.js (Diff revision 8)
Show all issues
```
Col: 62
 Missing semicolon.
```