reviewboard/scmtools/tests/test_perforce.py (Diff revision 1)Show all issues
Review Request #11871 — Created Nov. 10, 2021 and submitted
There are two issues with test skipping that I ran into with my
work-in-progress M1 configuration:
- Perforce tests were set up to skip if the P4 module wasn't available,
but at some point we had an import of P4Exception snuck in that
wasn't properly guarded. This change makes it so that we properly
skip the test without hitting
- Once upon a time, paramiko just allowed
SocketErrorto raise when
port 22 was closed, but now it has its own error class.
Ran unit tests.
Revision 2 (+18 -24)
|reviewboard/scmtools/tests/test_perforce.py (Diff revision 2)|
I made a similar change for P4, except I aliased this to
Exception. I don't think either approach is better than the other right now, but since some tests do simulate P4 operations and work without having p4python installed, I err'd on the side of keeping
P4Exceptionoperational. What do you think?