Fix concatenation issue in 'test_with_garbage_hunk' test for unifed_diffs.py

Review Request #11869 — Created Nov. 3, 2021 and updated

jordanvandenbruel
DiffX
master
diffx
For the `test_with_garbage_in_hunk` test, two lines were
concatenated which made it seem like the proper message should
be talking about line 5. However, the garbage is on line 6.

This commit just adds that comma in to fix the input and corrects
the expected message.

Only the one test was updated to more accurately test unified
diffs.

Summary Author
Fix bug in unified_diffs testing.
Jordan
Description From Last Updated

Can you flesh out the summary to be more specific about what was fixed? It's best to avoid general "Fixed ...

chipx86chipx86

This change is touching python, but your summary references a go file. Can you fix that?

daviddavid
chipx86
  1. 
      
  2. Can you flesh out the summary to be more specific about what was fixed? It's best to avoid general "Fixed a bug" summaries, because they blur together. Instead, the summary should give me a high-level idea when I'm browsing commits later, to let me know more specifically what this particular bug was about.

    Indicating the type of bug (an off-by-one error with the lines of context) and the test in question would help.

  3. 
      
jordanvandenbruel
david
  1. 
      
  2. This change is touching python, but your summary references a go file. Can you fix that?

  3. 
      
jordanvandenbruel
Review request changed

Summary:

-Fix concatenation issue in 'test_with_garbage_hunk' test for unifedDiffs.go
+Fix concatenation issue in 'test_with_garbage_hunk' test for unifed_diffs.py
Loading...