Summary

Fix concatenation issue in 'test_with_garbage_hunk' test for unifed_diffs.py

Review Request #11869 — Created Nov. 3, 2021 and submitted Dec. 6, 2021, 3:07 a.m.

Information

Owner

jordanvandenbruel

Repository

DiffX

Branch

master

Bugs

Depends On

Reviewers

Groups

diffx

People

Description

For the `test_with_garbage_in_hunk` test, two lines were
concatenated which made it seem like the proper message should
be talking about line 5. However, the garbage is on line 6.

This commit just adds that comma in to fix the input and corrects
the expected message.

Testing Done

Only the one test was updated to more accurately test unified
diffs.

Commits

Summary	ID	Author
Fix bug in unified_diffs testing. For the `test_with_garbage_in_hunk` test, two lines were concatenated which made it seem like the proper message should be talking about line 5. However, the garbage is on line 6. This commit just adds that comma in to fix the input and corrects the expected message.	3451f9e59128a4076868de220aadca7d60434d47	Jordan

Issues

Description	From	Last Updated
Can you flesh out the summary to be more specific about what was fixed? It's best to avoid general "Fixed …	chipx86	Nov. 25, 2021, 7:26 p.m.
This change is touching python, but your summary references a go file. Can you fix that?	david	Nov. 25, 2021, 7:26 p.m.

flake8 passed.

JSHint passed.

The issue has been resolved. Show all issues

Can you flesh out the summary to be more specific about what was fixed? It's best to avoid general "Fixed a bug" summaries, because they blur together. Instead, the summary should give me a high-level idea when I'm browsing commits later, to let me know more specifically what this particular bug was about.
Indicating the type of bug (an off-by-one error with the lines of context) and the test in question would help.

Summary:: Fix bug in unified_diffs testing.
Fix concatenation issue in 'test_with_garbage_hunk' test for unifedDiffs.go

The issue has been resolved. Show all issues

This change is touching python, but your summary references a go file. Can you fix that?

Summary:: Fix concatenation issue in 'test_with_garbage_hunk' test for unifedDiffs.go
Fix concatenation issue in 'test_with_garbage_hunk' test for unifed_diffs.py

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to pydiffx/release-1.x (c13df3e)