- Download Diff

Summary:

Custom Admin Emoji Panel (Reviewboard)

Review Request #11868 — Created Oct. 23, 2021 and updated Dec. 6, 2021, 10:23 p.m.

Information
Owner:	mxwang
Repository:	Review Board
Branch:	release-4.0.x
Bugs:
Depends On:	~~11821~~
Reviewers
Groups:	reviewboard
People:

Description

Adds a page to the admin panel which allows an admin to upload a custom emoji
by uploading a name, shortcode, description, and image. These fields are
editable whenever the user re-vists the page. The emoji data is loaded from,
and saved into SiteConfiguration, while the image data is loaded from and
saved to DefaultStorage.

Further work that needs to be done: * Adding labels to the form fields, and removing the extra "name" field at
the very top of the form.

Summary document in Notion: https://www.notion.so/reviewboard/Custom-Emojis-Progress-6644ec34f5a84c6ab957ea11ae2b7259

Testing Done

Unit testing: Unit test suites for class Emoji_Widget

Local testing: making sure the app runs property with print() statements.

Commits

Summary	Author
Upload Emojis wip.	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	mxiuwang
[WIP] use forms to upload images	mxiuwang
[WIP] load() and save() functions.	mxiuwang
[WIP] Emoji working, trying to validate save().	mxiuwang
WIP save() function in emoji_settings,py	mxiuwang
save runs but does not fetch data from forms.	mxiuwang
[WIP] cannot fetch data from forms.	mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.	mxiuwang
ListEditDictionaryField working.	mxiuwang
save working except images.	mxiuwang
load() function loads data (except images.	mxiuwang
Images saved to DefaultStorage, not yet rendered on load().	mxiuwang
[WIP] Rendering Images.	mxiuwang
[WIP] Render image previews.	mxiuwang
Add docstring, code cleanup.	mxiuwang
Undo accidental pull patch from Akim.	mxiuwang
Remove unnecessary header, add placeholder text.	mxiuwang
Emoji_Widget tests.	mxiuwang
Revert accidental change to dependencies.py and Akim's PR.	mxiuwang
Fix automatically-raised whitespace issues.	mxiuwang
Fix automatically-raised whitespace issues.	mxiuwang
Fix suggestions.	mxiuwang
Render custom emoji image preview.	mxiuwang
Fix flake8 suggestions.	mxiuwang

Screenshots

Issues

Description	From	Last Updated
F401 'django.utils.translation.ugettext' imported but unused	reviewbot	Dec. 3, 2021, 10:25 a.m.
W293 blank line contains whitespace	reviewbot	Dec. 3, 2021, 10:25 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:25 a.m.
E501 line too long (83 > 79 characters)	reviewbot	Dec. 3, 2021, 10:25 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:25 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:25 a.m.
W292 no newline at end of file	reviewbot	Dec. 3, 2021, 10:25 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 3, 2021, 10:25 a.m.
W292 no newline at end of file	reviewbot	Dec. 3, 2021, 10:25 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:25 a.m.
W292 no newline at end of file	reviewbot	Dec. 3, 2021, 10:25 a.m.
F403 'from .models import *' used; unable to detect undefined names	reviewbot	Dec. 3, 2021, 10:25 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 3, 2021, 10:25 a.m.
E226 missing whitespace around arithmetic operator	reviewbot	Dec. 3, 2021, 10:25 a.m.
E226 missing whitespace around arithmetic operator	reviewbot	Dec. 3, 2021, 10:25 a.m.
E225 missing whitespace around operator	reviewbot	Dec. 3, 2021, 10:25 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:25 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:25 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:25 a.m.
F841 local variable 'display_emoji' is assigned to but never used	reviewbot	Dec. 3, 2021, 10:25 a.m.
F405 'CustomEmojis' may be undefined, or defined from star imports: .models	reviewbot	Dec. 3, 2021, 10:25 a.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	Dec. 3, 2021, 10:25 a.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	Dec. 3, 2021, 10:25 a.m.
W292 no newline at end of file	reviewbot	Dec. 3, 2021, 10:25 a.m.
F811 redefinition of unused 'ListEditWidget' from line 5	reviewbot	Dec. 4, 2021, 11:04 p.m.
F811 redefinition of unused 'forms' from line 3	reviewbot	Dec. 4, 2021, 11:04 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 4, 2021, 11:04 p.m.
W291 trailing whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
W291 trailing whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
W293 blank line contains whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 4, 2021, 11:04 p.m.
W291 trailing whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 4, 2021, 11:04 p.m.
W291 trailing whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 4, 2021, 11:04 p.m.
W291 trailing whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 4, 2021, 11:04 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Dec. 4, 2021, 11:04 p.m.
W293 blank line contains whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
W291 trailing whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
W291 trailing whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
W293 blank line contains whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
W291 trailing whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
W291 trailing whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Dec. 4, 2021, 11:04 p.m.
E501 line too long (90 > 79 characters)	reviewbot	Dec. 4, 2021, 11:04 p.m.
W293 blank line contains whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 4, 2021, 11:04 p.m.
W291 trailing whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
W291 trailing whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
W293 blank line contains whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
W293 blank line contains whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
W293 blank line contains whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
W291 trailing whitespace	reviewbot	Dec. 4, 2021, 11:04 p.m.
Col: 36 Expected ')' and instead saw 'this'.	reviewbot	Dec. 3, 2021, 10:26 a.m.
F811 redefinition of unused 'ListEditWidget' from line 5	reviewbot	Dec. 5, 2021, 12:18 p.m.
F811 redefinition of unused 'forms' from line 3	reviewbot	Dec. 5, 2021, 12:18 p.m.
F401 'django.forms' imported but unused	reviewbot	Dec. 5, 2021, 12:18 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 5, 2021, 12:18 p.m.
E231 missing whitespace after ':'	reviewbot	Dec. 5, 2021, 12:18 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 5, 2021, 12:18 p.m.
E231 missing whitespace after ':'	reviewbot	Dec. 5, 2021, 12:18 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 5, 2021, 12:18 p.m.
E231 missing whitespace after ':'	reviewbot	Dec. 5, 2021, 12:18 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 5, 2021, 12:18 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 5, 2021, 12:18 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Dec. 5, 2021, 12:18 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Dec. 5, 2021, 12:18 p.m.
E501 line too long (90 > 79 characters)	reviewbot	Dec. 5, 2021, 12:18 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 5, 2021, 12:18 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:18 p.m.
E301 expected 1 blank line, found 0	reviewbot	Dec. 5, 2021, 12:18 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 5, 2021, 12:18 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 5, 2021, 12:18 p.m.
E501 line too long (104 > 79 characters)	reviewbot	Dec. 5, 2021, 12:18 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Dec. 5, 2021, 12:19 p.m.
E501 line too long (87 > 79 characters)	reviewbot	Dec. 5, 2021, 12:19 p.m.
E501 line too long (86 > 79 characters)	reviewbot	Dec. 5, 2021, 12:19 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Dec. 5, 2021, 12:19 p.m.
E501 line too long (90 > 79 characters)	reviewbot	Dec. 5, 2021, 12:19 p.m.
W292 no newline at end of file	reviewbot	Dec. 5, 2021, 12:19 p.m.
W292 no newline at end of file	reviewbot	Dec. 5, 2021, 12:19 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 5, 2021, 12:19 p.m.
E501 line too long (97 > 79 characters)	reviewbot	Dec. 5, 2021, 12:19 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 6, 2021, 9:48 p.m.
E302 expected 2 blank lines, found 0	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ':'	reviewbot	Dec. 6, 2021, 9:48 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ':'	reviewbot	Dec. 6, 2021, 9:48 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ':'	reviewbot	Dec. 6, 2021, 9:48 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 6, 2021, 9:48 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 6, 2021, 9:48 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Dec. 6, 2021, 9:48 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Dec. 6, 2021, 9:48 p.m.
E501 line too long (90 > 79 characters)	reviewbot	Dec. 6, 2021, 9:48 p.m.
W292 no newline at end of file	reviewbot	Dec. 6, 2021, 9:48 p.m.
F811 redefinition of unused 'ListEditWidget' from line 4	reviewbot	Dec. 6, 2021, 9:48 p.m.
F401 'django.forms' imported but unused	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E301 expected 1 blank line, found 0	reviewbot	Dec. 6, 2021, 9:48 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 6, 2021, 9:48 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 6, 2021, 9:48 p.m.
E501 line too long (104 > 79 characters)	reviewbot	Dec. 6, 2021, 9:48 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Dec. 6, 2021, 9:48 p.m.
E501 line too long (87 > 79 characters)	reviewbot	Dec. 6, 2021, 9:48 p.m.
E501 line too long (86 > 79 characters)	reviewbot	Dec. 6, 2021, 9:48 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Dec. 6, 2021, 9:48 p.m.
E501 line too long (90 > 79 characters)	reviewbot	Dec. 6, 2021, 9:48 p.m.
W292 no newline at end of file	reviewbot	Dec. 6, 2021, 9:48 p.m.
W292 no newline at end of file	reviewbot	Dec. 6, 2021, 9:48 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 9:48 p.m.
E501 line too long (97 > 79 characters)	reviewbot	Dec. 6, 2021, 9:48 p.m.
F401 'django.core.files.storage.get_storage_class' imported but unused	reviewbot	Dec. 6, 2021, 10 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 6, 2021, 10:01 p.m.
E722 do not use bare 'except'	reviewbot	Dec. 6, 2021, 10:01 p.m.
W293 blank line contains whitespace	reviewbot	Dec. 6, 2021, 10:01 p.m.
W291 trailing whitespace	reviewbot	Dec. 6, 2021, 10:01 p.m.
E302 expected 2 blank lines, found 0	reviewbot	Dec. 6, 2021, 10:02 p.m.
E231 missing whitespace after ':'	reviewbot	Dec. 6, 2021, 10:02 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 6, 2021, 10:04 p.m.
E231 missing whitespace after ':'	reviewbot	Dec. 6, 2021, 10:04 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 6, 2021, 10:04 p.m.
E231 missing whitespace after ':'	reviewbot	Dec. 6, 2021, 10:04 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 6, 2021, 10:04 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 6, 2021, 10:04 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Dec. 6, 2021, 10:07 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Dec. 6, 2021, 10:07 p.m.
E501 line too long (90 > 79 characters)	reviewbot	Dec. 6, 2021, 10:08 p.m.
W292 no newline at end of file	reviewbot	Dec. 6, 2021, 10:08 p.m.
F811 redefinition of unused 'ListEditWidget' from line 4	reviewbot	Dec. 6, 2021, 10:08 p.m.
F401 'django.forms' imported but unused	reviewbot	Dec. 6, 2021, 10:08 p.m.
E501 line too long (87 > 79 characters)	reviewbot	Dec. 6, 2021, 10:09 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 6, 2021, 10:09 p.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 6, 2021, 10:09 p.m.
E501 line too long (120 > 79 characters)	reviewbot	Dec. 6, 2021, 10:09 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:09 p.m.
W293 blank line contains whitespace	reviewbot	Dec. 6, 2021, 10:10 p.m.
E301 expected 1 blank line, found 0	reviewbot	Dec. 6, 2021, 10:10 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 6, 2021, 10:11 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 6, 2021, 10:11 p.m.
E501 line too long (104 > 79 characters)	reviewbot	Dec. 6, 2021, 10:11 p.m.
E501 line too long (81 > 79 characters)	reviewbot	Dec. 6, 2021, 10:12 p.m.
F841 local variable 'message' is assigned to but never used	reviewbot	Dec. 6, 2021, 10:23 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Dec. 6, 2021, 10:23 p.m.
E126 continuation line over-indented for hanging indent	reviewbot	Dec. 6, 2021, 10:23 p.m.
W291 trailing whitespace	reviewbot	Dec. 6, 2021, 10:23 p.m.
E502 the backslash is redundant between brackets	reviewbot	Dec. 6, 2021, 10:23 p.m.
E128 continuation line under-indented for visual indent	reviewbot	Dec. 6, 2021, 10:23 p.m.
E502 the backslash is redundant between brackets	reviewbot	Dec. 6, 2021, 10:23 p.m.
E131 continuation line unaligned for hanging indent	reviewbot	Dec. 6, 2021, 10:23 p.m.
E501 line too long (85 > 79 characters)	reviewbot	Dec. 6, 2021, 10:23 p.m.
E501 line too long (87 > 79 characters)	reviewbot	Dec. 6, 2021, 10:23 p.m.
E501 line too long (86 > 79 characters)	reviewbot	Dec. 6, 2021, 10:23 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Dec. 6, 2021, 10:23 p.m.
E501 line too long (90 > 79 characters)	reviewbot	Dec. 6, 2021, 10:23 p.m.
W292 no newline at end of file	reviewbot	Dec. 6, 2021, 10:23 p.m.
W292 no newline at end of file	reviewbot	Dec. 6, 2021, 10:23 p.m.
E231 missing whitespace after ','	reviewbot	Dec. 6, 2021, 10:23 p.m.
E501 line too long (97 > 79 characters)	reviewbot	Dec. 6, 2021, 10:23 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/forms/emoji_settings.py (Diff revision 1)
Show all issues
```
F401 'django.utils.translation.ugettext' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 1)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 1)
Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 1)
Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 1)
Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/models.py (Diff revision 1)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/models.py (Diff revision 1)
Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/urls.py (Diff revision 1)
Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/urls.py (Diff revision 1)
Show all issues
```
W292 no newline at end of file
```

reviewboard/admin/views.py (Diff revision 1)

Show all issues

F403 'from .models import *' used; unable to detect undefined names

reviewboard/admin/views.py (Diff revision 1)
Show all issues
```
E302 expected 2 blank lines, found 1
```

reviewboard/admin/views.py (Diff revision 1)

Show all issues

E226 missing whitespace around arithmetic operator

reviewboard/admin/views.py (Diff revision 1)

Show all issues

E226 missing whitespace around arithmetic operator

reviewboard/admin/views.py (Diff revision 1)
Show all issues
```
E225 missing whitespace around operator
```
reviewboard/admin/views.py (Diff revision 1)
Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/views.py (Diff revision 1)
Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/views.py (Diff revision 1)
Show all issues
```
E231 missing whitespace after ','
```

reviewboard/admin/views.py (Diff revision 1)

Show all issues

F841 local variable 'display_emoji' is assigned to but never used

reviewboard/admin/views.py (Diff revision 1)

Show all issues

F405 'CustomEmojis' may be undefined, or defined from star imports: .models

reviewboard/admin/views.py (Diff revision 1)

Show all issues

E251 unexpected spaces around keyword / parameter equals

reviewboard/admin/views.py (Diff revision 1)

Show all issues

E251 unexpected spaces around keyword / parameter equals

reviewboard/admin/views.py (Diff revision 1)
Show all issues
```
W292 no newline at end of file
```

Summary:

-	[WIP] Upload Emojis wip.
+	[WIP] Upload Emojis.

Commits:

	Summary	Author
-	Upload Emojis wip.	mxiuwang
-	Upload Emojis using Models model, soon to be changed to Forms model.	mxiuwang
-	[WIP] use forms to upload images	mxiuwang
+	Upload Emojis wip.	mxiuwang
+	Upload Emojis using Models model, soon to be changed to Forms model.	mxiuwang
+	[WIP] use forms to upload images	mxiuwang
+	[WIP] load() and save() functions.	mxiuwang
+	[WIP] Emoji working, trying to validate save().	mxiuwang
+	WIP save() function in emoji_settings,py	mxiuwang
+	save runs but does not fetch data from forms.	mxiuwang
+	[WIP] cannot fetch data from forms.	mxiuwang
+	[WIP] Add ListEditDictionaryField for parsing input.	mxiuwang
+	ListEditDictionaryField working.	mxiuwang
+	save working except images.	mxiuwang
+	load() function loads data (except images.	mxiuwang
+	Images saved to DefaultStorage, not yet rendered on load().	mxiuwang
+	[WIP] Rendering Images.	mxiuwang
+	[WIP] Render image previews.	mxiuwang
+	Add docstring, code cleanup.	mxiuwang
+	Undo accidental pull patch from Akim.	mxiuwang

Diff:

Revision 2 (+1756 -1348)

Show changes

	dev-requirements.txt
	reviewboard/dependencies.py
	reviewboard/staticbundles.py
	reviewboard/admin/siteconfig.py
	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/forms/emoji_settings.py
	reviewboard/static/rb/js/views/imageReviewableView.es6.js

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

```
Warning: Showing 30 of 51 failures.
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
F811 redefinition of unused 'ListEditWidget' from line 5
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
F811 redefinition of unused 'forms' from line 3
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
E261 at least two spaces before inline comment
```

reviewboard/admin/forms/emoji_settings.py (Diff revision 2)

Show all issues

E123 closing bracket does not match indentation of opening bracket's line

reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
E501 line too long (90 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
Show all issues
```
W291 trailing whitespace
```

JSHint

reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 2)
Show all issues
```
Col: 36
 Expected ')' and instead saw 'this'.
```

Summary:

-	[WIP] Upload Emojis.
+	Custom Admin Emoji Panel (Reviewboard)

Description:

~		Upload Emojis using Models model, soon to be changed to Forms model.
	~	Adds a page to the admint panel which allows an admin to upload a custom emoji by uploading a name, shortcode, description, and image. These fields are editable whenever the user re-vists the page. The emoji data is loaded from, and saved into SiteConfiguration, while the image data is loaded from and saved to DefaultStorage.



~		[WIP] use forms to upload images
	~	Further work that needs to be done:
	+	* Enforcing mandatory fields that user must fill out before clicking "Save", so as to not raise an error.
	+	* Adding labels to the form fields, and removing the extra "name" field at the very top of the form.
	+	* Rendering a preview of the emoji when loading the page (through get_context() in EmojiFileUpload).

Commits:

	Summary	Author
-	Upload Emojis wip.	mxiuwang
-	Upload Emojis using Models model, soon to be changed to Forms model.	mxiuwang
-	[WIP] use forms to upload images	mxiuwang
-	[WIP] load() and save() functions.	mxiuwang
-	[WIP] Emoji working, trying to validate save().	mxiuwang
-	WIP save() function in emoji_settings,py	mxiuwang
-	save runs but does not fetch data from forms.	mxiuwang
-	[WIP] cannot fetch data from forms.	mxiuwang
-	[WIP] Add ListEditDictionaryField for parsing input.	mxiuwang
-	ListEditDictionaryField working.	mxiuwang
-	save working except images.	mxiuwang
-	load() function loads data (except images.	mxiuwang
-	Images saved to DefaultStorage, not yet rendered on load().	mxiuwang
-	[WIP] Rendering Images.	mxiuwang
-	[WIP] Render image previews.	mxiuwang
-	Add docstring, code cleanup.	mxiuwang
-	Undo accidental pull patch from Akim.	mxiuwang
+	Upload Emojis wip.	mxiuwang
+	Upload Emojis using Models model, soon to be changed to Forms model.	mxiuwang
+	[WIP] use forms to upload images	mxiuwang
+	[WIP] load() and save() functions.	mxiuwang
+	[WIP] Emoji working, trying to validate save().	mxiuwang
+	WIP save() function in emoji_settings,py	mxiuwang
+	save runs but does not fetch data from forms.	mxiuwang
+	[WIP] cannot fetch data from forms.	mxiuwang
+	[WIP] Add ListEditDictionaryField for parsing input.	mxiuwang
+	ListEditDictionaryField working.	mxiuwang
+	save working except images.	mxiuwang
+	load() function loads data (except images.	mxiuwang
+	Images saved to DefaultStorage, not yet rendered on load().	mxiuwang
+	[WIP] Rendering Images.	mxiuwang
+	[WIP] Render image previews.	mxiuwang
+	Add docstring, code cleanup.	mxiuwang
+	Undo accidental pull patch from Akim.	mxiuwang
+	Remove unnecessary header, add placeholder text.	mxiuwang
+	Emoji_Widget tests.	mxiuwang
+	Revert accidental change to dependencies.py and Akim's PR.	mxiuwang
+	Fix automatically-raised whitespace issues.	mxiuwang
+	Fix automatically-raised whitespace issues.	mxiuwang

Diff:

Revision 3 (+2044 -1422)

Show changes

	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/forms/emoji_settings.py
	reviewboard/admin/tests/test_emoji_widget.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
Show all issues
```
F811 redefinition of unused 'ListEditWidget' from line 5
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
Show all issues
```
F811 redefinition of unused 'forms' from line 3
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
Show all issues
```
F401 'django.forms' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ':'
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ':'
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ':'
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
Show all issues
```
E261 at least two spaces before inline comment
```

reviewboard/admin/forms/emoji_settings.py (Diff revision 3)

Show all issues

E123 closing bracket does not match indentation of opening bracket's line

reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
Show all issues
```
E501 line too long (90 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
Show all issues
```
E301 expected 1 blank line, found 0
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 3)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 3)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 3)
Show all issues
```
E501 line too long (104 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 3)
Show all issues
```
E501 line too long (81 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 3)
Show all issues
```
E501 line too long (87 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 3)
Show all issues
```
E501 line too long (86 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 3)
Show all issues
```
E501 line too long (91 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 3)
Show all issues
```
E501 line too long (90 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 3)
Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/urls.py (Diff revision 3)
Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/views.py (Diff revision 3)
Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/views.py (Diff revision 3)
Show all issues
```
E501 line too long (97 > 79 characters)
```

Description:

~		Adds a page to the admint panel which allows an admin to upload a custom emoji by uploading a name, shortcode, description, and image. These fields are editable whenever the user re-vists the page. The emoji data is loaded from, and saved into SiteConfiguration, while the image data is loaded from and saved to DefaultStorage.
	~	Adds a page to the admin panel which allows an admin to upload a custom emoji
	+	by uploading a name, shortcode, description, and image. These fields are
	+	editable whenever the user re-vists the page. The emoji data is loaded from,
	+	and saved into SiteConfiguration, while the image data is loaded from and
	+	saved to DefaultStorage.



		Further work that needs to be done:
~		* Enforcing mandatory fields that user must fill out before clicking "Save", so as to not raise an error.
~		* Adding labels to the form fields, and removing the extra "name" field at the very top of the form.
~		* Rendering a preview of the emoji when loading the page (through get_context() in EmojiFileUpload).
	~	* Adding labels to the form fields, and removing the extra "name" field at
	~	the very top of the form.
	~	* Rendering a preview of the emoji when loading the page (through get_context()
	+	in EmojiFileUpload).

Testing Done:

	+	Unit testing: Unit test suites for class Emoji_Widget
	+	Local testing: making sure the app runs property with print() statements.

Commits:

	Summary	Author
-	Upload Emojis wip.	mxiuwang
-	Upload Emojis using Models model, soon to be changed to Forms model.	mxiuwang
-	[WIP] use forms to upload images	mxiuwang
-	[WIP] load() and save() functions.	mxiuwang
-	[WIP] Emoji working, trying to validate save().	mxiuwang
-	WIP save() function in emoji_settings,py	mxiuwang
-	save runs but does not fetch data from forms.	mxiuwang
-	[WIP] cannot fetch data from forms.	mxiuwang
-	[WIP] Add ListEditDictionaryField for parsing input.	mxiuwang
-	ListEditDictionaryField working.	mxiuwang
-	save working except images.	mxiuwang
-	load() function loads data (except images.	mxiuwang
-	Images saved to DefaultStorage, not yet rendered on load().	mxiuwang
-	[WIP] Rendering Images.	mxiuwang
-	[WIP] Render image previews.	mxiuwang
-	Add docstring, code cleanup.	mxiuwang
-	Undo accidental pull patch from Akim.	mxiuwang
-	Remove unnecessary header, add placeholder text.	mxiuwang
-	Emoji_Widget tests.	mxiuwang
-	Revert accidental change to dependencies.py and Akim's PR.	mxiuwang
-	Fix automatically-raised whitespace issues.	mxiuwang
-	Fix automatically-raised whitespace issues.	mxiuwang
+	Upload Emojis wip.	mxiuwang
+	Upload Emojis using Models model, soon to be changed to Forms model.	mxiuwang
+	[WIP] use forms to upload images	mxiuwang
+	[WIP] load() and save() functions.	mxiuwang
+	[WIP] Emoji working, trying to validate save().	mxiuwang
+	WIP save() function in emoji_settings,py	mxiuwang
+	save runs but does not fetch data from forms.	mxiuwang
+	[WIP] cannot fetch data from forms.	mxiuwang
+	[WIP] Add ListEditDictionaryField for parsing input.	mxiuwang
+	ListEditDictionaryField working.	mxiuwang
+	save working except images.	mxiuwang
+	load() function loads data (except images.	mxiuwang
+	Images saved to DefaultStorage, not yet rendered on load().	mxiuwang
+	[WIP] Rendering Images.	mxiuwang
+	[WIP] Render image previews.	mxiuwang
+	Add docstring, code cleanup.	mxiuwang
+	Undo accidental pull patch from Akim.	mxiuwang
+	Remove unnecessary header, add placeholder text.	mxiuwang
+	Emoji_Widget tests.	mxiuwang
+	Revert accidental change to dependencies.py and Akim's PR.	mxiuwang
+	Fix automatically-raised whitespace issues.	mxiuwang
+	Fix automatically-raised whitespace issues.	mxiuwang
+	Fix suggestions.	mxiuwang

Diff:

Revision 4 (+2203 -1501)

Show changes

	reviewboard/admin/form_widgets.py
	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/forms/emoji_settings.py
	reviewboard/admin/tests/test_emoji_widget.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/form_widgets.py (Diff revision 4)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/form_widgets.py (Diff revision 4)
Show all issues
```
E302 expected 2 blank lines, found 0
```
reviewboard/admin/form_widgets.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ':'
```
reviewboard/admin/form_widgets.py (Diff revision 4)
Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/form_widgets.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ':'
```
reviewboard/admin/form_widgets.py (Diff revision 4)
Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/form_widgets.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ':'
```
reviewboard/admin/form_widgets.py (Diff revision 4)
Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/form_widgets.py (Diff revision 4)
Show all issues
```
E261 at least two spaces before inline comment
```

reviewboard/admin/form_widgets.py (Diff revision 4)

Show all issues

E123 closing bracket does not match indentation of opening bracket's line

reviewboard/admin/form_widgets.py (Diff revision 4)
Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/admin/form_widgets.py (Diff revision 4)
Show all issues
```
E501 line too long (90 > 79 characters)
```
reviewboard/admin/form_widgets.py (Diff revision 4)
Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
Show all issues
```
F811 redefinition of unused 'ListEditWidget' from line 4
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
Show all issues
```
F401 'django.forms' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
Show all issues
```
E301 expected 1 blank line, found 0
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 4)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 4)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 4)
Show all issues
```
E501 line too long (104 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 4)
Show all issues
```
E501 line too long (81 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 4)
Show all issues
```
E501 line too long (87 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 4)
Show all issues
```
E501 line too long (86 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 4)
Show all issues
```
E501 line too long (91 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 4)
Show all issues
```
E501 line too long (90 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 4)
Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/urls.py (Diff revision 4)
Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/views.py (Diff revision 4)
Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/views.py (Diff revision 4)
Show all issues
```
E501 line too long (97 > 79 characters)
```

Depends On:

+	~~11821 - Add a setting for mapping file extensions to syntax highlighters for diffs~~

Commits:

	Summary	Author
-	Upload Emojis wip.	mxiuwang
-	Upload Emojis using Models model, soon to be changed to Forms model.	mxiuwang
-	[WIP] use forms to upload images	mxiuwang
-	[WIP] load() and save() functions.	mxiuwang
-	[WIP] Emoji working, trying to validate save().	mxiuwang
-	WIP save() function in emoji_settings,py	mxiuwang
-	save runs but does not fetch data from forms.	mxiuwang
-	[WIP] cannot fetch data from forms.	mxiuwang
-	[WIP] Add ListEditDictionaryField for parsing input.	mxiuwang
-	ListEditDictionaryField working.	mxiuwang
-	save working except images.	mxiuwang
-	load() function loads data (except images.	mxiuwang
-	Images saved to DefaultStorage, not yet rendered on load().	mxiuwang
-	[WIP] Rendering Images.	mxiuwang
-	[WIP] Render image previews.	mxiuwang
-	Add docstring, code cleanup.	mxiuwang
-	Undo accidental pull patch from Akim.	mxiuwang
-	Remove unnecessary header, add placeholder text.	mxiuwang
-	Emoji_Widget tests.	mxiuwang
-	Revert accidental change to dependencies.py and Akim's PR.	mxiuwang
-	Fix automatically-raised whitespace issues.	mxiuwang
-	Fix automatically-raised whitespace issues.	mxiuwang
-	Fix suggestions.	mxiuwang
+	Upload Emojis wip.	mxiuwang
+	Upload Emojis using Models model, soon to be changed to Forms model.	mxiuwang
+	[WIP] use forms to upload images	mxiuwang
+	[WIP] load() and save() functions.	mxiuwang
+	[WIP] Emoji working, trying to validate save().	mxiuwang
+	WIP save() function in emoji_settings,py	mxiuwang
+	save runs but does not fetch data from forms.	mxiuwang
+	[WIP] cannot fetch data from forms.	mxiuwang
+	[WIP] Add ListEditDictionaryField for parsing input.	mxiuwang
+	ListEditDictionaryField working.	mxiuwang
+	save working except images.	mxiuwang
+	load() function loads data (except images.	mxiuwang
+	Images saved to DefaultStorage, not yet rendered on load().	mxiuwang
+	[WIP] Rendering Images.	mxiuwang
+	[WIP] Render image previews.	mxiuwang
+	Add docstring, code cleanup.	mxiuwang
+	Undo accidental pull patch from Akim.	mxiuwang
+	Remove unnecessary header, add placeholder text.	mxiuwang
+	Emoji_Widget tests.	mxiuwang
+	Revert accidental change to dependencies.py and Akim's PR.	mxiuwang
+	Fix automatically-raised whitespace issues.	mxiuwang
+	Fix automatically-raised whitespace issues.	mxiuwang
+	Fix suggestions.	mxiuwang
+	Render custom emoji image preview.	mxiuwang

Diff:

Revision 5 (+2235 -1521)

Show changes

	reviewboard/admin/form_widgets.py
	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/forms/emoji_settings.py
	reviewboard/admin/tests/test_emoji_widget.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 38 failures.
```

reviewboard/admin/form_widgets.py (Diff revision 5)

Show all issues

F401 'django.core.files.storage.get_storage_class' imported but unused

reviewboard/admin/form_widgets.py (Diff revision 5)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/form_widgets.py (Diff revision 5)
Show all issues
```
E722 do not use bare 'except'
```
reviewboard/admin/form_widgets.py (Diff revision 5)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/form_widgets.py (Diff revision 5)
Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/form_widgets.py (Diff revision 5)
Show all issues
```
E302 expected 2 blank lines, found 0
```
reviewboard/admin/form_widgets.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ':'
```
reviewboard/admin/form_widgets.py (Diff revision 5)
Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/form_widgets.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ':'
```
reviewboard/admin/form_widgets.py (Diff revision 5)
Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/form_widgets.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ':'
```
reviewboard/admin/form_widgets.py (Diff revision 5)
Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/form_widgets.py (Diff revision 5)
Show all issues
```
E261 at least two spaces before inline comment
```

reviewboard/admin/form_widgets.py (Diff revision 5)

Show all issues

E123 closing bracket does not match indentation of opening bracket's line

reviewboard/admin/form_widgets.py (Diff revision 5)
Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/admin/form_widgets.py (Diff revision 5)
Show all issues
```
E501 line too long (90 > 79 characters)
```
reviewboard/admin/form_widgets.py (Diff revision 5)
Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
Show all issues
```
F811 redefinition of unused 'ListEditWidget' from line 4
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
Show all issues
```
F401 'django.forms' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
Show all issues
```
E501 line too long (87 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
Show all issues
```
E501 line too long (120 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
Show all issues
```
E301 expected 1 blank line, found 0
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 5)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 5)
Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 5)
Show all issues
```
E501 line too long (104 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 5)
Show all issues
```
E501 line too long (81 > 79 characters)
```

Description:

		Adds a page to the admin panel which allows an admin to upload a custom emoji
		by uploading a name, shortcode, description, and image. These fields are
		editable whenever the user re-vists the page. The emoji data is loaded from,
		and saved into SiteConfiguration, while the image data is loaded from and
		saved to DefaultStorage.



		Further work that needs to be done:
		* Adding labels to the form fields, and removing the extra "name" field at
~		the very top of the form.
~		* Rendering a preview of the emoji when loading the page (through get_context()
~		in EmojiFileUpload).
	~	the very top of the form.
	~
	~	Summary document in Notion: https://www.notion.so/reviewboard/Custom-Emojis-Progress-6644ec34f5a84c6ab957ea11ae2b7259

Commits:

	Summary	Author
-	Upload Emojis wip.	mxiuwang
-	Upload Emojis using Models model, soon to be changed to Forms model.	mxiuwang
-	[WIP] use forms to upload images	mxiuwang
-	[WIP] load() and save() functions.	mxiuwang
-	[WIP] Emoji working, trying to validate save().	mxiuwang
-	WIP save() function in emoji_settings,py	mxiuwang
-	save runs but does not fetch data from forms.	mxiuwang
-	[WIP] cannot fetch data from forms.	mxiuwang
-	[WIP] Add ListEditDictionaryField for parsing input.	mxiuwang
-	ListEditDictionaryField working.	mxiuwang
-	save working except images.	mxiuwang
-	load() function loads data (except images.	mxiuwang
-	Images saved to DefaultStorage, not yet rendered on load().	mxiuwang
-	[WIP] Rendering Images.	mxiuwang
-	[WIP] Render image previews.	mxiuwang
-	Add docstring, code cleanup.	mxiuwang
-	Undo accidental pull patch from Akim.	mxiuwang
-	Remove unnecessary header, add placeholder text.	mxiuwang
-	Emoji_Widget tests.	mxiuwang
-	Revert accidental change to dependencies.py and Akim's PR.	mxiuwang
-	Fix automatically-raised whitespace issues.	mxiuwang
-	Fix automatically-raised whitespace issues.	mxiuwang
-	Fix suggestions.	mxiuwang
-	Render custom emoji image preview.	mxiuwang
+	Upload Emojis wip.	mxiuwang
+	Upload Emojis using Models model, soon to be changed to Forms model.	mxiuwang
+	[WIP] use forms to upload images	mxiuwang
+	[WIP] load() and save() functions.	mxiuwang
+	[WIP] Emoji working, trying to validate save().	mxiuwang
+	WIP save() function in emoji_settings,py	mxiuwang
+	save runs but does not fetch data from forms.	mxiuwang
+	[WIP] cannot fetch data from forms.	mxiuwang
+	[WIP] Add ListEditDictionaryField for parsing input.	mxiuwang
+	ListEditDictionaryField working.	mxiuwang
+	save working except images.	mxiuwang
+	load() function loads data (except images.	mxiuwang
+	Images saved to DefaultStorage, not yet rendered on load().	mxiuwang
+	[WIP] Rendering Images.	mxiuwang
+	[WIP] Render image previews.	mxiuwang
+	Add docstring, code cleanup.	mxiuwang
+	Undo accidental pull patch from Akim.	mxiuwang
+	Remove unnecessary header, add placeholder text.	mxiuwang
+	Emoji_Widget tests.	mxiuwang
+	Revert accidental change to dependencies.py and Akim's PR.	mxiuwang
+	Fix automatically-raised whitespace issues.	mxiuwang
+	Fix automatically-raised whitespace issues.	mxiuwang
+	Fix suggestions.	mxiuwang
+	Render custom emoji image preview.	mxiuwang
+	Fix flake8 suggestions.	mxiuwang

Diff:

Revision 6 (+2269 -1543)

Show changes

	reviewboard/admin/form_widgets.py
	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/forms/emoji_settings.py
	reviewboard/admin/tests/test_emoji_widget.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/form_widgets.py (Diff revision 6)

Show all issues

F841 local variable 'message' is assigned to but never used

reviewboard/admin/form_widgets.py (Diff revision 6)
Show all issues
```
E126 continuation line over-indented for hanging indent
```
reviewboard/admin/form_widgets.py (Diff revision 6)
Show all issues
```
E126 continuation line over-indented for hanging indent
```
reviewboard/admin/form_widgets.py (Diff revision 6)
Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/form_widgets.py (Diff revision 6)
Show all issues
```
E502 the backslash is redundant between brackets
```
reviewboard/admin/form_widgets.py (Diff revision 6)
Show all issues
```
E128 continuation line under-indented for visual indent
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 6)
Show all issues
```
E502 the backslash is redundant between brackets
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 6)
Show all issues
```
E131 continuation line unaligned for hanging indent
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 6)
Show all issues
```
E501 line too long (85 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 6)
Show all issues
```
E501 line too long (87 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 6)
Show all issues
```
E501 line too long (86 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 6)
Show all issues
```
E501 line too long (91 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 6)
Show all issues
```
E501 line too long (90 > 79 characters)
```
reviewboard/admin/tests/test_emoji_widget.py (Diff revision 6)
Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/urls.py (Diff revision 6)
Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/views.py (Diff revision 6)
Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/views.py (Diff revision 6)
Show all issues
```
E501 line too long (97 > 79 characters)
```

You have a pending review.

Review Board 5.0.1 alpha 0 (dev)

Custom Admin Emoji Panel (Reviewboard)

flake8

Summary:

Commits:

Diff:

Checks run (2 failed)

flake8

JSHint

Summary:

Description:

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Description:

Testing Done:

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Depends On:

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Description:

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8