• 
      

    Update the paths to the node_modules binaries when building extensions.

    Review Request #11867 — Created Oct. 21, 2021 and submitted

    Information

    Djblets
    release-2.x

    Reviewers

    Recent changes to Babel installation altered the path in which we could
    find the babel binary. The Djblets package building was updated
    accordingly, and was later revised to use the future-proof symlinks for
    LessCSS, UglifyJS, and Babel binaries that are placed in
    node_modules/.bin/. However, extension packaging computes paths for
    these as well, and neither change updated them.

    This change fixes up those paths, referencing the ones in .bin. This
    should be the last time we need to modify these paths, since we're no
    longer drilling into module-specific directories. With this fix,
    extension packages can be built again.

    Successfully built Power Pack packages.

    Unit tests pass.

    Summary ID
    Update the paths to the node_modules binaries when building extensions.
    Recent changes to Babel installation altered the path in which we could find the babel binary. The Djblets package building was updated accordingly, and was later revised to use the future-proof symlinks for LessCSS, UglifyJS, and Babel binaries that are placed in `node_modules/.bin/`. However, extension packaging computes paths for these as well, and neither change updated them. This change fixes up those paths, referencing the ones in `.bin`. This should be the last time we need to modify these paths, since we're no longer drilling into module-specific directories. With this fix, extension packages can be built again.
    b61d5370f38759c884b7bbd11d208950d3271a53
    david
    1. Ship It!
    2. 
        
    chipx86
    Review request changed
    Status:
    Completed
    Change Summary:
    Pushed to release-2.x (cf3f0b1)