Summary

[WIP] Upload Emojis.

Review Request #11863 — Created Oct. 23, 2021 and discarded Oct. 26, 2021, 9:24 a.m.

Information

Owner

mxwang

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

WIP Upload Emojis using Models model, soon to be changed to Forms model.

Testing Done

Commits

Summary	ID	Author
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang

Issues

Description	From	Last Updated
E302 expected 2 blank lines, found 1	reviewbot	Oct. 23, 2021, 8:40 p.m.
W292 no newline at end of file	reviewbot	Oct. 23, 2021, 8:40 p.m.
W291 trailing whitespace	reviewbot	Oct. 23, 2021, 8:40 p.m.
W292 no newline at end of file	reviewbot	Oct. 23, 2021, 8:40 p.m.
F403 'from .models import *' used; unable to detect undefined names	reviewbot	Oct. 23, 2021, 8:40 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Oct. 23, 2021, 8:40 p.m.
E226 missing whitespace around arithmetic operator	reviewbot	Oct. 23, 2021, 8:40 p.m.
E226 missing whitespace around arithmetic operator	reviewbot	Oct. 23, 2021, 8:40 p.m.
E225 missing whitespace around operator	reviewbot	Oct. 23, 2021, 8:40 p.m.
E231 missing whitespace after ','	reviewbot	Oct. 23, 2021, 8:40 p.m.
E231 missing whitespace after ','	reviewbot	Oct. 23, 2021, 8:40 p.m.
E231 missing whitespace after ','	reviewbot	Oct. 23, 2021, 8:40 p.m.
F841 local variable 'display_emoji' is assigned to but never used	reviewbot	Oct. 23, 2021, 8:40 p.m.
F405 'CustomEmojis' may be undefined, or defined from star imports: .models	reviewbot	Oct. 23, 2021, 8:40 p.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	Oct. 23, 2021, 8:40 p.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	Oct. 23, 2021, 8:40 p.m.
W292 no newline at end of file	reviewbot	Oct. 23, 2021, 8:40 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/models.py (Diff revision 1)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/models.py (Diff revision 1)
An issue was opened. Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/urls.py (Diff revision 1)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/urls.py (Diff revision 1)
An issue was opened. Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/views.py (Diff revision 1)
An issue was opened. Show all issues
```
F403 'from .models import *' used; unable to detect undefined names
```
reviewboard/admin/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E226 missing whitespace around arithmetic operator
```
reviewboard/admin/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E226 missing whitespace around arithmetic operator
```
reviewboard/admin/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E225 missing whitespace around operator
```
reviewboard/admin/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/views.py (Diff revision 1)
An issue was opened. Show all issues
```
F841 local variable 'display_emoji' is assigned to but never used
```

reviewboard/admin/views.py (Diff revision 1)

An issue was opened. Show all issues

F405 'CustomEmojis' may be undefined, or defined from star imports: .models

reviewboard/admin/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
reviewboard/admin/views.py (Diff revision 1)
An issue was opened. Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
reviewboard/admin/views.py (Diff revision 1)
An issue was opened. Show all issues
```
W292 no newline at end of file
```

Summary:

-	Upload Emojis wip.
+	[WIP] Upload Emojis.

Review Board 7.0 alpha 0 (dev)

[WIP] Upload Emojis.

Information

Reviewers

flake8

Summary:

Status: Discarded