Custom Admin Emoji Panel (Reviewboard)

 






 

 


  Review Request #11862
  —
  Created Nov. 3, 2021 and discarded  — Latest diff uploaded 

 


















 

  

   Information

  





 
 

  mxwang
 









 
 

  Review Board
 









 
 

  release-4.0.x
 









 
 

  
 









 
 

  
 






 




 

  

   Reviewers

  





 
 

  reviewboard
 









 
 

  
 






 








 





  


 
 

  
Adds a page to the admint panel which allows an admin to upload a custom emoji by uploading a name, shortcode, description, and image. These fields are editable whenever the user re-vists the page. The emoji data is loaded from, and saved into SiteConfiguration, while the image data is loaded from and saved to DefaultStorage.


Further work that needs to be done:
* Enforcing mandatory fields that user must fill out before clicking "Save", so as to not raise an error.
* Adding labels to the form fields, and removing the extra "name" field at the very top of the form. 
* Rendering a preview of the emoji when loading the page (through get_context() in EmojiFileUpload).

 








  


 
 

  

 







 









 





  








 




 







   

    
    
Diff Revision 12 (Latest)



    

 

 

 

 
orig
1
2
3
4
5
6
7
8
9
10
11
12

 



    


    

      
Commits

      

 

 

  
   First
   Last
  
  Summary
  ID
  Author
 



 
  
   
  
  
   
  
 
 
  
   
    
Upload Emojis wip.

   
  		
  81d9db02ab1196cf653dc46a1bc7789d57123591
  mxiuwang
 


 
  
   
  
  
   
  
 
 
  
   
    
Upload Emojis using Models model, soon to be changed to Forms model.

   
  		
  441e0104edac5f50a79c1679f9fda40e5f2cf126
  mxiuwang
 


 
  
   
  
  
   
  
 
 
  
   
    
[WIP] use forms to upload images

   
  		
  146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2
  mxiuwang
 


 
  
   
  
  
   
  
 
 
  
   
    
[WIP] load() and save() functions.

   
  		
  bfa9548136e4a6ebe929a4f2f4a25d66e49abc48
  mxiuwang
 


 
  
   
  
  
   
  
 
 
  
   
    
[WIP] Emoji working, trying to validate save().

   
  		
  d10c4cd84e9463db47c12985406532600b42d944
  mxiuwang
 


 
  
   
  
  
   
  
 
 
  
   
    
WIP save() function in emoji_settings,py

   
  		
  58b772e54a253940df0addb7a3ca676bdb0b20fc
  mxiuwang
 


 
  
   
  
  
   
  
 
 
  
   
    
save runs but does not fetch data from forms.

   
  		
  395bd2aeb607fb12ea01454a7f45daaf9d86eb51
  mxiuwang
 


 
  
   
  
  
   
  
 
 
  
   
    
[WIP] cannot fetch data from forms.

   
  		
  44ea86374597f452717b9555ed843122b81c7a43
  mxiuwang
 


 
  
   
  
  
   
  
 
 
  
   
    
[WIP] Add ListEditDictionaryField for parsing input.

   
  		
  aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec
  mxiuwang
 


 
  
   
  
  
   
  
 
 
  
   
    
ListEditDictionaryField working.

   
  		
  b04ab1d482403d74c068d2357f5adba80412d4f1
  mxiuwang
 


 
  
   
  
  
   
  
 
 
  
   
    
save working except images.

   
  		
  05e73763cac1902c79b80131eacc8a579153e1ac
  mxiuwang
 


 
  
   
  
  
   
  
 
 
  
   
    
load() function loads data (except images.

   
  		
  aff938a30ff7e469d23ccc50fac55da63b84482e
  mxiuwang
 


 
  
   
  
  
   
  
 
 
  
   
    
Images saved to DefaultStorage, not yet rendered on load().

   
  		
  5aea766a9f2ac3c496a09a80727fd476aef95b71
  mxiuwang
 


 
  
   
  
  
   
  
 
 
  
   
    
[WIP] Rendering Images.

   
  		
  413a6479e991bef5aadbc49bd50d8c9185994ff9
  mxiuwang
 


 
  
   
  
  
   
  
 
 
  
   
    
[WIP] Render image previews.

   
  		
  deb9c6a9374fe41adc0fa2393e88c3ec7caa6acd
  mxiuwang
 


 
  
   
  
  
   
  
 
 
  
   
    
Add docstring, code cleanup.

   
  		
  a76d6448038388bfff67870a2ca170cb385a990b
  mxiuwang
 




    


    
    

   

  

 









 

  

   
    

     
      
      dev-requirements.txt
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/dependencies.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/staticbundles.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/admin/siteconfig.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/admin/urls.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/admin/views.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/admin/forms/emoji_settings.py
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/css/pages/image-review-ui.less
     
    

   
  

 



 

  

   
    

     
      
      reviewboard/static/rb/js/views/imageReviewableView.es6.js
     
    

   
  

 










     

    

   

  

  

   
   Loading...