Custom Admin Emoji Panel (Reviewboard)

Review Request #11862 — Created Nov. 3, 2021 and discarded

mxwang
Review Board
release-4.0.x
reviewboard

Adds a page to the admint panel which allows an admin to upload a custom emoji by uploading a name, shortcode, description, and image. These fields are editable whenever the user re-vists the page. The emoji data is loaded from, and saved into SiteConfiguration, while the image data is loaded from and saved to DefaultStorage.

Further work that needs to be done: * Enforcing mandatory fields that user must fill out before clicking "Save", so as to not raise an error. * Adding labels to the form fields, and removing the extra "name" field at the very top of the form. * Rendering a preview of the emoji when loading the page (through get_context() in EmojiFileUpload).



Summary Author
Upload Emojis wip.
mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
[WIP] use forms to upload images
mxiuwang
[WIP] load() and save() functions.
mxiuwang
[WIP] Emoji working, trying to validate save().
mxiuwang
WIP save() function in emoji_settings,py
mxiuwang
save runs but does not fetch data from forms.
mxiuwang
[WIP] cannot fetch data from forms.
mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.
mxiuwang
ListEditDictionaryField working.
mxiuwang
save working except images.
mxiuwang
load() function loads data (except images.
mxiuwang
Images saved to DefaultStorage, not yet rendered on load().
mxiuwang
[WIP] Rendering Images.
mxiuwang
[WIP] Render image previews.
mxiuwang
Add docstring, code cleanup.
mxiuwang
Description From Last Updated

F401 'django.utils.translation.ugettext' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (83 > 79 characters)

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

F403 'from .models import *' used; unable to detect undefined names

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E226 missing whitespace around arithmetic operator

reviewbotreviewbot

E226 missing whitespace around arithmetic operator

reviewbotreviewbot

E225 missing whitespace around operator

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

F841 local variable 'display_emoji' is assigned to but never used

reviewbotreviewbot

F405 'CustomEmojis' may be undefined, or defined from star imports: .models

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

F401 'django.utils.translation.ugettext' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (83 > 79 characters)

reviewbotreviewbot

F841 local variable 'emoji_image' is assigned to but never used

reviewbotreviewbot

E501 line too long (91 > 79 characters)

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

F403 'from .models import *' used; unable to detect undefined names

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E226 missing whitespace around arithmetic operator

reviewbotreviewbot

E226 missing whitespace around arithmetic operator

reviewbotreviewbot

E225 missing whitespace around operator

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

F841 local variable 'display_emoji' is assigned to but never used

reviewbotreviewbot

F405 'CustomEmojis' may be undefined, or defined from star imports: .models

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

F841 local variable 'emoji_image' is assigned to but never used

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

F841 local variable 'emoji_image' is assigned to but never used

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

F401 'djblets.util.compat.django.shortcuts.render' imported but unused

reviewbotreviewbot

F401 'django.utils.translation.ugettext' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'ListEditWidget' from line 6

reviewbotreviewbot

F401 'djblets.forms.fields.ListEditField' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

F401 'uuid.uuid4' imported but unused

reviewbotreviewbot

F401 'djblets.util.compat.django.shortcuts.render' imported but unused

reviewbotreviewbot

F401 'django.utils.translation.ugettext' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'ListEditWidget' from line 6

reviewbotreviewbot

F401 'djblets.forms.fields.ListEditField' imported but unused

reviewbotreviewbot

F401 'os' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

F401 'uuid.uuid4' imported but unused

reviewbotreviewbot

F401 'django.forms.widgets.Select' imported but unused

reviewbotreviewbot

F401 'djblets.util.compat.django.shortcuts.render' imported but unused

reviewbotreviewbot

F401 'django.utils.translation.ugettext' imported but unused

reviewbotreviewbot

F401 'pygments.lexers.get_all_lexers' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'ListEditWidget' from line 6

reviewbotreviewbot

F401 'djblets.forms.fields.ListEditField' imported but unused

reviewbotreviewbot

F401 'os' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E123 closing bracket does not match indentation of opening bracket's line

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (134 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

You don't need to deal with setting siteconfig. I think calling super(EmojiSettingsForm, self).save() handles it. This might be related to ...

maubinmaubin

F401 'uuid.uuid4' imported but unused

reviewbotreviewbot

F401 'django.forms.widgets.Select' imported but unused

reviewbotreviewbot

F401 'djblets.util.compat.django.shortcuts.render' imported but unused

reviewbotreviewbot

F401 'django.utils.translation.ugettext' imported but unused

reviewbotreviewbot

F401 'pygments.lexers.get_all_lexers' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'ListEditWidget' from line 6

reviewbotreviewbot

F401 'djblets.forms.fields.ListEditField' imported but unused

reviewbotreviewbot

F401 'os' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E123 closing bracket does not match indentation of opening bracket's line

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (134 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

F401 'uuid.uuid4' imported but unused

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

F401 'djblets.util.compat.django.shortcuts.render' imported but unused

reviewbotreviewbot

F401 'django.utils.translation.ugettext' imported but unused

reviewbotreviewbot

F401 'pygments.lexers.get_all_lexers' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'ListEditWidget' from line 7

reviewbotreviewbot

F401 'djblets.forms.fields.ListEditField' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'forms' from line 5

reviewbotreviewbot

F401 'json' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (134 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

F401 'uuid.uuid4' imported but unused

reviewbotreviewbot

F401 'djblets.forms.widgets.EmojiFileInput' imported but unused

reviewbotreviewbot

F401 'djblets.util.compat.django.shortcuts.render' imported but unused

reviewbotreviewbot

F401 'django.utils.translation.ugettext' imported but unused

reviewbotreviewbot

F401 'pygments.lexers.get_all_lexers' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'ListEditWidget' from line 7

reviewbotreviewbot

F401 'djblets.forms.fields.ListEditField' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'forms' from line 5

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E123 closing bracket does not match indentation of opening bracket's line

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (134 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

F811 redefinition of unused 'ListEditWidget' from line 5

reviewbotreviewbot

F811 redefinition of unused 'forms' from line 3

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E123 closing bracket does not match indentation of opening bracket's line

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E501 line too long (90 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

Col: 46 Missing semicolon.

reviewbotreviewbot

Col: 72 Missing semicolon.

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Commits:

Summary Author
-
Upload Emojis wip.
mxiuwang
-
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
-
[WIP] use forms to upload images
mxiuwang
-
[WIP] load() and save() functions.
mxiuwang
+
Upload Emojis wip.
mxiuwang
+
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
+
[WIP] use forms to upload images
mxiuwang
+
[WIP] load() and save() functions.
mxiuwang
+
[WIP] Emoji working, trying to validate save().
mxiuwang

Diff:

Revision 2 (+469 -45)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Commits:

Summary Author
-
Upload Emojis wip.
mxiuwang
-
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
-
[WIP] use forms to upload images
mxiuwang
-
[WIP] load() and save() functions.
mxiuwang
-
[WIP] Emoji working, trying to validate save().
mxiuwang
+
Upload Emojis wip.
mxiuwang
+
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
+
[WIP] use forms to upload images
mxiuwang
+
[WIP] load() and save() functions.
mxiuwang
+
[WIP] Emoji working, trying to validate save().
mxiuwang
+
WIP save() function in emoji_settings,py
mxiuwang

Diff:

Revision 3 (+618 -126)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Commits:

Summary Author
-
Upload Emojis wip.
mxiuwang
-
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
-
[WIP] use forms to upload images
mxiuwang
-
[WIP] load() and save() functions.
mxiuwang
-
[WIP] Emoji working, trying to validate save().
mxiuwang
-
WIP save() function in emoji_settings,py
mxiuwang
+
Upload Emojis wip.
mxiuwang
+
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
+
[WIP] use forms to upload images
mxiuwang
+
[WIP] load() and save() functions.
mxiuwang
+
[WIP] Emoji working, trying to validate save().
mxiuwang
+
WIP save() function in emoji_settings,py
mxiuwang
+
save runs but does not fetch data from forms.
mxiuwang

Diff:

Revision 4 (+659 -167)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Commits:

Summary Author
-
Upload Emojis wip.
mxiuwang
-
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
-
[WIP] use forms to upload images
mxiuwang
-
[WIP] load() and save() functions.
mxiuwang
-
[WIP] Emoji working, trying to validate save().
mxiuwang
-
WIP save() function in emoji_settings,py
mxiuwang
-
save runs but does not fetch data from forms.
mxiuwang
+
Upload Emojis wip.
mxiuwang
+
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
+
[WIP] use forms to upload images
mxiuwang
+
[WIP] load() and save() functions.
mxiuwang
+
[WIP] Emoji working, trying to validate save().
mxiuwang
+
WIP save() function in emoji_settings,py
mxiuwang
+
save runs but does not fetch data from forms.
mxiuwang
+
[WIP] cannot fetch data from forms.
mxiuwang

Diff:

Revision 5 (+1083 -197)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Commits:

Summary Author
-
Upload Emojis wip.
mxiuwang
-
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
-
[WIP] use forms to upload images
mxiuwang
-
[WIP] load() and save() functions.
mxiuwang
-
[WIP] Emoji working, trying to validate save().
mxiuwang
-
WIP save() function in emoji_settings,py
mxiuwang
-
save runs but does not fetch data from forms.
mxiuwang
-
[WIP] cannot fetch data from forms.
mxiuwang
+
Upload Emojis wip.
mxiuwang
+
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
+
[WIP] use forms to upload images
mxiuwang
+
[WIP] load() and save() functions.
mxiuwang
+
[WIP] Emoji working, trying to validate save().
mxiuwang
+
WIP save() function in emoji_settings,py
mxiuwang
+
save runs but does not fetch data from forms.
mxiuwang
+
[WIP] cannot fetch data from forms.
mxiuwang
+
[WIP] Add ListEditDictionaryField for parsing input.
mxiuwang

Diff:

Revision 6 (+1070 -388)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Commits:

Summary Author
-
Upload Emojis wip.
mxiuwang
-
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
-
[WIP] use forms to upload images
mxiuwang
-
[WIP] load() and save() functions.
mxiuwang
-
[WIP] Emoji working, trying to validate save().
mxiuwang
-
WIP save() function in emoji_settings,py
mxiuwang
-
save runs but does not fetch data from forms.
mxiuwang
-
[WIP] cannot fetch data from forms.
mxiuwang
-
[WIP] Add ListEditDictionaryField for parsing input.
mxiuwang
+
Upload Emojis wip.
mxiuwang
+
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
+
[WIP] use forms to upload images
mxiuwang
+
[WIP] load() and save() functions.
mxiuwang
+
[WIP] Emoji working, trying to validate save().
mxiuwang
+
WIP save() function in emoji_settings,py
mxiuwang
+
save runs but does not fetch data from forms.
mxiuwang
+
[WIP] cannot fetch data from forms.
mxiuwang
+
[WIP] Add ListEditDictionaryField for parsing input.
mxiuwang
+
ListEditDictionaryField working.
mxiuwang

Diff:

Revision 7 (+1056 -434)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Description:

~  

[WIP] Upload Emojis using Models model, soon to be changed to Forms model.

  ~

Upload Emojis using Forms

Commits:

Summary Author
-
Upload Emojis wip.
mxiuwang
-
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
-
[WIP] use forms to upload images
mxiuwang
-
[WIP] load() and save() functions.
mxiuwang
-
[WIP] Emoji working, trying to validate save().
mxiuwang
-
WIP save() function in emoji_settings,py
mxiuwang
-
save runs but does not fetch data from forms.
mxiuwang
-
[WIP] cannot fetch data from forms.
mxiuwang
-
[WIP] Add ListEditDictionaryField for parsing input.
mxiuwang
-
ListEditDictionaryField working.
mxiuwang
+
Upload Emojis wip.
mxiuwang
+
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
+
[WIP] use forms to upload images
mxiuwang
+
[WIP] load() and save() functions.
mxiuwang
+
[WIP] Emoji working, trying to validate save().
mxiuwang
+
WIP save() function in emoji_settings,py
mxiuwang
+
save runs but does not fetch data from forms.
mxiuwang
+
[WIP] cannot fetch data from forms.
mxiuwang
+
[WIP] Add ListEditDictionaryField for parsing input.
mxiuwang
+
ListEditDictionaryField working.
mxiuwang
+
save working except images.
mxiuwang

Diff:

Revision 8 (+1041 -575)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

maubin
  1. 
      
  2. You don't need to deal with setting siteconfig. I think calling super(EmojiSettingsForm, self).save() handles it. This might be related to your missing file problem, but not sure.

  3. 
      
mxwang
Review request changed

Commits:

Summary Author
-
Upload Emojis wip.
mxiuwang
-
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
-
[WIP] use forms to upload images
mxiuwang
-
[WIP] load() and save() functions.
mxiuwang
-
[WIP] Emoji working, trying to validate save().
mxiuwang
-
WIP save() function in emoji_settings,py
mxiuwang
-
save runs but does not fetch data from forms.
mxiuwang
-
[WIP] cannot fetch data from forms.
mxiuwang
-
[WIP] Add ListEditDictionaryField for parsing input.
mxiuwang
-
ListEditDictionaryField working.
mxiuwang
-
save working except images.
mxiuwang
+
Upload Emojis wip.
mxiuwang
+
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
+
[WIP] use forms to upload images
mxiuwang
+
[WIP] load() and save() functions.
mxiuwang
+
[WIP] Emoji working, trying to validate save().
mxiuwang
+
WIP save() function in emoji_settings,py
mxiuwang
+
save runs but does not fetch data from forms.
mxiuwang
+
[WIP] cannot fetch data from forms.
mxiuwang
+
[WIP] Add ListEditDictionaryField for parsing input.
mxiuwang
+
ListEditDictionaryField working.
mxiuwang
+
save working except images.
mxiuwang
+
load() function loads data (except images.
mxiuwang

Diff:

Revision 9 (+1022 -622)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Commits:

Summary Author
-
Upload Emojis wip.
mxiuwang
-
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
-
[WIP] use forms to upload images
mxiuwang
-
[WIP] load() and save() functions.
mxiuwang
-
[WIP] Emoji working, trying to validate save().
mxiuwang
-
WIP save() function in emoji_settings,py
mxiuwang
-
save runs but does not fetch data from forms.
mxiuwang
-
[WIP] cannot fetch data from forms.
mxiuwang
-
[WIP] Add ListEditDictionaryField for parsing input.
mxiuwang
-
ListEditDictionaryField working.
mxiuwang
-
save working except images.
mxiuwang
-
load() function loads data (except images.
mxiuwang
+
Upload Emojis wip.
mxiuwang
+
Upload Emojis using Models model, soon to be changed to Forms model.
mxiuwang
+
[WIP] use forms to upload images
mxiuwang
+
[WIP] load() and save() functions.
mxiuwang
+
[WIP] Emoji working, trying to validate save().
mxiuwang
+
WIP save() function in emoji_settings,py
mxiuwang
+
save runs but does not fetch data from forms.
mxiuwang
+
[WIP] cannot fetch data from forms.
mxiuwang
+
[WIP] Add ListEditDictionaryField for parsing input.
mxiuwang
+
ListEditDictionaryField working.
mxiuwang
+
save working except images.
mxiuwang
+
load() function loads data (except images.
mxiuwang
+
Images saved to DefaultStorage, not yet rendered on load().
mxiuwang

Diff:

Revision 10 (+1086 -656)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8