Custom Admin Emoji Panel (Reviewboard)

Review Request #11862 — Created Nov. 3, 2021 and discarded

Information

Review Board
release-4.0.x

Reviewers

Adds a page to the admint panel which allows an admin to upload a custom emoji by uploading a name, shortcode, description, and image. These fields are editable whenever the user re-vists the page. The emoji data is loaded from, and saved into SiteConfiguration, while the image data is loaded from and saved to DefaultStorage.

Further work that needs to be done: * Enforcing mandatory fields that user must fill out before clicking "Save", so as to not raise an error. * Adding labels to the form fields, and removing the extra "name" field at the very top of the form. * Rendering a preview of the emoji when loading the page (through get_context() in EmojiFileUpload).


 
Summary ID Author
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
WIP save() function in emoji_settings,py
58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang
save runs but does not fetch data from forms.
395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang
[WIP] cannot fetch data from forms.
44ea86374597f452717b9555ed843122b81c7a43 mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.
aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang
ListEditDictionaryField working.
b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang
save working except images.
05e73763cac1902c79b80131eacc8a579153e1ac mxiuwang
load() function loads data (except images.
aff938a30ff7e469d23ccc50fac55da63b84482e mxiuwang
Images saved to DefaultStorage, not yet rendered on load().
5aea766a9f2ac3c496a09a80727fd476aef95b71 mxiuwang
[WIP] Rendering Images.
413a6479e991bef5aadbc49bd50d8c9185994ff9 mxiuwang
[WIP] Render image previews.
deb9c6a9374fe41adc0fa2393e88c3ec7caa6acd mxiuwang
Add docstring, code cleanup.
a76d6448038388bfff67870a2ca170cb385a990b mxiuwang
Description From Last Updated

F401 'django.utils.translation.ugettext' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (83 > 79 characters)

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

F403 'from .models import *' used; unable to detect undefined names

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E226 missing whitespace around arithmetic operator

reviewbotreviewbot

E226 missing whitespace around arithmetic operator

reviewbotreviewbot

E225 missing whitespace around operator

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

F841 local variable 'display_emoji' is assigned to but never used

reviewbotreviewbot

F405 'CustomEmojis' may be undefined, or defined from star imports: .models

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

F401 'django.utils.translation.ugettext' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (83 > 79 characters)

reviewbotreviewbot

F841 local variable 'emoji_image' is assigned to but never used

reviewbotreviewbot

E501 line too long (91 > 79 characters)

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

F403 'from .models import *' used; unable to detect undefined names

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E226 missing whitespace around arithmetic operator

reviewbotreviewbot

E226 missing whitespace around arithmetic operator

reviewbotreviewbot

E225 missing whitespace around operator

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

F841 local variable 'display_emoji' is assigned to but never used

reviewbotreviewbot

F405 'CustomEmojis' may be undefined, or defined from star imports: .models

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

E251 unexpected spaces around keyword / parameter equals

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

F841 local variable 'emoji_image' is assigned to but never used

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

F841 local variable 'emoji_image' is assigned to but never used

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W292 no newline at end of file

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

F401 'djblets.util.compat.django.shortcuts.render' imported but unused

reviewbotreviewbot

F401 'django.utils.translation.ugettext' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'ListEditWidget' from line 6

reviewbotreviewbot

F401 'djblets.forms.fields.ListEditField' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

F401 'uuid.uuid4' imported but unused

reviewbotreviewbot

F401 'djblets.util.compat.django.shortcuts.render' imported but unused

reviewbotreviewbot

F401 'django.utils.translation.ugettext' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'ListEditWidget' from line 6

reviewbotreviewbot

F401 'djblets.forms.fields.ListEditField' imported but unused

reviewbotreviewbot

F401 'os' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E301 expected 1 blank line, found 0

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E501 line too long (88 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

F401 'uuid.uuid4' imported but unused

reviewbotreviewbot

F401 'django.forms.widgets.Select' imported but unused

reviewbotreviewbot

F401 'djblets.util.compat.django.shortcuts.render' imported but unused

reviewbotreviewbot

F401 'django.utils.translation.ugettext' imported but unused

reviewbotreviewbot

F401 'pygments.lexers.get_all_lexers' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'ListEditWidget' from line 6

reviewbotreviewbot

F401 'djblets.forms.fields.ListEditField' imported but unused

reviewbotreviewbot

F401 'os' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E123 closing bracket does not match indentation of opening bracket's line

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (134 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

You don't need to deal with setting siteconfig. I think calling super(EmojiSettingsForm, self).save() handles it. This might be related to …

maubinmaubin

F401 'uuid.uuid4' imported but unused

reviewbotreviewbot

F401 'django.forms.widgets.Select' imported but unused

reviewbotreviewbot

F401 'djblets.util.compat.django.shortcuts.render' imported but unused

reviewbotreviewbot

F401 'django.utils.translation.ugettext' imported but unused

reviewbotreviewbot

F401 'pygments.lexers.get_all_lexers' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'ListEditWidget' from line 6

reviewbotreviewbot

F401 'djblets.forms.fields.ListEditField' imported but unused

reviewbotreviewbot

F401 'os' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E123 closing bracket does not match indentation of opening bracket's line

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (134 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

F401 'uuid.uuid4' imported but unused

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

F401 'djblets.util.compat.django.shortcuts.render' imported but unused

reviewbotreviewbot

F401 'django.utils.translation.ugettext' imported but unused

reviewbotreviewbot

F401 'pygments.lexers.get_all_lexers' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'ListEditWidget' from line 7

reviewbotreviewbot

F401 'djblets.forms.fields.ListEditField' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'forms' from line 5

reviewbotreviewbot

F401 'json' imported but unused

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (134 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

F401 'uuid.uuid4' imported but unused

reviewbotreviewbot

F401 'djblets.forms.widgets.EmojiFileInput' imported but unused

reviewbotreviewbot

F401 'djblets.util.compat.django.shortcuts.render' imported but unused

reviewbotreviewbot

F401 'django.utils.translation.ugettext' imported but unused

reviewbotreviewbot

F401 'pygments.lexers.get_all_lexers' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'ListEditWidget' from line 7

reviewbotreviewbot

F401 'djblets.forms.fields.ListEditField' imported but unused

reviewbotreviewbot

F811 redefinition of unused 'forms' from line 5

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E123 closing bracket does not match indentation of opening bracket's line

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E501 line too long (134 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E231 missing whitespace after ','

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

F811 redefinition of unused 'ListEditWidget' from line 5

reviewbotreviewbot

F811 redefinition of unused 'forms' from line 3

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E261 at least two spaces before inline comment

reviewbotreviewbot

E123 closing bracket does not match indentation of opening bracket's line

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

E501 line too long (80 > 79 characters)

reviewbotreviewbot

E501 line too long (90 > 79 characters)

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

E302 expected 2 blank lines, found 1

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W293 blank line contains whitespace

reviewbotreviewbot

W291 trailing whitespace

reviewbotreviewbot

Col: 46 Missing semicolon.

reviewbotreviewbot

Col: 72 Missing semicolon.

reviewbotreviewbot
Checks run (1 failed, 1 succeeded)
flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Commits:

Summary ID Author
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang

Diff:

Revision 2 (+469 -45)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Commits:

Summary ID Author
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
WIP save() function in emoji_settings,py
58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang

Diff:

Revision 3 (+618 -126)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Commits:

Summary ID Author
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
WIP save() function in emoji_settings,py
58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
WIP save() function in emoji_settings,py
58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang
save runs but does not fetch data from forms.
395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang

Diff:

Revision 4 (+659 -167)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Commits:

Summary ID Author
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
WIP save() function in emoji_settings,py
58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang
save runs but does not fetch data from forms.
395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
WIP save() function in emoji_settings,py
58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang
save runs but does not fetch data from forms.
395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang
[WIP] cannot fetch data from forms.
44ea86374597f452717b9555ed843122b81c7a43 mxiuwang

Diff:

Revision 5 (+1083 -197)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Commits:

Summary ID Author
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
WIP save() function in emoji_settings,py
58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang
save runs but does not fetch data from forms.
395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang
[WIP] cannot fetch data from forms.
44ea86374597f452717b9555ed843122b81c7a43 mxiuwang
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
WIP save() function in emoji_settings,py
58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang
save runs but does not fetch data from forms.
395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang
[WIP] cannot fetch data from forms.
44ea86374597f452717b9555ed843122b81c7a43 mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.
aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang

Diff:

Revision 6 (+1070 -388)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Commits:

Summary ID Author
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
WIP save() function in emoji_settings,py
58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang
save runs but does not fetch data from forms.
395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang
[WIP] cannot fetch data from forms.
44ea86374597f452717b9555ed843122b81c7a43 mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.
aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
WIP save() function in emoji_settings,py
58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang
save runs but does not fetch data from forms.
395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang
[WIP] cannot fetch data from forms.
44ea86374597f452717b9555ed843122b81c7a43 mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.
aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang
ListEditDictionaryField working.
b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang

Diff:

Revision 7 (+1056 -434)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Description:

~  

[WIP] Upload Emojis using Models model, soon to be changed to Forms model.

  ~

Upload Emojis using Forms

Commits:

Summary ID Author
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
WIP save() function in emoji_settings,py
58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang
save runs but does not fetch data from forms.
395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang
[WIP] cannot fetch data from forms.
44ea86374597f452717b9555ed843122b81c7a43 mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.
aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang
ListEditDictionaryField working.
b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
WIP save() function in emoji_settings,py
58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang
save runs but does not fetch data from forms.
395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang
[WIP] cannot fetch data from forms.
44ea86374597f452717b9555ed843122b81c7a43 mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.
aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang
ListEditDictionaryField working.
b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang
save working except images.
05e73763cac1902c79b80131eacc8a579153e1ac mxiuwang

Diff:

Revision 8 (+1041 -575)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

maubin
  1. 
      
  2. Show all issues

    You don't need to deal with setting siteconfig. I think calling super(EmojiSettingsForm, self).save() handles it. This might be related to your missing file problem, but not sure.

  3. 
      
mxwang
Review request changed

Commits:

Summary ID Author
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
WIP save() function in emoji_settings,py
58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang
save runs but does not fetch data from forms.
395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang
[WIP] cannot fetch data from forms.
44ea86374597f452717b9555ed843122b81c7a43 mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.
aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang
ListEditDictionaryField working.
b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang
save working except images.
05e73763cac1902c79b80131eacc8a579153e1ac mxiuwang
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
WIP save() function in emoji_settings,py
58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang
save runs but does not fetch data from forms.
395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang
[WIP] cannot fetch data from forms.
44ea86374597f452717b9555ed843122b81c7a43 mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.
aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang
ListEditDictionaryField working.
b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang
save working except images.
05e73763cac1902c79b80131eacc8a579153e1ac mxiuwang
load() function loads data (except images.
aff938a30ff7e469d23ccc50fac55da63b84482e mxiuwang

Diff:

Revision 9 (+1022 -622)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8

mxwang
Review request changed

Commits:

Summary ID Author
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
WIP save() function in emoji_settings,py
58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang
save runs but does not fetch data from forms.
395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang
[WIP] cannot fetch data from forms.
44ea86374597f452717b9555ed843122b81c7a43 mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.
aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang
ListEditDictionaryField working.
b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang
save working except images.
05e73763cac1902c79b80131eacc8a579153e1ac mxiuwang
load() function loads data (except images.
aff938a30ff7e469d23ccc50fac55da63b84482e mxiuwang
Upload Emojis wip.
81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.
441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang
[WIP] use forms to upload images
146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang
[WIP] load() and save() functions.
bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang
[WIP] Emoji working, trying to validate save().
d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
WIP save() function in emoji_settings,py
58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang
save runs but does not fetch data from forms.
395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang
[WIP] cannot fetch data from forms.
44ea86374597f452717b9555ed843122b81c7a43 mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.
aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang
ListEditDictionaryField working.
b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang
save working except images.
05e73763cac1902c79b80131eacc8a579153e1ac mxiuwang
load() function loads data (except images.
aff938a30ff7e469d23ccc50fac55da63b84482e mxiuwang
Images saved to DefaultStorage, not yet rendered on load().
5aea766a9f2ac3c496a09a80727fd476aef95b71 mxiuwang

Diff:

Revision 10 (+1086 -656)

Show changes

Checks run (1 failed, 1 succeeded)

flake8 failed.
JSHint passed.

flake8