Summary

Custom Admin Emoji Panel (Reviewboard)

Review Request #11862 — Created Nov. 3, 2021 and discarded Dec. 3, 2021, 10:31 a.m.

Information

Owner

mxwang

Repository

Review Board

Branch

release-4.0.x

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Adds a page to the admint panel which allows an admin to upload a custom emoji by uploading a name, shortcode, description, and image. These fields are editable whenever the user re-vists the page. The emoji data is loaded from, and saved into SiteConfiguration, while the image data is loaded from and saved to DefaultStorage.

Further work that needs to be done: * Enforcing mandatory fields that user must fill out before clicking "Save", so as to not raise an error. * Adding labels to the form fields, and removing the extra "name" field at the very top of the form. * Rendering a preview of the emoji when loading the page (through get_context() in EmojiFileUpload).

Testing Done

Commits

Summary	ID	Author
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
[WIP] cannot fetch data from forms.	44ea86374597f452717b9555ed843122b81c7a43	mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.	aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec	mxiuwang
ListEditDictionaryField working.	b04ab1d482403d74c068d2357f5adba80412d4f1	mxiuwang
save working except images.	05e73763cac1902c79b80131eacc8a579153e1ac	mxiuwang
load() function loads data (except images.	aff938a30ff7e469d23ccc50fac55da63b84482e	mxiuwang
Images saved to DefaultStorage, not yet rendered on load().	5aea766a9f2ac3c496a09a80727fd476aef95b71	mxiuwang
[WIP] Rendering Images.	413a6479e991bef5aadbc49bd50d8c9185994ff9	mxiuwang
[WIP] Render image previews.	deb9c6a9374fe41adc0fa2393e88c3ec7caa6acd	mxiuwang
Add docstring, code cleanup.	a76d6448038388bfff67870a2ca170cb385a990b	mxiuwang

Issues

Description	From	Last Updated
F401 'django.utils.translation.ugettext' imported but unused	reviewbot	Nov. 5, 2021, 8:04 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 5, 2021, 8:04 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 5, 2021, 8:04 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 5, 2021, 8:04 p.m.
E501 line too long (83 > 79 characters)	reviewbot	Nov. 5, 2021, 8:04 p.m.
W292 no newline at end of file	reviewbot	Nov. 5, 2021, 8:04 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 5, 2021, 8:04 p.m.
W292 no newline at end of file	reviewbot	Nov. 5, 2021, 8:04 p.m.
W291 trailing whitespace	reviewbot	Nov. 5, 2021, 8:04 p.m.
W292 no newline at end of file	reviewbot	Nov. 5, 2021, 8:04 p.m.
F403 'from .models import *' used; unable to detect undefined names	reviewbot	Nov. 5, 2021, 8:04 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 5, 2021, 8:04 p.m.
E226 missing whitespace around arithmetic operator	reviewbot	Nov. 5, 2021, 8:04 p.m.
E226 missing whitespace around arithmetic operator	reviewbot	Nov. 5, 2021, 8:04 p.m.
E225 missing whitespace around operator	reviewbot	Nov. 5, 2021, 8:04 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 5, 2021, 8:04 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 5, 2021, 8:04 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 5, 2021, 8:04 p.m.
F841 local variable 'display_emoji' is assigned to but never used	reviewbot	Nov. 5, 2021, 8:04 p.m.
F405 'CustomEmojis' may be undefined, or defined from star imports: .models	reviewbot	Nov. 5, 2021, 8:04 p.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	Nov. 5, 2021, 8:04 p.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	Nov. 5, 2021, 8:04 p.m.
W292 no newline at end of file	reviewbot	Nov. 5, 2021, 8:04 p.m.
F401 'django.utils.translation.ugettext' imported but unused	reviewbot	Nov. 12, 2021, 12:45 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 12, 2021, 12:45 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 12, 2021, 12:45 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 12, 2021, 12:45 p.m.
E501 line too long (83 > 79 characters)	reviewbot	Nov. 12, 2021, 12:45 p.m.
F841 local variable 'emoji_image' is assigned to but never used	reviewbot	Nov. 12, 2021, 12:45 p.m.
E501 line too long (91 > 79 characters)	reviewbot	Nov. 12, 2021, 12:45 p.m.
W292 no newline at end of file	reviewbot	Nov. 12, 2021, 12:45 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 12, 2021, 12:45 p.m.
W292 no newline at end of file	reviewbot	Nov. 12, 2021, 12:45 p.m.
W291 trailing whitespace	reviewbot	Nov. 12, 2021, 12:45 p.m.
W292 no newline at end of file	reviewbot	Nov. 12, 2021, 12:45 p.m.
F403 'from .models import *' used; unable to detect undefined names	reviewbot	Nov. 12, 2021, 12:45 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 12, 2021, 12:45 p.m.
E226 missing whitespace around arithmetic operator	reviewbot	Nov. 12, 2021, 12:45 p.m.
E226 missing whitespace around arithmetic operator	reviewbot	Nov. 12, 2021, 12:45 p.m.
E225 missing whitespace around operator	reviewbot	Nov. 12, 2021, 12:45 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 12, 2021, 12:45 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 12, 2021, 12:45 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 12, 2021, 12:45 p.m.
F841 local variable 'display_emoji' is assigned to but never used	reviewbot	Nov. 12, 2021, 12:45 p.m.
F405 'CustomEmojis' may be undefined, or defined from star imports: .models	reviewbot	Nov. 12, 2021, 12:45 p.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	Nov. 12, 2021, 12:45 p.m.
E251 unexpected spaces around keyword / parameter equals	reviewbot	Nov. 12, 2021, 12:45 p.m.
W292 no newline at end of file	reviewbot	Nov. 12, 2021, 12:45 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
W293 blank line contains whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
W293 blank line contains whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
F841 local variable 'emoji_image' is assigned to but never used	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
E501 line too long (88 > 79 characters)	reviewbot	Nov. 16, 2021, 6:48 a.m.
E301 expected 1 blank line, found 0	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
W292 no newline at end of file	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
W292 no newline at end of file	reviewbot	Nov. 16, 2021, 6:48 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 16, 2021, 6:48 a.m.
W291 trailing whitespace	reviewbot	Nov. 16, 2021, 6:48 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 18, 2021, 1:29 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
F841 local variable 'emoji_image' is assigned to but never used	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
E501 line too long (88 > 79 characters)	reviewbot	Nov. 18, 2021, 1:29 p.m.
E301 expected 1 blank line, found 0	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
W292 no newline at end of file	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
W292 no newline at end of file	reviewbot	Nov. 18, 2021, 1:29 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
W291 trailing whitespace	reviewbot	Nov. 18, 2021, 1:29 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 19, 2021, 11:31 a.m.
E301 expected 1 blank line, found 0	reviewbot	Nov. 19, 2021, 11:31 a.m.
E301 expected 1 blank line, found 0	reviewbot	Nov. 19, 2021, 11:31 a.m.
E301 expected 1 blank line, found 0	reviewbot	Nov. 19, 2021, 11:31 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 19, 2021, 11:31 a.m.
E301 expected 1 blank line, found 0	reviewbot	Nov. 19, 2021, 11:31 a.m.
E301 expected 1 blank line, found 0	reviewbot	Nov. 19, 2021, 11:31 a.m.
E301 expected 1 blank line, found 0	reviewbot	Nov. 19, 2021, 11:31 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 19, 2021, 11:31 a.m.
W291 trailing whitespace	reviewbot	Nov. 19, 2021, 11:31 a.m.
W291 trailing whitespace	reviewbot	Nov. 19, 2021, 11:31 a.m.
E501 line too long (88 > 79 characters)	reviewbot	Nov. 19, 2021, 11:31 a.m.
W293 blank line contains whitespace	reviewbot	Nov. 19, 2021, 11:31 a.m.
W293 blank line contains whitespace	reviewbot	Nov. 19, 2021, 11:31 a.m.
W293 blank line contains whitespace	reviewbot	Nov. 19, 2021, 11:31 a.m.
W293 blank line contains whitespace	reviewbot	Nov. 19, 2021, 11:31 a.m.
W291 trailing whitespace	reviewbot	Nov. 19, 2021, 11:31 a.m.
W293 blank line contains whitespace	reviewbot	Nov. 19, 2021, 11:31 a.m.
W291 trailing whitespace	reviewbot	Nov. 19, 2021, 11:31 a.m.
W293 blank line contains whitespace	reviewbot	Nov. 19, 2021, 11:31 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 19, 2021, 11:31 a.m.
W291 trailing whitespace	reviewbot	Nov. 19, 2021, 11:31 a.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 19, 2021, 11:31 a.m.
W291 trailing whitespace	reviewbot	Nov. 19, 2021, 11:31 a.m.
W293 blank line contains whitespace	reviewbot	Nov. 19, 2021, 11:31 a.m.
W293 blank line contains whitespace	reviewbot	Nov. 19, 2021, 11:31 a.m.
W291 trailing whitespace	reviewbot	Nov. 19, 2021, 11:31 a.m.
E231 missing whitespace after ','	reviewbot	Nov. 19, 2021, 11:31 a.m.
E231 missing whitespace after ','	reviewbot	Nov. 19, 2021, 11:31 a.m.
W291 trailing whitespace	reviewbot	Nov. 19, 2021, 11:31 a.m.
F401 'djblets.util.compat.django.shortcuts.render' imported but unused	reviewbot	Nov. 20, 2021, 12:19 p.m.
F401 'django.utils.translation.ugettext' imported but unused	reviewbot	Nov. 20, 2021, 12:19 p.m.
F811 redefinition of unused 'ListEditWidget' from line 6	reviewbot	Nov. 20, 2021, 12:19 p.m.
F401 'djblets.forms.fields.ListEditField' imported but unused	reviewbot	Nov. 20, 2021, 12:19 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 20, 2021, 12:19 p.m.
E301 expected 1 blank line, found 0	reviewbot	Nov. 20, 2021, 12:19 p.m.
E301 expected 1 blank line, found 0	reviewbot	Nov. 20, 2021, 12:19 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 20, 2021, 12:19 p.m.
W291 trailing whitespace	reviewbot	Nov. 20, 2021, 12:19 p.m.
W291 trailing whitespace	reviewbot	Nov. 20, 2021, 12:19 p.m.
E501 line too long (88 > 79 characters)	reviewbot	Nov. 20, 2021, 12:19 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 20, 2021, 12:19 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 20, 2021, 12:19 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 20, 2021, 12:19 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 20, 2021, 12:19 p.m.
W291 trailing whitespace	reviewbot	Nov. 20, 2021, 12:19 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 20, 2021, 12:19 p.m.
W291 trailing whitespace	reviewbot	Nov. 20, 2021, 12:19 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 20, 2021, 12:19 p.m.
W291 trailing whitespace	reviewbot	Nov. 20, 2021, 12:19 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 20, 2021, 12:19 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 20, 2021, 12:19 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 20, 2021, 12:19 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 20, 2021, 12:19 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 20, 2021, 12:19 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 20, 2021, 12:19 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 20, 2021, 12:19 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 20, 2021, 12:19 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 20, 2021, 12:19 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Nov. 20, 2021, 12:19 p.m.
F401 'uuid.uuid4' imported but unused	reviewbot	Nov. 24, 2021, 10:55 a.m.
F401 'djblets.util.compat.django.shortcuts.render' imported but unused	reviewbot	Nov. 24, 2021, 10:55 a.m.
F401 'django.utils.translation.ugettext' imported but unused	reviewbot	Nov. 24, 2021, 10:55 a.m.
F811 redefinition of unused 'ListEditWidget' from line 6	reviewbot	Nov. 24, 2021, 10:55 a.m.
F401 'djblets.forms.fields.ListEditField' imported but unused	reviewbot	Nov. 24, 2021, 10:55 a.m.
F401 'os' imported but unused	reviewbot	Nov. 24, 2021, 10:55 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 24, 2021, 10:55 a.m.
E301 expected 1 blank line, found 0	reviewbot	Nov. 24, 2021, 10:55 a.m.
E301 expected 1 blank line, found 0	reviewbot	Nov. 24, 2021, 10:55 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 24, 2021, 10:55 a.m.
W291 trailing whitespace	reviewbot	Nov. 24, 2021, 10:55 a.m.
W291 trailing whitespace	reviewbot	Nov. 24, 2021, 10:55 a.m.
E501 line too long (88 > 79 characters)	reviewbot	Nov. 24, 2021, 10:55 a.m.
W293 blank line contains whitespace	reviewbot	Nov. 24, 2021, 10:55 a.m.
E231 missing whitespace after ','	reviewbot	Nov. 24, 2021, 10:55 a.m.
E231 missing whitespace after ','	reviewbot	Nov. 24, 2021, 10:55 a.m.
W291 trailing whitespace	reviewbot	Nov. 24, 2021, 10:55 a.m.
W291 trailing whitespace	reviewbot	Nov. 24, 2021, 10:55 a.m.
W291 trailing whitespace	reviewbot	Nov. 24, 2021, 10:55 a.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 24, 2021, 10:55 a.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 24, 2021, 10:55 a.m.
E231 missing whitespace after ','	reviewbot	Nov. 24, 2021, 10:55 a.m.
E231 missing whitespace after ','	reviewbot	Nov. 24, 2021, 10:55 a.m.
W293 blank line contains whitespace	reviewbot	Nov. 24, 2021, 10:55 a.m.
W293 blank line contains whitespace	reviewbot	Nov. 24, 2021, 10:55 a.m.
E231 missing whitespace after ','	reviewbot	Nov. 24, 2021, 10:55 a.m.
E231 missing whitespace after ','	reviewbot	Nov. 24, 2021, 10:55 a.m.
E231 missing whitespace after ','	reviewbot	Nov. 24, 2021, 10:55 a.m.
E231 missing whitespace after ','	reviewbot	Nov. 24, 2021, 10:55 a.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 24, 2021, 10:55 a.m.
F401 'uuid.uuid4' imported but unused	reviewbot	Nov. 24, 2021, 11:15 p.m.
F401 'django.forms.widgets.Select' imported but unused	reviewbot	Nov. 24, 2021, 11:15 p.m.
F401 'djblets.util.compat.django.shortcuts.render' imported but unused	reviewbot	Nov. 24, 2021, 11:15 p.m.
F401 'django.utils.translation.ugettext' imported but unused	reviewbot	Nov. 24, 2021, 11:15 p.m.
F401 'pygments.lexers.get_all_lexers' imported but unused	reviewbot	Nov. 24, 2021, 11:15 p.m.
F811 redefinition of unused 'ListEditWidget' from line 6	reviewbot	Nov. 24, 2021, 11:15 p.m.
F401 'djblets.forms.fields.ListEditField' imported but unused	reviewbot	Nov. 24, 2021, 11:15 p.m.
F401 'os' imported but unused	reviewbot	Nov. 24, 2021, 11:15 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 24, 2021, 11:15 p.m.
W291 trailing whitespace	reviewbot	Nov. 24, 2021, 11:15 p.m.
W291 trailing whitespace	reviewbot	Nov. 24, 2021, 11:15 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 24, 2021, 11:15 p.m.
W291 trailing whitespace	reviewbot	Nov. 24, 2021, 11:15 p.m.
W291 trailing whitespace	reviewbot	Nov. 24, 2021, 11:15 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 24, 2021, 11:15 p.m.
W291 trailing whitespace	reviewbot	Nov. 24, 2021, 11:15 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 24, 2021, 11:15 p.m.
W291 trailing whitespace	reviewbot	Nov. 24, 2021, 11:15 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 24, 2021, 11:15 p.m.
W291 trailing whitespace	reviewbot	Nov. 24, 2021, 11:15 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 24, 2021, 11:15 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 24, 2021, 11:15 p.m.
W291 trailing whitespace	reviewbot	Nov. 24, 2021, 11:15 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 24, 2021, 11:15 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 24, 2021, 11:15 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 24, 2021, 11:15 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 24, 2021, 11:15 p.m.
E501 line too long (134 > 79 characters)	reviewbot	Nov. 24, 2021, 11:15 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 24, 2021, 11:15 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 24, 2021, 11:15 p.m.
You don't need to deal with setting siteconfig. I think calling super(EmojiSettingsForm, self).save() handles it. This might be related to …	maubin	Nov. 24, 2021, 8:52 p.m.
F401 'uuid.uuid4' imported but unused	reviewbot	Nov. 27, 2021, 9:58 p.m.
F401 'django.forms.widgets.Select' imported but unused	reviewbot	Nov. 27, 2021, 9:58 p.m.
F401 'djblets.util.compat.django.shortcuts.render' imported but unused	reviewbot	Nov. 27, 2021, 9:58 p.m.
F401 'django.utils.translation.ugettext' imported but unused	reviewbot	Nov. 27, 2021, 9:58 p.m.
F401 'pygments.lexers.get_all_lexers' imported but unused	reviewbot	Nov. 27, 2021, 9:58 p.m.
F811 redefinition of unused 'ListEditWidget' from line 6	reviewbot	Nov. 27, 2021, 9:58 p.m.
F401 'djblets.forms.fields.ListEditField' imported but unused	reviewbot	Nov. 27, 2021, 9:58 p.m.
F401 'os' imported but unused	reviewbot	Nov. 27, 2021, 9:58 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 27, 2021, 9:58 p.m.
W291 trailing whitespace	reviewbot	Nov. 27, 2021, 9:58 p.m.
W291 trailing whitespace	reviewbot	Nov. 27, 2021, 9:58 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 27, 2021, 9:58 p.m.
W291 trailing whitespace	reviewbot	Nov. 27, 2021, 9:58 p.m.
W291 trailing whitespace	reviewbot	Nov. 27, 2021, 9:58 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 27, 2021, 9:58 p.m.
W291 trailing whitespace	reviewbot	Nov. 27, 2021, 9:58 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 27, 2021, 9:58 p.m.
W291 trailing whitespace	reviewbot	Nov. 27, 2021, 9:58 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 27, 2021, 9:58 p.m.
W291 trailing whitespace	reviewbot	Nov. 27, 2021, 9:58 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 27, 2021, 9:58 p.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Nov. 27, 2021, 9:58 p.m.
W291 trailing whitespace	reviewbot	Nov. 27, 2021, 9:58 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 27, 2021, 9:58 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 27, 2021, 9:58 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 27, 2021, 9:58 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 27, 2021, 9:58 p.m.
E501 line too long (134 > 79 characters)	reviewbot	Nov. 27, 2021, 9:58 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 27, 2021, 9:58 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 27, 2021, 9:58 p.m.
F401 'uuid.uuid4' imported but unused	reviewbot	Nov. 28, 2021, 8:42 p.m.
W291 trailing whitespace	reviewbot	Nov. 28, 2021, 8:42 p.m.
F401 'djblets.util.compat.django.shortcuts.render' imported but unused	reviewbot	Nov. 28, 2021, 8:42 p.m.
F401 'django.utils.translation.ugettext' imported but unused	reviewbot	Nov. 28, 2021, 8:42 p.m.
F401 'pygments.lexers.get_all_lexers' imported but unused	reviewbot	Nov. 28, 2021, 8:42 p.m.
F811 redefinition of unused 'ListEditWidget' from line 7	reviewbot	Nov. 28, 2021, 8:42 p.m.
F401 'djblets.forms.fields.ListEditField' imported but unused	reviewbot	Nov. 28, 2021, 8:42 p.m.
F811 redefinition of unused 'forms' from line 5	reviewbot	Nov. 28, 2021, 8:42 p.m.
F401 'json' imported but unused	reviewbot	Nov. 28, 2021, 8:42 p.m.
E302 expected 2 blank lines, found 1	reviewbot	Nov. 28, 2021, 8:42 p.m.
W291 trailing whitespace	reviewbot	Nov. 28, 2021, 8:42 p.m.
W291 trailing whitespace	reviewbot	Nov. 28, 2021, 8:42 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 28, 2021, 8:42 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 28, 2021, 8:42 p.m.
W291 trailing whitespace	reviewbot	Nov. 28, 2021, 8:42 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 28, 2021, 8:42 p.m.
W291 trailing whitespace	reviewbot	Nov. 28, 2021, 8:42 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 28, 2021, 8:42 p.m.
W291 trailing whitespace	reviewbot	Nov. 28, 2021, 8:42 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 28, 2021, 8:42 p.m.
W291 trailing whitespace	reviewbot	Nov. 28, 2021, 8:42 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:42 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 28, 2021, 8:42 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:42 p.m.
E261 at least two spaces before inline comment	reviewbot	Nov. 28, 2021, 8:42 p.m.
E501 line too long (134 > 79 characters)	reviewbot	Nov. 28, 2021, 8:42 p.m.
W293 blank line contains whitespace	reviewbot	Nov. 28, 2021, 8:42 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:42 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:42 p.m.
E231 missing whitespace after ','	reviewbot	Nov. 28, 2021, 8:42 p.m.
F401 'uuid.uuid4' imported but unused	reviewbot	Dec. 3, 2021, 10:24 a.m.
F401 'djblets.forms.widgets.EmojiFileInput' imported but unused	reviewbot	Dec. 3, 2021, 10:24 a.m.
F401 'djblets.util.compat.django.shortcuts.render' imported but unused	reviewbot	Dec. 3, 2021, 10:24 a.m.
F401 'django.utils.translation.ugettext' imported but unused	reviewbot	Dec. 3, 2021, 10:24 a.m.
F401 'pygments.lexers.get_all_lexers' imported but unused	reviewbot	Dec. 3, 2021, 10:24 a.m.
F811 redefinition of unused 'ListEditWidget' from line 7	reviewbot	Dec. 3, 2021, 10:24 a.m.
F401 'djblets.forms.fields.ListEditField' imported but unused	reviewbot	Dec. 3, 2021, 10:24 a.m.
F811 redefinition of unused 'forms' from line 5	reviewbot	Dec. 3, 2021, 10:24 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
W293 blank line contains whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:24 a.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Dec. 3, 2021, 10:24 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:24 a.m.
W293 blank line contains whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:24 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:24 a.m.
E501 line too long (134 > 79 characters)	reviewbot	Dec. 3, 2021, 10:24 a.m.
W293 blank line contains whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:24 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:24 a.m.
E231 missing whitespace after ','	reviewbot	Dec. 3, 2021, 10:24 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:24 a.m.
F811 redefinition of unused 'ListEditWidget' from line 5	reviewbot	Dec. 3, 2021, 10:24 a.m.
F811 redefinition of unused 'forms' from line 3	reviewbot	Dec. 3, 2021, 10:24 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
W293 blank line contains whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
E261 at least two spaces before inline comment	reviewbot	Dec. 3, 2021, 10:24 a.m.
E123 closing bracket does not match indentation of opening bracket's line	reviewbot	Dec. 3, 2021, 10:24 a.m.
W293 blank line contains whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
W293 blank line contains whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
E501 line too long (80 > 79 characters)	reviewbot	Dec. 3, 2021, 10:24 a.m.
E501 line too long (90 > 79 characters)	reviewbot	Dec. 3, 2021, 10:24 a.m.
W293 blank line contains whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
E302 expected 2 blank lines, found 1	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
W293 blank line contains whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
W293 blank line contains whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
W293 blank line contains whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
W291 trailing whitespace	reviewbot	Dec. 3, 2021, 10:24 a.m.
Col: 46 Missing semicolon.	reviewbot	Dec. 3, 2021, 10:24 a.m.
Col: 72 Missing semicolon.	reviewbot	Dec. 3, 2021, 10:24 a.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/forms/emoji_settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
F401 'django.utils.translation.ugettext' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/models.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/models.py (Diff revision 1)
The issue has been dropped. Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/urls.py (Diff revision 1)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/urls.py (Diff revision 1)
The issue has been dropped. Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
F403 'from .models import *' used; unable to detect undefined names
```
reviewboard/admin/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E226 missing whitespace around arithmetic operator
```
reviewboard/admin/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E226 missing whitespace around arithmetic operator
```
reviewboard/admin/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E225 missing whitespace around operator
```
reviewboard/admin/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
F841 local variable 'display_emoji' is assigned to but never used
```
reviewboard/admin/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
F405 'CustomEmojis' may be undefined, or defined from star imports: .models
```
reviewboard/admin/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
reviewboard/admin/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
reviewboard/admin/views.py (Diff revision 1)
The issue has been dropped. Show all issues
```
W292 no newline at end of file
```

Commits:

Summary	ID	Author
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang

Diff:

Revision 2 (+469 -45)

Show changes

	reviewboard/staticbundles.py
	reviewboard/admin/models.py
	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/forms/emoji_settings.py
	reviewboard/static/rb/css/ui/emoji_settings.less
	reviewboard/templates/admin/emoji_settings.html

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
F401 'django.utils.translation.ugettext' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (83 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
F841 local variable 'emoji_image' is assigned to but never used
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E501 line too long (91 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/models.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/models.py (Diff revision 2)
The issue has been dropped. Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/urls.py (Diff revision 2)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/urls.py (Diff revision 2)
The issue has been dropped. Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
F403 'from .models import *' used; unable to detect undefined names
```
reviewboard/admin/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E226 missing whitespace around arithmetic operator
```
reviewboard/admin/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E226 missing whitespace around arithmetic operator
```
reviewboard/admin/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E225 missing whitespace around operator
```
reviewboard/admin/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
F841 local variable 'display_emoji' is assigned to but never used
```
reviewboard/admin/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
F405 'CustomEmojis' may be undefined, or defined from star imports: .models
```
reviewboard/admin/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
reviewboard/admin/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E251 unexpected spaces around keyword / parameter equals
```
reviewboard/admin/views.py (Diff revision 2)
The issue has been dropped. Show all issues
```
W292 no newline at end of file
```

Commits:

Summary	ID	Author
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang

Diff:

Revision 3 (+618 -126)

Show changes

	reviewboard/staticbundles.py
	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/forms/emoji_settings.py
	reviewboard/static/rb/css/ui/emoji_settings.less
	reviewboard/templates/admin/emoji_settings.html

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 41 failures.
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
F841 local variable 'emoji_image' is assigned to but never used
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E501 line too long (88 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E301 expected 1 blank line, found 0
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/urls.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/urls.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/views.py (Diff revision 3)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/views.py (Diff revision 3)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```

Commits:

Summary	ID	Author
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang

Diff:

Revision 4 (+659 -167)

Show changes

	reviewboard/dependencies.py
	reviewboard/staticbundles.py
	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/forms/emoji_settings.py
	reviewboard/static/rb/css/ui/emoji_settings.less
	reviewboard/templates/admin/emoji_settings.html

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 51 failures.
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
F841 local variable 'emoji_image' is assigned to but never used
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E501 line too long (88 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E301 expected 1 blank line, found 0
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/urls.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/urls.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W292 no newline at end of file
```
reviewboard/admin/views.py (Diff revision 4)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/views.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/views.py (Diff revision 4)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```

Commits:

Summary	ID	Author
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
[WIP] cannot fetch data from forms.	44ea86374597f452717b9555ed843122b81c7a43	mxiuwang

Diff:

Revision 5 (+1083 -197)

Show changes

	reviewboard/dependencies.py
	reviewboard/staticbundles.py
	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/forms/emoji_settings.py
	reviewboard/static/rb/css/ui/emoji_settings.less
	reviewboard/templates/admin/emoji_settings.html

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 67 failures.
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E301 expected 1 blank line, found 0
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E301 expected 1 blank line, found 0
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E301 expected 1 blank line, found 0
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E301 expected 1 blank line, found 0
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E301 expected 1 blank line, found 0
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E301 expected 1 blank line, found 0
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E501 line too long (88 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```

Commits:

Summary	ID	Author
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
[WIP] cannot fetch data from forms.	44ea86374597f452717b9555ed843122b81c7a43	mxiuwang
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
[WIP] cannot fetch data from forms.	44ea86374597f452717b9555ed843122b81c7a43	mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.	aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec	mxiuwang

Diff:

Revision 6 (+1070 -388)

Show changes

	reviewboard/dependencies.py
	reviewboard/staticbundles.py
	reviewboard/admin/siteconfig.py
	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/forms/emoji_settings.py
	reviewboard/static/rb/css/ui/emoji_settings.less
	reviewboard/templates/admin/emoji_settings.html

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 63 failures.
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
F401 'djblets.util.compat.django.shortcuts.render' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
F401 'django.utils.translation.ugettext' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
F811 redefinition of unused 'ListEditWidget' from line 6
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
F401 'djblets.forms.fields.ListEditField' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E301 expected 1 blank line, found 0
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E301 expected 1 blank line, found 0
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E501 line too long (88 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
E501 line too long (80 > 79 characters)
```

Commits:

Summary	ID	Author
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
[WIP] cannot fetch data from forms.	44ea86374597f452717b9555ed843122b81c7a43	mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.	aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec	mxiuwang
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
[WIP] cannot fetch data from forms.	44ea86374597f452717b9555ed843122b81c7a43	mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.	aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec	mxiuwang
ListEditDictionaryField working.	b04ab1d482403d74c068d2357f5adba80412d4f1	mxiuwang

Diff:

Revision 7 (+1056 -434)

Show changes

	reviewboard/dependencies.py
	reviewboard/staticbundles.py
	reviewboard/admin/siteconfig.py
	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/forms/emoji_settings.py
	reviewboard/static/rb/css/ui/emoji_settings.less
	reviewboard/templates/admin/emoji_settings.html

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 62 failures.
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
F401 'uuid.uuid4' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
F401 'djblets.util.compat.django.shortcuts.render' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
F401 'django.utils.translation.ugettext' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
F811 redefinition of unused 'ListEditWidget' from line 6
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
F401 'djblets.forms.fields.ListEditField' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
F401 'os' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E301 expected 1 blank line, found 0
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E301 expected 1 blank line, found 0
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E501 line too long (88 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 7)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```

Description:

~		[WIP] Upload Emojis using Models model, soon to be changed to Forms model.
	~	Upload Emojis using Forms

Commits:

Summary	ID	Author
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
[WIP] cannot fetch data from forms.	44ea86374597f452717b9555ed843122b81c7a43	mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.	aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec	mxiuwang
ListEditDictionaryField working.	b04ab1d482403d74c068d2357f5adba80412d4f1	mxiuwang
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
[WIP] cannot fetch data from forms.	44ea86374597f452717b9555ed843122b81c7a43	mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.	aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec	mxiuwang
ListEditDictionaryField working.	b04ab1d482403d74c068d2357f5adba80412d4f1	mxiuwang
save working except images.	05e73763cac1902c79b80131eacc8a579153e1ac	mxiuwang

Diff:

Revision 8 (+1041 -575)

Show changes

	reviewboard/dependencies.py
	reviewboard/staticbundles.py
	reviewboard/admin/siteconfig.py
	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/forms/emoji_settings.py
	reviewboard/static/rb/css/ui/emoji_settings.less

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 73 failures.
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
F401 'uuid.uuid4' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
F401 'django.forms.widgets.Select' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
F401 'djblets.util.compat.django.shortcuts.render' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
F401 'django.utils.translation.ugettext' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
F401 'pygments.lexers.get_all_lexers' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
F811 redefinition of unused 'ListEditWidget' from line 6
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
F401 'djblets.forms.fields.ListEditField' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
F401 'os' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
E501 line too long (134 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 8)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```

Fix it!

reviewboard/admin/forms/emoji_settings.py (Diff revision 8)

An issue was opened. Show all issues

You don't need to deal with setting siteconfig. I think calling super(EmojiSettingsForm, self).save() handles it. This might be related to your missing file problem, but not sure.

Commits:

Summary	ID	Author
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
[WIP] cannot fetch data from forms.	44ea86374597f452717b9555ed843122b81c7a43	mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.	aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec	mxiuwang
ListEditDictionaryField working.	b04ab1d482403d74c068d2357f5adba80412d4f1	mxiuwang
save working except images.	05e73763cac1902c79b80131eacc8a579153e1ac	mxiuwang
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
[WIP] cannot fetch data from forms.	44ea86374597f452717b9555ed843122b81c7a43	mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.	aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec	mxiuwang
ListEditDictionaryField working.	b04ab1d482403d74c068d2357f5adba80412d4f1	mxiuwang
save working except images.	05e73763cac1902c79b80131eacc8a579153e1ac	mxiuwang
load() function loads data (except images.	aff938a30ff7e469d23ccc50fac55da63b84482e	mxiuwang

Diff:

Revision 9 (+1022 -622)

Show changes

	reviewboard/dependencies.py
	reviewboard/staticbundles.py
	reviewboard/admin/siteconfig.py
	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/forms/emoji_settings.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 69 failures.
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
F401 'uuid.uuid4' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
F401 'django.forms.widgets.Select' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
F401 'djblets.util.compat.django.shortcuts.render' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
F401 'django.utils.translation.ugettext' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
F401 'pygments.lexers.get_all_lexers' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
F811 redefinition of unused 'ListEditWidget' from line 6
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
F401 'djblets.forms.fields.ListEditField' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
F401 'os' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
E501 line too long (134 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 9)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```

Commits:

Summary	ID	Author
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
[WIP] cannot fetch data from forms.	44ea86374597f452717b9555ed843122b81c7a43	mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.	aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec	mxiuwang
ListEditDictionaryField working.	b04ab1d482403d74c068d2357f5adba80412d4f1	mxiuwang
save working except images.	05e73763cac1902c79b80131eacc8a579153e1ac	mxiuwang
load() function loads data (except images.	aff938a30ff7e469d23ccc50fac55da63b84482e	mxiuwang
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
[WIP] cannot fetch data from forms.	44ea86374597f452717b9555ed843122b81c7a43	mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.	aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec	mxiuwang
ListEditDictionaryField working.	b04ab1d482403d74c068d2357f5adba80412d4f1	mxiuwang
save working except images.	05e73763cac1902c79b80131eacc8a579153e1ac	mxiuwang
load() function loads data (except images.	aff938a30ff7e469d23ccc50fac55da63b84482e	mxiuwang
Images saved to DefaultStorage, not yet rendered on load().	5aea766a9f2ac3c496a09a80727fd476aef95b71	mxiuwang

Diff:

Revision 10 (+1086 -656)

Show changes

	reviewboard/dependencies.py
	reviewboard/staticbundles.py
	reviewboard/admin/siteconfig.py
	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/forms/emoji_settings.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 101 failures.
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
F401 'uuid.uuid4' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
F401 'djblets.util.compat.django.shortcuts.render' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
F401 'django.utils.translation.ugettext' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
F401 'pygments.lexers.get_all_lexers' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
F811 redefinition of unused 'ListEditWidget' from line 7
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
F401 'djblets.forms.fields.ListEditField' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
F811 redefinition of unused 'forms' from line 5
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
F401 'json' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
E501 line too long (134 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 10)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```

Commits:

Summary	ID	Author
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
[WIP] cannot fetch data from forms.	44ea86374597f452717b9555ed843122b81c7a43	mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.	aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec	mxiuwang
ListEditDictionaryField working.	b04ab1d482403d74c068d2357f5adba80412d4f1	mxiuwang
save working except images.	05e73763cac1902c79b80131eacc8a579153e1ac	mxiuwang
load() function loads data (except images.	aff938a30ff7e469d23ccc50fac55da63b84482e	mxiuwang
Images saved to DefaultStorage, not yet rendered on load().	5aea766a9f2ac3c496a09a80727fd476aef95b71	mxiuwang
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
[WIP] cannot fetch data from forms.	44ea86374597f452717b9555ed843122b81c7a43	mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.	aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec	mxiuwang
ListEditDictionaryField working.	b04ab1d482403d74c068d2357f5adba80412d4f1	mxiuwang
save working except images.	05e73763cac1902c79b80131eacc8a579153e1ac	mxiuwang
load() function loads data (except images.	aff938a30ff7e469d23ccc50fac55da63b84482e	mxiuwang
Images saved to DefaultStorage, not yet rendered on load().	5aea766a9f2ac3c496a09a80727fd476aef95b71	mxiuwang
[WIP] Rendering Images.	413a6479e991bef5aadbc49bd50d8c9185994ff9	mxiuwang

Diff:

Revision 11 (+1101 -665)

Show changes

	reviewboard/dependencies.py
	reviewboard/staticbundles.py
	reviewboard/admin/siteconfig.py
	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/forms/emoji_settings.py

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

```
Warning: Showing 30 of 98 failures.
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
F401 'uuid.uuid4' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
F401 'djblets.forms.widgets.EmojiFileInput' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
F401 'djblets.util.compat.django.shortcuts.render' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
F401 'django.utils.translation.ugettext' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
F401 'pygments.lexers.get_all_lexers' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
F811 redefinition of unused 'ListEditWidget' from line 7
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
F401 'djblets.forms.fields.ListEditField' imported but unused
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
F811 redefinition of unused 'forms' from line 5
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
E501 line too long (134 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
E231 missing whitespace after ','
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 11)
The issue has been dropped. Show all issues
```
E261 at least two spaces before inline comment
```

Summary:

-	Upload Emojis wip.
+	Custom Admin Emoji Panel (Reviewboard)

Description:

~		Upload Emojis using Forms
	~	Adds a page to the admint panel which allows an admin to upload a custom emoji by uploading a name, shortcode, description, and image. These fields are editable whenever the user re-vists the page. The emoji data is loaded from, and saved into SiteConfiguration, while the image data is loaded from and saved to DefaultStorage.
	+
	+	Further work that needs to be done:
	+	* Enforcing mandatory fields that user must fill out before clicking "Save", so as to not raise an error.
	+	* Adding labels to the form fields, and removing the extra "name" field at the very top of the form.
	+	* Rendering a preview of the emoji when loading the page (through get_context() in EmojiFileUpload).

Commits:

Summary	ID	Author
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
[WIP] cannot fetch data from forms.	44ea86374597f452717b9555ed843122b81c7a43	mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.	aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec	mxiuwang
ListEditDictionaryField working.	b04ab1d482403d74c068d2357f5adba80412d4f1	mxiuwang
save working except images.	05e73763cac1902c79b80131eacc8a579153e1ac	mxiuwang
load() function loads data (except images.	aff938a30ff7e469d23ccc50fac55da63b84482e	mxiuwang
Images saved to DefaultStorage, not yet rendered on load().	5aea766a9f2ac3c496a09a80727fd476aef95b71	mxiuwang
[WIP] Rendering Images.	413a6479e991bef5aadbc49bd50d8c9185994ff9	mxiuwang
Upload Emojis wip.	81d9db02ab1196cf653dc46a1bc7789d57123591	mxiuwang
Upload Emojis using Models model, soon to be changed to Forms model.	441e0104edac5f50a79c1679f9fda40e5f2cf126	mxiuwang
[WIP] use forms to upload images	146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2	mxiuwang
[WIP] load() and save() functions.	bfa9548136e4a6ebe929a4f2f4a25d66e49abc48	mxiuwang
[WIP] Emoji working, trying to validate save().	d10c4cd84e9463db47c12985406532600b42d944	mxiuwang
WIP save() function in emoji_settings,py	58b772e54a253940df0addb7a3ca676bdb0b20fc	mxiuwang
save runs but does not fetch data from forms.	395bd2aeb607fb12ea01454a7f45daaf9d86eb51	mxiuwang
[WIP] cannot fetch data from forms.	44ea86374597f452717b9555ed843122b81c7a43	mxiuwang
[WIP] Add ListEditDictionaryField for parsing input.	aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec	mxiuwang
ListEditDictionaryField working.	b04ab1d482403d74c068d2357f5adba80412d4f1	mxiuwang
save working except images.	05e73763cac1902c79b80131eacc8a579153e1ac	mxiuwang
load() function loads data (except images.	aff938a30ff7e469d23ccc50fac55da63b84482e	mxiuwang
Images saved to DefaultStorage, not yet rendered on load().	5aea766a9f2ac3c496a09a80727fd476aef95b71	mxiuwang
[WIP] Rendering Images.	413a6479e991bef5aadbc49bd50d8c9185994ff9	mxiuwang
[WIP] Render image previews.	deb9c6a9374fe41adc0fa2393e88c3ec7caa6acd	mxiuwang
Add docstring, code cleanup.	a76d6448038388bfff67870a2ca170cb385a990b	mxiuwang

Diff:

Revision 12 (+2172 -888)

Show changes

	dev-requirements.txt
	reviewboard/dependencies.py
	reviewboard/staticbundles.py
	reviewboard/admin/siteconfig.py
	reviewboard/admin/urls.py
	reviewboard/admin/views.py
	reviewboard/admin/forms/emoji_settings.py
	reviewboard/static/rb/css/pages/image-review-ui.less
	1 more

Checks run (2 failed)

flake8 failed.

JSHint failed.

flake8

```
Warning: Showing 30 of 55 failures.
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
F811 redefinition of unused 'ListEditWidget' from line 5
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
F811 redefinition of unused 'forms' from line 3
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
E261 at least two spaces before inline comment
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
E123 closing bracket does not match indentation of opening bracket's line
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
E501 line too long (90 > 79 characters)
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
E302 expected 2 blank lines, found 1
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W291 trailing whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W293 blank line contains whitespace
```
reviewboard/admin/forms/emoji_settings.py (Diff revision 12)
An issue was opened. Show all issues
```
W291 trailing whitespace
```

JSHint

reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
Col: 46
 Missing semicolon.
```
reviewboard/static/rb/js/views/imageReviewableView.es6.js (Diff revision 12)
An issue was opened. Show all issues
```
Col: 72
 Missing semicolon.
```

Custom Admin Emoji Panel (Reviewboard)

Information

Reviewers

flake8

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Description:

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Commits:

Diff:

Checks run (1 failed, 1 succeeded)

flake8

Summary:

Description:

Commits:

Diff:

Checks run (2 failed)

flake8

JSHint

Status: Discarded