flake8
failed.
JSHint
passed.
Custom Admin Emoji Panel (Reviewboard)
Review Request #11862 — Created Nov. 3, 2021 and discarded
Adds a page to the admint panel which allows an admin to upload a custom emoji by uploading a name, shortcode, description, and image. These fields are editable whenever the user re-vists the page. The emoji data is loaded from, and saved into SiteConfiguration, while the image data is loaded from and saved to DefaultStorage.
Further work that needs to be done: * Enforcing mandatory fields that user must fill out before clicking "Save", so as to not raise an error. * Adding labels to the form fields, and removing the extra "name" field at the very top of the form. * Rendering a preview of the emoji when loading the page (through get_context() in EmojiFileUpload).
| Summary | ID | Author |
|---|---|---|
| 81d9db02ab1196cf653dc46a1bc7789d57123591 | mxiuwang | |
| 441e0104edac5f50a79c1679f9fda40e5f2cf126 | mxiuwang | |
| 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 | mxiuwang | |
| bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 | mxiuwang | |
| d10c4cd84e9463db47c12985406532600b42d944 | mxiuwang | |
| 58b772e54a253940df0addb7a3ca676bdb0b20fc | mxiuwang | |
| 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 | mxiuwang | |
| 44ea86374597f452717b9555ed843122b81c7a43 | mxiuwang | |
| aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec | mxiuwang | |
| b04ab1d482403d74c068d2357f5adba80412d4f1 | mxiuwang | |
| 05e73763cac1902c79b80131eacc8a579153e1ac | mxiuwang | |
| aff938a30ff7e469d23ccc50fac55da63b84482e | mxiuwang | |
| 5aea766a9f2ac3c496a09a80727fd476aef95b71 | mxiuwang | |
| 413a6479e991bef5aadbc49bd50d8c9185994ff9 | mxiuwang | |
| deb9c6a9374fe41adc0fa2393e88c3ec7caa6acd | mxiuwang | |
| a76d6448038388bfff67870a2ca170cb385a990b | mxiuwang |
| Description | From | Last Updated |
|---|---|---|
|
F401 'django.utils.translation.ugettext' imported but unused |
 reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
E501 line too long (83 > 79 characters) |
reviewbot
|
|
|
W292 no newline at end of file |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W292 no newline at end of file |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W292 no newline at end of file |
reviewbot
|
|
|
F403 'from .models import *' used; unable to detect undefined names |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E226 missing whitespace around arithmetic operator |
reviewbot
|
|
|
E226 missing whitespace around arithmetic operator |
reviewbot
|
|
|
E225 missing whitespace around operator |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
F841 local variable 'display_emoji' is assigned to but never used |
reviewbot
|
|
|
F405 'CustomEmojis' may be undefined, or defined from star imports: .models |
reviewbot
|
|
|
E251 unexpected spaces around keyword / parameter equals |
reviewbot
|
|
|
E251 unexpected spaces around keyword / parameter equals |
reviewbot
|
|
|
W292 no newline at end of file |
reviewbot
|
|
|
F401 'django.utils.translation.ugettext' imported but unused |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
E501 line too long (83 > 79 characters) |
reviewbot
|
|
|
F841 local variable 'emoji_image' is assigned to but never used |
reviewbot
|
|
|
E501 line too long (91 > 79 characters) |
reviewbot
|
|
|
W292 no newline at end of file |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W292 no newline at end of file |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W292 no newline at end of file |
reviewbot
|
|
|
F403 'from .models import *' used; unable to detect undefined names |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E226 missing whitespace around arithmetic operator |
reviewbot
|
|
|
E226 missing whitespace around arithmetic operator |
reviewbot
|
|
|
E225 missing whitespace around operator |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
F841 local variable 'display_emoji' is assigned to but never used |
reviewbot
|
|
|
F405 'CustomEmojis' may be undefined, or defined from star imports: .models |
reviewbot
|
|
|
E251 unexpected spaces around keyword / parameter equals |
reviewbot
|
|
|
E251 unexpected spaces around keyword / parameter equals |
reviewbot
|
|
|
W292 no newline at end of file |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
F841 local variable 'emoji_image' is assigned to but never used |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E501 line too long (88 > 79 characters) |
reviewbot
|
|
|
E301 expected 1 blank line, found 0 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W292 no newline at end of file |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W292 no newline at end of file |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
F841 local variable 'emoji_image' is assigned to but never used |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E501 line too long (88 > 79 characters) |
reviewbot
|
|
|
E301 expected 1 blank line, found 0 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W292 no newline at end of file |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W292 no newline at end of file |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E301 expected 1 blank line, found 0 |
reviewbot
|
|
|
E301 expected 1 blank line, found 0 |
reviewbot
|
|
|
E301 expected 1 blank line, found 0 |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E301 expected 1 blank line, found 0 |
reviewbot
|
|
|
E301 expected 1 blank line, found 0 |
reviewbot
|
|
|
E301 expected 1 blank line, found 0 |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E501 line too long (88 > 79 characters) |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
F401 'djblets.util.compat.django.shortcuts.render' imported but unused |
reviewbot
|
|
|
F401 'django.utils.translation.ugettext' imported but unused |
reviewbot
|
|
|
F811 redefinition of unused 'ListEditWidget' from line 6 |
reviewbot
|
|
|
F401 'djblets.forms.fields.ListEditField' imported but unused |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E301 expected 1 blank line, found 0 |
reviewbot
|
|
|
E301 expected 1 blank line, found 0 |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E501 line too long (88 > 79 characters) |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
F401 'uuid.uuid4' imported but unused |
reviewbot
|
|
|
F401 'djblets.util.compat.django.shortcuts.render' imported but unused |
reviewbot
|
|
|
F401 'django.utils.translation.ugettext' imported but unused |
reviewbot
|
|
|
F811 redefinition of unused 'ListEditWidget' from line 6 |
reviewbot
|
|
|
F401 'djblets.forms.fields.ListEditField' imported but unused |
reviewbot
|
|
|
F401 'os' imported but unused |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
E301 expected 1 blank line, found 0 |
reviewbot
|
|
|
E301 expected 1 blank line, found 0 |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E501 line too long (88 > 79 characters) |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
F401 'uuid.uuid4' imported but unused |
reviewbot
|
|
|
F401 'django.forms.widgets.Select' imported but unused |
reviewbot
|
|
|
F401 'djblets.util.compat.django.shortcuts.render' imported but unused |
reviewbot
|
|
|
F401 'django.utils.translation.ugettext' imported but unused |
reviewbot
|
|
|
F401 'pygments.lexers.get_all_lexers' imported but unused |
reviewbot
|
|
|
F811 redefinition of unused 'ListEditWidget' from line 6 |
reviewbot
|
|
|
F401 'djblets.forms.fields.ListEditField' imported but unused |
reviewbot
|
|
|
F401 'os' imported but unused |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
E123 closing bracket does not match indentation of opening bracket's line |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
E501 line too long (134 > 79 characters) |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
You don't need to deal with setting siteconfig. I think calling super(EmojiSettingsForm, self).save() handles it. This might be related to … |
 maubin
|
|
|
F401 'uuid.uuid4' imported but unused |
reviewbot
|
|
|
F401 'django.forms.widgets.Select' imported but unused |
reviewbot
|
|
|
F401 'djblets.util.compat.django.shortcuts.render' imported but unused |
reviewbot
|
|
|
F401 'django.utils.translation.ugettext' imported but unused |
reviewbot
|
|
|
F401 'pygments.lexers.get_all_lexers' imported but unused |
reviewbot
|
|
|
F811 redefinition of unused 'ListEditWidget' from line 6 |
reviewbot
|
|
|
F401 'djblets.forms.fields.ListEditField' imported but unused |
reviewbot
|
|
|
F401 'os' imported but unused |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
E123 closing bracket does not match indentation of opening bracket's line |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
E501 line too long (134 > 79 characters) |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
F401 'uuid.uuid4' imported but unused |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
F401 'djblets.util.compat.django.shortcuts.render' imported but unused |
reviewbot
|
|
|
F401 'django.utils.translation.ugettext' imported but unused |
reviewbot
|
|
|
F401 'pygments.lexers.get_all_lexers' imported but unused |
reviewbot
|
|
|
F811 redefinition of unused 'ListEditWidget' from line 7 |
reviewbot
|
|
|
F401 'djblets.forms.fields.ListEditField' imported but unused |
reviewbot
|
|
|
F811 redefinition of unused 'forms' from line 5 |
reviewbot
|
|
|
F401 'json' imported but unused |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
E501 line too long (134 > 79 characters) |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
F401 'uuid.uuid4' imported but unused |
reviewbot
|
|
|
F401 'djblets.forms.widgets.EmojiFileInput' imported but unused |
reviewbot
|
|
|
F401 'djblets.util.compat.django.shortcuts.render' imported but unused |
reviewbot
|
|
|
F401 'django.utils.translation.ugettext' imported but unused |
reviewbot
|
|
|
F401 'pygments.lexers.get_all_lexers' imported but unused |
reviewbot
|
|
|
F811 redefinition of unused 'ListEditWidget' from line 7 |
reviewbot
|
|
|
F401 'djblets.forms.fields.ListEditField' imported but unused |
reviewbot
|
|
|
F811 redefinition of unused 'forms' from line 5 |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
E123 closing bracket does not match indentation of opening bracket's line |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
E501 line too long (134 > 79 characters) |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E231 missing whitespace after ',' |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
F811 redefinition of unused 'ListEditWidget' from line 5 |
reviewbot
|
|
|
F811 redefinition of unused 'forms' from line 3 |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E261 at least two spaces before inline comment |
reviewbot
|
|
|
E123 closing bracket does not match indentation of opening bracket's line |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
E501 line too long (90 > 79 characters) |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
E302 expected 2 blank lines, found 1 |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W293 blank line contains whitespace |
reviewbot
|
|
|
W291 trailing whitespace |
reviewbot
|
|
|
Col: 46 Missing semicolon. |
reviewbot
|
|
|
Col: 72 Missing semicolon. |
reviewbot
|
- Commits:
-
Summary ID Author 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
- Commits:
-
Summary ID Author 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
Warning: Showing 30 of 41 failures.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- Commits:
-
Summary ID Author 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
Warning: Showing 30 of 51 failures.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- Commits:
-
Summary ID Author 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang 44ea86374597f452717b9555ed843122b81c7a43 mxiuwang
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
Warning: Showing 30 of 67 failures.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- Commits:
-
Summary ID Author 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang 44ea86374597f452717b9555ed843122b81c7a43 mxiuwang 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang 44ea86374597f452717b9555ed843122b81c7a43 mxiuwang aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang - Diff:
-
Revision 6 (+1070 -388)
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
Warning: Showing 30 of 63 failures.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- Commits:
-
Summary ID Author 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang 44ea86374597f452717b9555ed843122b81c7a43 mxiuwang aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang 44ea86374597f452717b9555ed843122b81c7a43 mxiuwang aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang - Diff:
-
Revision 7 (+1056 -434)
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
Warning: Showing 30 of 62 failures.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- Description:
-
~ [WIP] Upload Emojis using Models model, soon to be changed to Forms model.
~ Upload Emojis using Forms
- Commits:
-
Summary ID Author 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang 44ea86374597f452717b9555ed843122b81c7a43 mxiuwang aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang 44ea86374597f452717b9555ed843122b81c7a43 mxiuwang aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang 05e73763cac1902c79b80131eacc8a579153e1ac mxiuwang
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
Warning: Showing 30 of 73 failures.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- Commits:
-
Summary ID Author 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang 44ea86374597f452717b9555ed843122b81c7a43 mxiuwang aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang 05e73763cac1902c79b80131eacc8a579153e1ac mxiuwang 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang 44ea86374597f452717b9555ed843122b81c7a43 mxiuwang aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang 05e73763cac1902c79b80131eacc8a579153e1ac mxiuwang aff938a30ff7e469d23ccc50fac55da63b84482e mxiuwang
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
Warning: Showing 30 of 69 failures.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- Commits:
-
Summary ID Author 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang 44ea86374597f452717b9555ed843122b81c7a43 mxiuwang aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang 05e73763cac1902c79b80131eacc8a579153e1ac mxiuwang aff938a30ff7e469d23ccc50fac55da63b84482e mxiuwang 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang 44ea86374597f452717b9555ed843122b81c7a43 mxiuwang aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang 05e73763cac1902c79b80131eacc8a579153e1ac mxiuwang aff938a30ff7e469d23ccc50fac55da63b84482e mxiuwang 5aea766a9f2ac3c496a09a80727fd476aef95b71 mxiuwang
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
Warning: Showing 30 of 101 failures.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- Commits:
-
Summary ID Author 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang 44ea86374597f452717b9555ed843122b81c7a43 mxiuwang aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang 05e73763cac1902c79b80131eacc8a579153e1ac mxiuwang aff938a30ff7e469d23ccc50fac55da63b84482e mxiuwang 5aea766a9f2ac3c496a09a80727fd476aef95b71 mxiuwang 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang 44ea86374597f452717b9555ed843122b81c7a43 mxiuwang aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang 05e73763cac1902c79b80131eacc8a579153e1ac mxiuwang aff938a30ff7e469d23ccc50fac55da63b84482e mxiuwang 5aea766a9f2ac3c496a09a80727fd476aef95b71 mxiuwang 413a6479e991bef5aadbc49bd50d8c9185994ff9 mxiuwang
Checks run (1 failed, 1 succeeded)
flake8
failed.
JSHint
passed.
flake8
-
Warning: Showing 30 of 98 failures.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
- Summary:
-
Upload Emojis wip.Custom Admin Emoji Panel (Reviewboard)
- Description:
-
~ Upload Emojis using Forms
~ Adds a page to the admint panel which allows an admin to upload a custom emoji by uploading a name, shortcode, description, and image. These fields are editable whenever the user re-vists the page. The emoji data is loaded from, and saved into SiteConfiguration, while the image data is loaded from and saved to DefaultStorage.
+ + Further work that needs to be done:
+ * Enforcing mandatory fields that user must fill out before clicking "Save", so as to not raise an error. + * Adding labels to the form fields, and removing the extra "name" field at the very top of the form. + * Rendering a preview of the emoji when loading the page (through get_context() in EmojiFileUpload). - Commits:
-
Summary ID Author 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang 44ea86374597f452717b9555ed843122b81c7a43 mxiuwang aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang 05e73763cac1902c79b80131eacc8a579153e1ac mxiuwang aff938a30ff7e469d23ccc50fac55da63b84482e mxiuwang 5aea766a9f2ac3c496a09a80727fd476aef95b71 mxiuwang 413a6479e991bef5aadbc49bd50d8c9185994ff9 mxiuwang 81d9db02ab1196cf653dc46a1bc7789d57123591 mxiuwang 441e0104edac5f50a79c1679f9fda40e5f2cf126 mxiuwang 146aa88a4d69d36aff0c6a7a16c9bd56a98ec4f2 mxiuwang bfa9548136e4a6ebe929a4f2f4a25d66e49abc48 mxiuwang d10c4cd84e9463db47c12985406532600b42d944 mxiuwang 58b772e54a253940df0addb7a3ca676bdb0b20fc mxiuwang 395bd2aeb607fb12ea01454a7f45daaf9d86eb51 mxiuwang 44ea86374597f452717b9555ed843122b81c7a43 mxiuwang aeb6ddd87da468d8e8e3ed6af34e825f08a0d8ec mxiuwang b04ab1d482403d74c068d2357f5adba80412d4f1 mxiuwang 05e73763cac1902c79b80131eacc8a579153e1ac mxiuwang aff938a30ff7e469d23ccc50fac55da63b84482e mxiuwang 5aea766a9f2ac3c496a09a80727fd476aef95b71 mxiuwang 413a6479e991bef5aadbc49bd50d8c9185994ff9 mxiuwang deb9c6a9374fe41adc0fa2393e88c3ec7caa6acd mxiuwang a76d6448038388bfff67870a2ca170cb385a990b mxiuwang - Diff:
-
Revision 12 (+2172 -888)
Checks run (2 failed)
flake8
failed.
JSHint
failed.
flake8
-
Warning: Showing 30 of 55 failures.
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-