[WIP] Add functions for triggering an immediate update

Review Request #11861 — Created Oct. 21, 2021 and discarded

cynthia
Review Board
master
reviewboard

kAdd a new function "giveImmediateUpdates" in reviewRequestPageModel.js.
Let the view render the entry contents only when the entry box is not collapsed.
Modify the extend() and collapse() in the entryView class

TODO:
1. make sure collapsed review entries are not being loaded initially
2. remove console.log and other debugging code

WIP
Not tested

Summary Author
add console log for debug
Your Name
Description From Last Updated

Col: 54 Missing semicolon.

reviewbotreviewbot

I'm curious why we need to poke a value into this._watchedEntries here... where do we make use of it later ...

mike_conleymike_conley
Checks run (1 failed, 1 succeeded)
flake8 passed.
JSHint failed.

JSHint

cynthia
cynthia
mike_conley
  1. 
      
  2. I'm curious why we need to poke a value into this._watchedEntries here... where do we make use of it later on for this particular case? Because one of the side-effects here is now we have this entry added to the _watchedEntries array.

    What happens if we don't write to _watchedEntries here, and we don't reset _this._watchedUpdatesLastScheduleTime, but instead just directly call:

      this._loadUpdates({
        entries: [entry],
        onDone: this._scheduleCheckUpdates.bind(this),
      });
    

    ?

    1. you are definitely right. There is no need to write to watchedEntries and reset _this._watchedUpdatesLastScheduleTime. I'll fix that. Thanks!

  3. 
      
cynthia
cynthia
cynthia
david
Review request changed

Status: Discarded

Loading...