flake8
passed.
JSHint
failed.
[WIP] Add functions for triggering an immediate update
Review Request #11861 — Created Oct. 21, 2021 and discarded
kAdd a new function "giveImmediateUpdates" in reviewRequestPageModel.js.
Let the view render the entry contents only when the entry box is not collapsed.
Modify the extend() and collapse() in the entryView classTODO:
1. make sure collapsed review entries are not being loaded initially
2. remove console.log and other debugging code
WIP
Not tested
| Summary | ID | Author |
|---|---|---|
| e5efe2ddb94478ad7ed00ed9f96d6851a5894d43 | Your Name |
| Description | From | Last Updated |
|---|---|---|
|
Col: 54 Missing semicolon. |
 reviewbot
|
|
|
I'm curious why we need to poke a value into this._watchedEntries here... where do we make use of it later … |
 mike_conley
|
- Summary:
-
[WIP] Add function for triggering an immediate update[WIP] Add functions for triggering an immediate update
- Description:
-
Add a new function "giveImmediateUpdates" to reviewRequestPageModel.js.
Let the view render the entry contents only when the entry box is not collapsed. Changes to the base.html so the collapsed content doesn't have body element. TODO: Add a no-content state in base.html, so when an entry gets expanded we call the "giveImmediateUpdates" function when the entry does not have any content. TODO: Override the extend() function so it can trigger the "giveImmediateUpdates" ~ when needed ~ TODO: There might be syntax errors that need to be fixed ~ TODO: Remove redundant code ~ when needed. ~ TODO: There might be syntax errors that need to be fixed. ~ TODO: Remove redundant code.
- Description:
-
~ Add a new function "giveImmediateUpdates" to reviewRequestPageModel.js.
~ Add a new function "giveImmediateUpdates" in reviewRequestPageModel.js.
Let the view render the entry contents only when the entry box is not collapsed. ~ Changes to the base.html so the collapsed content doesn't have body element. ~ TODO: Add a no-content state in base.html, so when an entry gets expanded we call ~ the "giveImmediateUpdates" function when the entry does not have any content. ~ TODO: Override the extend() function so it can trigger the "giveImmediateUpdates" ~ when needed. ~ Modify the extend() and collapse() in the entryView class ~ ~ TODO: Now the entry fetches for content whenever it gets expanded.
~ Consider to add a “empty content” state in base.html, so when an entry gets expanded we call ~ the "giveImmediateUpdates" function only when the entry does not have any content. - TODO: There might be syntax errors that need to be fixed. - TODO: Remove redundant code. - Commits:
-
Summary ID Author d6f8d6a10aaaf61f2dddb3202381106453240680 Your Name ff9f5c8763534d8a0ee2c2aeaa2a3b45d34c51cc Your Name b36ffae52ce3d0700a33281dfeed55427c433f52 Your Name bed6890f25bb2152d585357596ccd08722eb68e6 Your Name d6f8d6a10aaaf61f2dddb3202381106453240680 Your Name ff9f5c8763534d8a0ee2c2aeaa2a3b45d34c51cc Your Name b36ffae52ce3d0700a33281dfeed55427c433f52 Your Name bed6890f25bb2152d585357596ccd08722eb68e6 Your Name f2c9e654bdbf525a1600b08c7f144abc429ed995 Your Name - Diff:
-
Revision 2 (+231 -127)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
-
-
I'm curious why we need to poke a value into
this._watchedEntrieshere... where do we make use of it later on for this particular case? Because one of the side-effects here is now we have this entry added to the_watchedEntriesarray.What happens if we don't write to
_watchedEntrieshere, and we don't reset_this._watchedUpdatesLastScheduleTime, but instead just directly call:this._loadUpdates({ entries: [entry], onDone: this._scheduleCheckUpdates.bind(this), });?
- Commits:
-
Summary ID Author d6f8d6a10aaaf61f2dddb3202381106453240680 Your Name ff9f5c8763534d8a0ee2c2aeaa2a3b45d34c51cc Your Name b36ffae52ce3d0700a33281dfeed55427c433f52 Your Name bed6890f25bb2152d585357596ccd08722eb68e6 Your Name f2c9e654bdbf525a1600b08c7f144abc429ed995 Your Name d6f8d6a10aaaf61f2dddb3202381106453240680 Your Name ff9f5c8763534d8a0ee2c2aeaa2a3b45d34c51cc Your Name b36ffae52ce3d0700a33281dfeed55427c433f52 Your Name bed6890f25bb2152d585357596ccd08722eb68e6 Your Name f2c9e654bdbf525a1600b08c7f144abc429ed995 Your Name df3a1cc3ac55cae1dad584f81f89ba1f5f7a866c Your Name - Diff:
-
Revision 3 (+226 -134)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
- Description:
-
~ Add a new function "giveImmediateUpdates" in reviewRequestPageModel.js.
~ kAdd a new function "giveImmediateUpdates" in reviewRequestPageModel.js.
Let the view render the entry contents only when the entry box is not collapsed. Modify the extend() and collapse() in the entryView class TODO: Now the entry fetches for content whenever it gets expanded.
Consider to add a “empty content” state in base.html, so when an entry gets expanded we call the "giveImmediateUpdates" function only when the entry does not have any content.
- Description:
-
kAdd a new function "giveImmediateUpdates" in reviewRequestPageModel.js.
Let the view render the entry contents only when the entry box is not collapsed. Modify the extend() and collapse() in the entryView class ~ TODO: Now the entry fetches for content whenever it gets expanded.
~ Consider to add a “empty content” state in base.html, so when an entry gets expanded we call ~ the "giveImmediateUpdates" function only when the entry does not have any content. ~ TODO:
~ 1. make sure collapsed review entries are not being loaded initially ~ 2. remove console.log and other debugging code - Commits:
-
Summary ID Author d6f8d6a10aaaf61f2dddb3202381106453240680 Your Name ff9f5c8763534d8a0ee2c2aeaa2a3b45d34c51cc Your Name b36ffae52ce3d0700a33281dfeed55427c433f52 Your Name bed6890f25bb2152d585357596ccd08722eb68e6 Your Name f2c9e654bdbf525a1600b08c7f144abc429ed995 Your Name df3a1cc3ac55cae1dad584f81f89ba1f5f7a866c Your Name e5efe2ddb94478ad7ed00ed9f96d6851a5894d43 Your Name - Diff:
-
Revision 4 (+168 -12)
Checks run (2 succeeded)
flake8
passed.
JSHint
passed.
