Summary

Remove add_metaclass compatibility shim.

Review Request #11844 — Created Oct. 7, 2021 and submitted Oct. 14, 2021, 12:34 p.m.

Information

Owner

david

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Now that 5.0 in Python 3 only, we can start moving away from all the
compatibility shims. This change does that for the @six.add_metaclass
decorator.

Testing Done

Ran unit tests.

Commits

Summary	ID
Remove add_metaclass compatibility shim. Now that 5.0 in Python 3 only, we can start moving away from all the compatibility shims. This change does that for the `@six.add_metaclass` decorator. Testing Done: Ran unit tests.	b694db943ca9988581dca738eeca12f6445b2ba7

Issues

Description	From	Last Updated
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:18 p.m.
E501 line too long (80 > 79 characters)	reviewbot	Oct. 7, 2021, 3:18 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:19 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:19 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:19 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:19 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:20 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:20 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:20 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:20 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:20 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:20 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:21 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:21 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:21 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:21 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:21 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:21 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:21 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:21 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:21 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:21 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:21 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:21 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:21 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:21 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:23 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:24 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:24 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:24 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:24 p.m.
E999 SyntaxError: invalid syntax	reviewbot	Oct. 7, 2021, 3:24 p.m.

flake8 failed.

JSHint passed.

flake8

reviewboard/extensions/hooks.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/extensions/hooks.py (Diff revision 1)
The issue has been resolved. Show all issues
```
E501 line too long (80 > 79 characters)
```
reviewboard/integrations/__init__.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_api_token.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_archived_review_request.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_default_reviewer.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_diff.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_diff_context.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_diff_file_attachment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_diffcommit.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_draft_diff.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_draft_diffcommit.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_draft_filediff.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_draft_original_file.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_draft_patched_file.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_file_attachment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_file_attachment_comment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_file_attachment_draft.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_file_diff_comment.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_filediff.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_hosting_service.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_hosting_service_account.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_oauth_app.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_oauth_token.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_original_file.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_patched_file.py (Diff revision 1)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```

Commits:

	Summary	ID
	Remove add_metaclass compatibility shim. Now that 5.0 in Python 3 only, we can start moving away from all the compatibility shims. This change does that for the `@six.add_metaclass` decorator. Testing Done: Ran unit tests.	295098bbce4381932c9c1a8dbaa77cab67030470
	Remove add_metaclass compatibility shim. Now that 5.0 in Python 3 only, we can start moving away from all the compatibility shims. This change does that for the `@six.add_metaclass` decorator. Testing Done: Ran unit tests.	b694db943ca9988581dca738eeca12f6445b2ba7

Diff:

Revision 2 (+338 -620)

Show changes

	reviewboard/extensions/hooks.py
	reviewboard/integrations/__init__.py
	reviewboard/webapi/tests/test_api_token.py
	reviewboard/webapi/tests/test_archived_review_request.py
	reviewboard/webapi/tests/test_default_reviewer.py
	reviewboard/webapi/tests/test_diff.py
	reviewboard/webapi/tests/test_diff_context.py
	reviewboard/webapi/tests/test_diff_file_attachment.py
	51 more

Checks run (1 failed, 1 succeeded)

flake8 failed.

JSHint passed.

flake8

reviewboard/extensions/hooks.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/integrations/__init__.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_api_token.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_archived_review_request.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_default_reviewer.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_diff.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_diff_context.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_diff_file_attachment.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_diffcommit.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_draft_diff.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_draft_diffcommit.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_draft_filediff.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_draft_original_file.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_draft_patched_file.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_file_attachment.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_file_attachment_comment.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_file_attachment_draft.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_file_diff_comment.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_filediff.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_hosting_service.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_hosting_service_account.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_oauth_app.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_oauth_token.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_original_file.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```
reviewboard/webapi/tests/test_patched_file.py (Diff revision 2)
The issue has been dropped. Show all issues
```
E999 SyntaxError: invalid syntax
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to master (b4fc10b)